Re: [PR] Add support for C-style comments [datafusion-sqlparser-rs]

2025-09-23 Thread via GitHub
iffyio commented on code in PR #2034: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2034#discussion_r2371942961 ## src/dialect/mod.rs: ## @@ -898,6 +898,12 @@ pub trait Dialect: Debug + Any { false } +/// Returns true if the dialect supports hi

Re: [PR] Add support for C-style comments [datafusion-sqlparser-rs]

2025-09-19 Thread via GitHub
altmannmarcelo commented on code in PR #2034: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2034#discussion_r2362608437 ## src/tokenizer.rs: ## @@ -4070,4 +4101,39 @@ mod tests { panic!("Tokenizer should have failed on {sql}, but it succeeded with {t

Re: [PR] Add support for C-style comments [datafusion-sqlparser-rs]

2025-09-19 Thread via GitHub
iffyio commented on code in PR #2034: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2034#discussion_r2362118563 ## src/dialect/mod.rs: ## @@ -898,6 +898,11 @@ pub trait Dialect: Debug + Any { false } +/// Returns true if the dialect supports hi

[PR] Add support for C-style comments [datafusion-sqlparser-rs]

2025-09-16 Thread via GitHub
altmannmarcelo opened a new pull request, #2034: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2034 This commit adds support for C-style comments supported by MySQL. It parses and consumes the optional version number after the `!` character. -- This is an automated message f