alamb commented on code in PR #10648:
URL: https://github.com/apache/datafusion/pull/10648#discussion_r1617221359
##
datafusion/optimizer/src/replace_distinct_aggregate.rs:
##
@@ -99,17 +97,7 @@ impl OptimizerRule for ReplaceDistinctWithAggregate {
// Construct
mustafasrepo commented on code in PR #10648:
URL: https://github.com/apache/datafusion/pull/10648#discussion_r1616028814
##
datafusion/optimizer/src/replace_distinct_aggregate.rs:
##
@@ -99,17 +97,7 @@ impl OptimizerRule for ReplaceDistinctWithAggregate {
// Con
jayzhan211 commented on code in PR #10648:
URL: https://github.com/apache/datafusion/pull/10648#discussion_r1615994413
##
datafusion/optimizer/src/replace_distinct_aggregate.rs:
##
@@ -99,17 +97,7 @@ impl OptimizerRule for ReplaceDistinctWithAggregate {
// Const
mustafasrepo merged PR #10648:
URL: https://github.com/apache/datafusion/pull/10648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@d
mustafasrepo commented on code in PR #10648:
URL: https://github.com/apache/datafusion/pull/10648#discussion_r1615539401
##
datafusion/physical-expr-common/src/utils.rs:
##
@@ -100,15 +103,37 @@ pub fn reverse_order_bys(order_bys: &[PhysicalSortExpr])
-> Vec`.
+/// If conversio
alamb commented on code in PR #10648:
URL: https://github.com/apache/datafusion/pull/10648#discussion_r1614514043
##
datafusion/physical-expr-common/src/utils.rs:
##
@@ -100,15 +103,37 @@ pub fn reverse_order_bys(order_bys: &[PhysicalSortExpr])
-> Vec`.
+/// If conversion is no
jayzhan211 commented on code in PR #10648:
URL: https://github.com/apache/datafusion/pull/10648#discussion_r1613370248
##
datafusion/functions-aggregate/src/first_last.rs:
##
@@ -161,6 +144,23 @@ impl AggregateUDFImpl for FirstValue {
fn aliases(&self) -> &[String] {
mustafasrepo opened a new pull request, #10648:
URL: https://github.com/apache/datafusion/pull/10648
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
## Are these changes test
