timsaucer commented on PR #981:
URL:
https://github.com/apache/datafusion-python/pull/981#issuecomment-2585006200
Thank you for another great addition @kosiew !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
timsaucer merged PR #981:
URL: https://github.com/apache/datafusion-python/pull/981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@d
timsaucer commented on PR #981:
URL:
https://github.com/apache/datafusion-python/pull/981#issuecomment-2579966500
It looks like some minor difference in ruff versions probably caused yours
to pass and the CI to fail. I pushed a correction to this branch.
--
This is an automated message f
kosiew commented on PR #981:
URL:
https://github.com/apache/datafusion-python/pull/981#issuecomment-2579331381
Does anyone know how to fix this error:
```
ruff check --output-format=github python/
ruff format --check python/
shell: /usr/bin/bash -e {0}
env:
py
kosiew commented on code in PR #981:
URL: https://github.com/apache/datafusion-python/pull/981#discussion_r1908071361
##
python/datafusion/dataframe.py:
##
@@ -35,6 +35,65 @@
from datafusion._internal import DataFrame as DataFrameInternal
from datafusion.expr import Expr, So
kosiew commented on code in PR #981:
URL: https://github.com/apache/datafusion-python/pull/981#discussion_r1908071116
##
python/datafusion/dataframe.py:
##
@@ -620,17 +679,34 @@ def write_csv(self, path: str | pathlib.Path,
with_header: bool = False) -> None
def write_parq
kosiew commented on code in PR #981:
URL: https://github.com/apache/datafusion-python/pull/981#discussion_r1908068498
##
python/datafusion/dataframe.py:
##
@@ -620,17 +679,34 @@ def write_csv(self, path: str | pathlib.Path,
with_header: bool = False) -> None
def write_parq
timsaucer commented on code in PR #981:
URL: https://github.com/apache/datafusion-python/pull/981#discussion_r1907925883
##
python/datafusion/dataframe.py:
##
@@ -620,17 +679,34 @@ def write_csv(self, path: str | pathlib.Path,
with_header: bool = False) -> None
def write_p
kosiew commented on code in PR #981:
URL: https://github.com/apache/datafusion-python/pull/981#discussion_r1906516715
##
python/datafusion/dataframe.py:
##
@@ -620,16 +620,25 @@ def write_csv(self, path: str | pathlib.Path,
with_header: bool = False) -> None
def write_parq
kosiew commented on code in PR #981:
URL: https://github.com/apache/datafusion-python/pull/981#discussion_r1906516715
##
python/datafusion/dataframe.py:
##
@@ -620,16 +620,25 @@ def write_csv(self, path: str | pathlib.Path,
with_header: bool = False) -> None
def write_parq
kosiew commented on code in PR #981:
URL: https://github.com/apache/datafusion-python/pull/981#discussion_r1906516715
##
python/datafusion/dataframe.py:
##
@@ -620,16 +620,25 @@ def write_csv(self, path: str | pathlib.Path,
with_header: bool = False) -> None
def write_parq
kosiew commented on code in PR #981:
URL: https://github.com/apache/datafusion-python/pull/981#discussion_r1906516715
##
python/datafusion/dataframe.py:
##
@@ -620,16 +620,25 @@ def write_csv(self, path: str | pathlib.Path,
with_header: bool = False) -> None
def write_parq
kosiew commented on code in PR #981:
URL: https://github.com/apache/datafusion-python/pull/981#discussion_r1906516715
##
python/datafusion/dataframe.py:
##
@@ -620,16 +620,25 @@ def write_csv(self, path: str | pathlib.Path,
with_header: bool = False) -> None
def write_parq
ion-elgreco commented on code in PR #981:
URL: https://github.com/apache/datafusion-python/pull/981#discussion_r1905619163
##
python/datafusion/dataframe.py:
##
@@ -620,16 +620,25 @@ def write_csv(self, path: str | pathlib.Path,
with_header: bool = False) -> None
def write
kevinjqliu commented on code in PR #981:
URL: https://github.com/apache/datafusion-python/pull/981#discussion_r1905611807
##
python/datafusion/dataframe.py:
##
@@ -620,16 +620,25 @@ def write_csv(self, path: str | pathlib.Path,
with_header: bool = False) -> None
def write_
kosiew commented on code in PR #981:
URL: https://github.com/apache/datafusion-python/pull/981#discussion_r1904826148
##
python/datafusion/dataframe.py:
##
@@ -620,16 +620,25 @@ def write_csv(self, path: str | pathlib.Path,
with_header: bool = False) -> None
def write_parq
kevinjqliu commented on code in PR #981:
URL: https://github.com/apache/datafusion-python/pull/981#discussion_r1904816353
##
python/datafusion/dataframe.py:
##
@@ -620,16 +620,25 @@ def write_csv(self, path: str | pathlib.Path,
with_header: bool = False) -> None
def write_
kosiew commented on code in PR #981:
URL: https://github.com/apache/datafusion-python/pull/981#discussion_r1904789223
##
python/datafusion/dataframe.py:
##
@@ -620,16 +620,24 @@ def write_csv(self, path: str | pathlib.Path,
with_header: bool = False) -> None
def write_parq
kosiew commented on code in PR #981:
URL: https://github.com/apache/datafusion-python/pull/981#discussion_r1904789223
##
python/datafusion/dataframe.py:
##
@@ -620,16 +620,24 @@ def write_csv(self, path: str | pathlib.Path,
with_header: bool = False) -> None
def write_parq
kylebarron commented on code in PR #981:
URL: https://github.com/apache/datafusion-python/pull/981#discussion_r1904715954
##
python/datafusion/dataframe.py:
##
@@ -620,16 +620,24 @@ def write_csv(self, path: str | pathlib.Path,
with_header: bool = False) -> None
def write_
kosiew commented on code in PR #981:
URL: https://github.com/apache/datafusion-python/pull/981#discussion_r1899871918
##
python/datafusion/dataframe.py:
##
@@ -620,16 +620,24 @@ def write_csv(self, path: str | pathlib.Path,
with_header: bool = False) -> None
def write_parq
ion-elgreco commented on PR #981:
URL:
https://github.com/apache/datafusion-python/pull/981#issuecomment-2564288959
In delta-rs we have the default to use "snappy" compression, except our
optimize operation which uses ZSTD(4)
--
This is an automated message from the Apache Git Service.
T
kosiew commented on code in PR #981:
URL: https://github.com/apache/datafusion-python/pull/981#discussion_r1898185864
##
python/datafusion/dataframe.py:
##
@@ -620,16 +620,24 @@ def write_csv(self, path: str | pathlib.Path,
with_header: bool = False) -> None
def write_parq
kosiew commented on code in PR #981:
URL: https://github.com/apache/datafusion-python/pull/981#discussion_r1898185864
##
python/datafusion/dataframe.py:
##
@@ -620,16 +620,24 @@ def write_csv(self, path: str | pathlib.Path,
with_header: bool = False) -> None
def write_parq
kosiew commented on code in PR #981:
URL: https://github.com/apache/datafusion-python/pull/981#discussion_r1898185454
##
python/datafusion/dataframe.py:
##
@@ -620,16 +620,24 @@ def write_csv(self, path: str | pathlib.Path,
with_header: bool = False) -> None
def write_parq
kylebarron commented on code in PR #981:
URL: https://github.com/apache/datafusion-python/pull/981#discussion_r1896895123
##
python/datafusion/dataframe.py:
##
@@ -620,16 +620,24 @@ def write_csv(self, path: str | pathlib.Path,
with_header: bool = False) -> None
def write_
kylebarron commented on code in PR #981:
URL: https://github.com/apache/datafusion-python/pull/981#discussion_r1896894738
##
python/datafusion/dataframe.py:
##
@@ -620,16 +620,24 @@ def write_csv(self, path: str | pathlib.Path,
with_header: bool = False) -> None
def write_
kosiew opened a new pull request, #981:
URL: https://github.com/apache/datafusion-python/pull/981
# Which issue does this PR close?
Closes #978.
# Rationale for this change
Currently, the write_parquet method defaults to "uncompressed" Parquet
files, whi
28 matches
Mail list logo
