alamb merged PR #15039:
URL: https://github.com/apache/datafusion/pull/15039
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #15039:
URL: https://github.com/apache/datafusion/pull/15039#issuecomment-2746381811
THanks again !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
LuQQiu commented on PR #15039:
URL: https://github.com/apache/datafusion/pull/15039#issuecomment-2748650838
Thanks for all the reviews and suggestions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
LuQQiu commented on PR #15039:
URL: https://github.com/apache/datafusion/pull/15039#issuecomment-2741622696
@alamb @Weijun-H Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
alamb commented on PR #15039:
URL: https://github.com/apache/datafusion/pull/15039#issuecomment-2730069735
This PR appears to have some build / CI failures that are preventing it from
merging so marking it as drat
@LuQQiu can you please resolve the issues so it can be merged?
--
Th
LuQQiu commented on code in PR #15039:
URL: https://github.com/apache/datafusion/pull/15039#discussion_r1985809872
##
datafusion/sqllogictest/test_files/array.slt:
##
@@ -5818,6 +5818,13 @@ false false false false
false false false false
false false false false
+query BB
Re
alamb commented on code in PR #15039:
URL: https://github.com/apache/datafusion/pull/15039#discussion_r1985679028
##
datafusion/sqllogictest/test_files/array.slt:
##
@@ -5818,6 +5818,13 @@ false false false false
false false false false
false false false false
+query BB
Rev
Weijun-H commented on code in PR #15039:
URL: https://github.com/apache/datafusion/pull/15039#discussion_r1985179602
##
datafusion/functions-nested/src/array_has.rs:
##
@@ -439,6 +439,16 @@ fn array_has_all_and_any_dispatch(
) -> Result {
let haystack = as_generic_list_arr
Weijun-H commented on code in PR #15039:
URL: https://github.com/apache/datafusion/pull/15039#discussion_r1985179602
##
datafusion/functions-nested/src/array_has.rs:
##
@@ -439,6 +439,16 @@ fn array_has_all_and_any_dispatch(
) -> Result {
let haystack = as_generic_list_arr
westonpace commented on code in PR #15039:
URL: https://github.com/apache/datafusion/pull/15039#discussion_r1983700811
##
datafusion/functions-nested/src/array_has.rs:
##
@@ -439,6 +439,14 @@ fn array_has_all_and_any_dispatch(
) -> Result {
let haystack = as_generic_list_a
LuQQiu commented on code in PR #15039:
URL: https://github.com/apache/datafusion/pull/15039#discussion_r1983838025
##
datafusion/functions-nested/src/array_has.rs:
##
@@ -439,6 +439,14 @@ fn array_has_all_and_any_dispatch(
) -> Result {
let haystack = as_generic_list_array
jayzhan211 commented on code in PR #15039:
URL: https://github.com/apache/datafusion/pull/15039#discussion_r1983280996
##
datafusion/functions-nested/src/array_has.rs:
##
@@ -439,6 +439,14 @@ fn array_has_all_and_any_dispatch(
) -> Result {
let haystack = as_generic_list_a
alan910127 commented on code in PR #15039:
URL: https://github.com/apache/datafusion/pull/15039#discussion_r1982608655
##
datafusion/functions-nested/src/array_has.rs:
##
@@ -439,6 +439,14 @@ fn array_has_all_and_any_dispatch(
) -> Result {
let haystack = as_generic_list_a
LuQQiu commented on code in PR #15039:
URL: https://github.com/apache/datafusion/pull/15039#discussion_r1982505448
##
datafusion/functions-nested/src/array_has.rs:
##
@@ -439,6 +439,14 @@ fn array_has_all_and_any_dispatch(
) -> Result {
let haystack = as_generic_list_array
LuQQiu commented on code in PR #15039:
URL: https://github.com/apache/datafusion/pull/15039#discussion_r1982505448
##
datafusion/functions-nested/src/array_has.rs:
##
@@ -439,6 +439,14 @@ fn array_has_all_and_any_dispatch(
) -> Result {
let haystack = as_generic_list_array
westonpace commented on code in PR #15039:
URL: https://github.com/apache/datafusion/pull/15039#discussion_r1982443721
##
datafusion/functions-nested/src/array_has.rs:
##
@@ -439,6 +439,14 @@ fn array_has_all_and_any_dispatch(
) -> Result {
let haystack = as_generic_list_a
LuQQiu commented on PR #15039:
URL: https://github.com/apache/datafusion/pull/15039#issuecomment-2702483400
@jayzhan211 Could you help approve the test workflows and review the PR?
Thanks in advance
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
LuQQiu opened a new pull request, #15039:
URL: https://github.com/apache/datafusion/pull/15039
## Which issue does this PR close?
- Closes #15038
## What changes are included in this PR?
Fix array_has_any and array_has_all with empty array input
## Are these chang
18 matches
Mail list logo
