alamb commented on PR #10445:
URL: https://github.com/apache/datafusion/pull/10445#issuecomment-2109963296
Thanks again @b41sh !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
alamb merged PR #10445:
URL: https://github.com/apache/datafusion/pull/10445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
b41sh commented on PR #10445:
URL: https://github.com/apache/datafusion/pull/10445#issuecomment-2109387380
> Look good to me -- thank you @b41sh and @jayzhan211
>
> I had some small code suggestions but I don't think they are required to
merge this PR
Very good suggestion, I ha
jayzhan211 commented on code in PR #10445:
URL: https://github.com/apache/datafusion/pull/10445#discussion_r1599384143
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -2140,4 +2156,25 @@ mod tests {
);
Ok(())
}
+
+#[test]
+fn test_values() ->
alamb commented on code in PR #10445:
URL: https://github.com/apache/datafusion/pull/10445#discussion_r1598903909
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -188,37 +181,59 @@ impl LogicalPlanBuilder {
n_cols
);
}
-
jayzhan211 commented on code in PR #10445:
URL: https://github.com/apache/datafusion/pull/10445#discussion_r1597524103
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -188,37 +181,61 @@ impl LogicalPlanBuilder {
n_cols
);
jayzhan211 commented on code in PR #10445:
URL: https://github.com/apache/datafusion/pull/10445#discussion_r1597524103
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -188,37 +181,61 @@ impl LogicalPlanBuilder {
n_cols
);
b41sh commented on code in PR #10445:
URL: https://github.com/apache/datafusion/pull/10445#discussion_r1597465482
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -188,37 +181,61 @@ impl LogicalPlanBuilder {
n_cols
);
}
-
jayzhan211 commented on code in PR #10445:
URL: https://github.com/apache/datafusion/pull/10445#discussion_r1597438771
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -188,37 +181,61 @@ impl LogicalPlanBuilder {
n_cols
);
jayzhan211 commented on code in PR #10445:
URL: https://github.com/apache/datafusion/pull/10445#discussion_r1597438771
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -188,37 +181,61 @@ impl LogicalPlanBuilder {
n_cols
);
jayzhan211 commented on code in PR #10445:
URL: https://github.com/apache/datafusion/pull/10445#discussion_r1597437435
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -188,37 +181,61 @@ impl LogicalPlanBuilder {
n_cols
);
jayzhan211 commented on code in PR #10445:
URL: https://github.com/apache/datafusion/pull/10445#discussion_r1597437435
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -188,37 +181,61 @@ impl LogicalPlanBuilder {
n_cols
);
b41sh commented on code in PR #10445:
URL: https://github.com/apache/datafusion/pull/10445#discussion_r1597433886
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -188,37 +181,61 @@ impl LogicalPlanBuilder {
n_cols
);
}
-
b41sh commented on code in PR #10445:
URL: https://github.com/apache/datafusion/pull/10445#discussion_r1597432978
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -188,37 +181,61 @@ impl LogicalPlanBuilder {
n_cols
);
}
-
alamb commented on code in PR #10445:
URL: https://github.com/apache/datafusion/pull/10445#discussion_r1597428939
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -188,37 +181,61 @@ impl LogicalPlanBuilder {
n_cols
);
}
-
b41sh commented on code in PR #10445:
URL: https://github.com/apache/datafusion/pull/10445#discussion_r1597413786
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -188,37 +181,61 @@ impl LogicalPlanBuilder {
n_cols
);
}
-
yyy1000 commented on code in PR #10445:
URL: https://github.com/apache/datafusion/pull/10445#discussion_r1597339778
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -188,37 +181,61 @@ impl LogicalPlanBuilder {
n_cols
);
}
-
jayzhan211 commented on code in PR #10445:
URL: https://github.com/apache/datafusion/pull/10445#discussion_r1597326136
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -188,37 +181,61 @@ impl LogicalPlanBuilder {
n_cols
);
jayzhan211 commented on code in PR #10445:
URL: https://github.com/apache/datafusion/pull/10445#discussion_r1597326136
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -188,37 +181,61 @@ impl LogicalPlanBuilder {
n_cols
);
jayzhan211 commented on code in PR #10445:
URL: https://github.com/apache/datafusion/pull/10445#discussion_r1597326136
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -188,37 +181,61 @@ impl LogicalPlanBuilder {
n_cols
);
alamb commented on code in PR #10445:
URL: https://github.com/apache/datafusion/pull/10445#discussion_r1597133318
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -188,37 +181,61 @@ impl LogicalPlanBuilder {
n_cols
);
}
-
b41sh opened a new pull request, #10445:
URL: https://github.com/apache/datafusion/pull/10445
## Which issue does this PR close?
Closes #10440
## Rationale for this change
## What changes are included in this PR?
## Are these changes tested?
22 matches
Mail list logo
