Re: [PR] Implement Unparse `GroupingSet` Expr --> String Support sql [datafusion]

2024-05-20 Thread via GitHub
alamb merged PR #10555: URL: https://github.com/apache/datafusion/pull/10555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] Implement Unparse `GroupingSet` Expr --> String Support sql [datafusion]

2024-05-18 Thread via GitHub
xinlifoobar commented on code in PR #10555: URL: https://github.com/apache/datafusion/pull/10555#discussion_r1605709554 ## datafusion/sql/src/unparser/expr.rs: ## @@ -411,9 +411,34 @@ impl Unparser<'_> { Expr::Wildcard { qualifier: _ } => { not_impl

Re: [PR] Implement Unparse `GroupingSet` Expr --> String Support sql [datafusion]

2024-05-17 Thread via GitHub
alamb commented on code in PR #10555: URL: https://github.com/apache/datafusion/pull/10555#discussion_r1605496677 ## datafusion/sql/src/unparser/expr.rs: ## @@ -411,9 +411,34 @@ impl Unparser<'_> { Expr::Wildcard { qualifier: _ } => { not_impl_err!(

[PR] Implement Unparse `GroupingSet` Expr --> String Support sql [datafusion]

2024-05-17 Thread via GitHub
xinlifoobar opened a new pull request, #10555: URL: https://github.com/apache/datafusion/pull/10555 ## Which issue does this PR close? Closes #10521. ## Rationale for this change ## What changes are included in this PR? ## Are these changes