Re: [PR] Improve flight sql examples [datafusion]

2024-05-10 Thread via GitHub
alamb commented on code in PR #10432: URL: https://github.com/apache/datafusion/pull/10432#discussion_r1596654105 ## datafusion-examples/examples/flight/flight_sql_server.rs: ## @@ -304,267 +313,50 @@ impl FlightSqlService for FlightSqlServiceImpl { }; let buf

Re: [PR] Improve flight sql examples [datafusion]

2024-05-10 Thread via GitHub
alamb merged PR #10432: URL: https://github.com/apache/datafusion/pull/10432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] Improve flight sql examples [datafusion]

2024-05-09 Thread via GitHub
lewiszlw commented on code in PR #10432: URL: https://github.com/apache/datafusion/pull/10432#discussion_r1596181005 ## datafusion-examples/examples/flight/flight_sql_server.rs: ## @@ -337,234 +346,52 @@ impl FlightSqlService for FlightSqlServiceImpl { Ok(resp) }

Re: [PR] Improve flight sql examples [datafusion]

2024-05-09 Thread via GitHub
alamb commented on code in PR #10432: URL: https://github.com/apache/datafusion/pull/10432#discussion_r1595344465 ## datafusion-examples/examples/flight/flight_sql_server.rs: ## @@ -246,27 +276,6 @@ impl FlightSqlService for FlightSqlServiceImpl { Ok(Response::new(Box::

[PR] Improve flight sql examples [datafusion]

2024-05-09 Thread via GitHub
lewiszlw opened a new pull request, #10432: URL: https://github.com/apache/datafusion/pull/10432 ## Which issue does this PR close? Implement `get_flight_info_tables` and remove unimplemented methods. ## Rationale for this change ## What changes are in