alamb commented on PR #10644:
URL: https://github.com/apache/datafusion/pull/10644#issuecomment-2132160586
Thanks again @jayzhan211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
alamb merged PR #10644:
URL: https://github.com/apache/datafusion/pull/10644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
jayzhan211 commented on code in PR #10644:
URL: https://github.com/apache/datafusion/pull/10644#discussion_r1614957716
##
datafusion/sqllogictest/test_files/aggregate.slt:
##
@@ -871,6 +871,33 @@ select median(distinct c) from t;
statement ok
drop table t;
+# optimize distin
jayzhan211 commented on code in PR #10644:
URL: https://github.com/apache/datafusion/pull/10644#discussion_r1614640283
##
datafusion/functions-aggregate/Cargo.toml:
##
@@ -39,6 +39,7 @@ path = "src/lib.rs"
[dependencies]
arrow = { workspace = true }
+arrow-schema = { workspa
alamb commented on code in PR #10644:
URL: https://github.com/apache/datafusion/pull/10644#discussion_r1614539590
##
datafusion/functions-aggregate/src/median.rs:
##
@@ -15,71 +15,105 @@
// specific language governing permissions and limitations
// under the License.
-//! #
jayzhan211 commented on code in PR #10644:
URL: https://github.com/apache/datafusion/pull/10644#discussion_r1613550658
##
datafusion/functions-aggregate/Cargo.toml:
##
@@ -39,6 +39,7 @@ path = "src/lib.rs"
[dependencies]
arrow = { workspace = true }
+arrow-schema = { workspa
jayzhan211 commented on code in PR #10644:
URL: https://github.com/apache/datafusion/pull/10644#discussion_r1613540288
##
datafusion/functions-aggregate/src/median.rs:
##
@@ -15,71 +15,105 @@
// specific language governing permissions and limitations
// under the License.
-/
