Re: [PR] Overflow in negate operator [datafusion]

2024-06-24 Thread via GitHub
LorrensP-2158466 commented on code in PR #11084: URL: https://github.com/apache/datafusion/pull/11084#discussion_r1650527162 ## datafusion/common/src/scalar/mod.rs: ## @@ -5494,6 +5566,69 @@ mod tests { Ok(()) } +#[test] +#[allow(arithmetic_overflow)] //

Re: [PR] Overflow in negate operator [datafusion]

2024-06-24 Thread via GitHub
LorrensP-2158466 commented on code in PR #11084: URL: https://github.com/apache/datafusion/pull/11084#discussion_r1650523030 ## datafusion/common/src/scalar/mod.rs: ## @@ -1177,40 +1185,103 @@ impl ScalarValue { | ScalarValue::Float64(None) => Ok(self.clone()),

Re: [PR] Overflow in negate operator [datafusion]

2024-06-23 Thread via GitHub
alamb commented on code in PR #11084: URL: https://github.com/apache/datafusion/pull/11084#discussion_r1650272446 ## datafusion/common/src/scalar/mod.rs: ## @@ -5494,6 +5566,69 @@ mod tests { Ok(()) } +#[test] +#[allow(arithmetic_overflow)] // we want to