Re: [PR] Stop copying LogicalPlan and Exprs in `ReplaceDistinctWithAggregate` [datafusion]

2024-05-13 Thread via GitHub
alamb merged PR #10460: URL: https://github.com/apache/datafusion/pull/10460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] Stop copying LogicalPlan and Exprs in `ReplaceDistinctWithAggregate` [datafusion]

2024-05-13 Thread via GitHub
alamb commented on code in PR #10460: URL: https://github.com/apache/datafusion/pull/10460#discussion_r1598480059 ## datafusion/optimizer/src/replace_distinct_aggregate.rs: ## @@ -88,60 +94,72 @@ impl OptimizerRule for ReplaceDistinctWithAggregate { input,

Re: [PR] Stop copying LogicalPlan and Exprs in `ReplaceDistinctWithAggregate` [datafusion]

2024-05-12 Thread via GitHub
alamb commented on code in PR #10460: URL: https://github.com/apache/datafusion/pull/10460#discussion_r1597601176 ## datafusion/optimizer/src/replace_distinct_aggregate.rs: ## @@ -88,60 +94,72 @@ impl OptimizerRule for ReplaceDistinctWithAggregate { input,

Re: [PR] Stop copying LogicalPlan and Exprs in `ReplaceDistinctWithAggregate` [datafusion]

2024-05-12 Thread via GitHub
alamb commented on code in PR #10460: URL: https://github.com/apache/datafusion/pull/10460#discussion_r1597600173 ## datafusion/optimizer/src/replace_distinct_aggregate.rs: ## @@ -88,60 +94,72 @@ impl OptimizerRule for ReplaceDistinctWithAggregate { input,