Re: [PR] Support dictionary data type in array_to_string [datafusion]

2024-06-23 Thread via GitHub
alamb commented on PR #10908: URL: https://github.com/apache/datafusion/pull/10908#issuecomment-2184932279 Thanks again @EduardoVega and @Weijun-H -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Support dictionary data type in array_to_string [datafusion]

2024-06-23 Thread via GitHub
alamb merged PR #10908: URL: https://github.com/apache/datafusion/pull/10908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] Support dictionary data type in array_to_string [datafusion]

2024-06-22 Thread via GitHub
alamb commented on code in PR #10908: URL: https://github.com/apache/datafusion/pull/10908#discussion_r1649449221 ## datafusion/functions-array/src/string.rs: ## @@ -281,6 +283,49 @@ pub(super) fn array_to_string_inner(args: &[ArrayRef]) -> Result { Ok(arg)

Re: [PR] Support dictionary data type in array_to_string [datafusion]

2024-06-17 Thread via GitHub
EduardoVega commented on code in PR #10908: URL: https://github.com/apache/datafusion/pull/10908#discussion_r1643158929 ## datafusion/functions-array/src/string.rs: ## @@ -281,6 +281,24 @@ pub(super) fn array_to_string_inner(args: &[ArrayRef]) -> Result { Ok(

Re: [PR] Support dictionary data type in array_to_string [datafusion]

2024-06-17 Thread via GitHub
alamb commented on code in PR #10908: URL: https://github.com/apache/datafusion/pull/10908#discussion_r1643081498 ## datafusion/functions-array/src/string.rs: ## @@ -281,6 +281,24 @@ pub(super) fn array_to_string_inner(args: &[ArrayRef]) -> Result { Ok(arg)

Re: [PR] Support dictionary data type in array_to_string [datafusion]

2024-06-17 Thread via GitHub
EduardoVega commented on code in PR #10908: URL: https://github.com/apache/datafusion/pull/10908#discussion_r1642751426 ## datafusion/functions-array/src/string.rs: ## @@ -281,6 +281,31 @@ pub(super) fn array_to_string_inner(args: &[ArrayRef]) -> Result { Ok(

Re: [PR] Support dictionary data type in array_to_string [datafusion]

2024-06-16 Thread via GitHub
Weijun-H commented on code in PR #10908: URL: https://github.com/apache/datafusion/pull/10908#discussion_r1642217621 ## datafusion/functions-array/src/string.rs: ## @@ -281,6 +281,31 @@ pub(super) fn array_to_string_inner(args: &[ArrayRef]) -> Result { Ok(arg

Re: [PR] Support dictionary data type in array_to_string [datafusion]

2024-06-14 Thread via GitHub
EduardoVega commented on code in PR #10908: URL: https://github.com/apache/datafusion/pull/10908#discussion_r1640045366 ## datafusion/functions-array/src/string.rs: ## @@ -281,6 +281,21 @@ pub(super) fn array_to_string_inner(args: &[ArrayRef]) -> Result { Ok(

Re: [PR] Support dictionary data type in array_to_string [datafusion]

2024-06-13 Thread via GitHub
alamb commented on code in PR #10908: URL: https://github.com/apache/datafusion/pull/10908#discussion_r1639090072 ## datafusion/functions-array/src/string.rs: ## @@ -281,6 +281,21 @@ pub(super) fn array_to_string_inner(args: &[ArrayRef]) -> Result { Ok(arg)

[PR] Support dictionary data type in array_to_string [datafusion]

2024-06-13 Thread via GitHub
EduardoVega opened a new pull request, #10908: URL: https://github.com/apache/datafusion/pull/10908 ## Which issue does this PR close? Closes #10862 ## Rationale for this change Go to issue. ## What changes are included in this PR? D