Re: [PR] Support for Map values in ClickHouse settings [datafusion-sqlparser-rs]

2025-06-24 Thread via GitHub
iffyio commented on code in PR #1896: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1896#discussion_r2163073711 ## src/test_utils.rs: ## @@ -366,6 +366,11 @@ pub fn number(n: &str) -> Value { Value::Number(n.parse().unwrap(), false) } +/// Creates a `Value

Re: [PR] Support for Map values in ClickHouse settings [datafusion-sqlparser-rs]

2025-06-22 Thread via GitHub
solontsev commented on code in PR #1896: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1896#discussion_r2160273062 ## src/parser/mod.rs: ## @@ -3156,18 +3156,21 @@ impl<'a> Parser<'a> { /// ``` /// /// [dictionary]: https://duckdb.org/docs/sql/data

Re: [PR] Support for Map values in ClickHouse settings [datafusion-sqlparser-rs]

2025-06-22 Thread via GitHub
solontsev commented on code in PR #1896: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1896#discussion_r2160273062 ## src/parser/mod.rs: ## @@ -3156,18 +3156,21 @@ impl<'a> Parser<'a> { /// ``` /// /// [dictionary]: https://duckdb.org/docs/sql/data

Re: [PR] Support for Map values in ClickHouse settings [datafusion-sqlparser-rs]

2025-06-22 Thread via GitHub
iffyio commented on code in PR #1896: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1896#discussion_r2160244131 ## src/parser/mod.rs: ## @@ -3156,18 +3156,21 @@ impl<'a> Parser<'a> { /// ``` /// /// [dictionary]: https://duckdb.org/docs/sql/data_ty

[PR] Support for Map values in ClickHouse settings [datafusion-sqlparser-rs]

2025-06-20 Thread via GitHub
solontsev opened a new pull request, #1896: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1896 https://clickhouse.com/docs/operations/settings/settings#additional_table_filters Current implementation only parses simple settings with key = value format -- This is an au