Re: [PR] UDAF: Extend more args to `state_fields` and `groups_accumulator_supported` and introduce `ReversedUDAF` [datafusion]

2024-05-15 Thread via GitHub
jayzhan211 merged PR #10525: URL: https://github.com/apache/datafusion/pull/10525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@dat

Re: [PR] UDAF: Extend more args to `state_fields` and `groups_accumulator_supported` and introduce `ReversedUDAF` [datafusion]

2024-05-15 Thread via GitHub
jayzhan211 commented on code in PR #10525: URL: https://github.com/apache/datafusion/pull/10525#discussion_r1602371415 ## datafusion/expr/src/function.rs: ## @@ -66,22 +69,39 @@ pub struct AccumulatorArgs<'a> { /// /// If no `ORDER BY` is specified, `sort_exprs`` will

Re: [PR] UDAF: Extend more args to `state_fields` and `groups_accumulator_supported` and introduce `ReversedUDAF` [datafusion]

2024-05-15 Thread via GitHub
alamb commented on code in PR #10525: URL: https://github.com/apache/datafusion/pull/10525#discussion_r1602179481 ## datafusion/expr/src/function.rs: ## @@ -66,22 +69,39 @@ pub struct AccumulatorArgs<'a> { /// /// If no `ORDER BY` is specified, `sort_exprs`` will be em

[PR] UDAF: Extend more args to `state_fields` and `groups_accumulator_supported` and introduce `ReversedUDAF` [datafusion]

2024-05-15 Thread via GitHub
jayzhan211 opened a new pull request, #10525: URL: https://github.com/apache/datafusion/pull/10525 ## Which issue does this PR close? Closes #. ## Rationale for this change This PR is pulled from #10484 and it has a similar rationale in #10391 but the cha