alamb commented on PR #17397:
URL: https://github.com/apache/datafusion/pull/17397#issuecomment-3258353587
Also, I think the File opener trait is somewhat specialized / not used all
that widely, so this change will likely not affect that many people
--
This is an automated message from th
adriangb merged PR #17397:
URL: https://github.com/apache/datafusion/pull/17397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
adriangb commented on PR #17397:
URL: https://github.com/apache/datafusion/pull/17397#issuecomment-3254972431
I also spoke with @alamb about this change, he agreed it's a positive change
and that the breakage should be minimal because (1) not many people are
implementing `FileOpenFuture` an
comphead commented on code in PR #17397:
URL: https://github.com/apache/datafusion/pull/17397#discussion_r2322969878
##
datafusion/core/tests/physical_optimizer/filter_pushdown/util.rs:
##
@@ -344,7 +338,7 @@ impl TestStream {
}
impl Stream for TestStream {
-type Item =
comphead commented on code in PR #17397:
URL: https://github.com/apache/datafusion/pull/17397#discussion_r2322968565
##
datafusion/datasource/src/file_stream.rs:
##
@@ -345,7 +343,7 @@ impl RecordBatchStream for FileStream {
/// A fallible future that resolves to a stream of
adriangb commented on PR #17397:
URL: https://github.com/apache/datafusion/pull/17397#issuecomment-3254817035
Thanks @comphead ! Addressed your feedback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
comphead commented on code in PR #17397:
URL: https://github.com/apache/datafusion/pull/17397#discussion_r2322786750
##
datafusion/core/src/datasource/physical_plan/arrow_file.rs:
##
@@ -179,7 +183,7 @@ impl FileOpener for ArrowOpener {
footer_buf[..foot
comphead commented on code in PR #17397:
URL: https://github.com/apache/datafusion/pull/17397#discussion_r2322788849
##
datafusion/datasource/src/file_stream.rs:
##
@@ -566,7 +563,7 @@ mod tests {
if self.error_opening_idx.contains(&idx) {
Ok(future
adriangb opened a new pull request, #17397:
URL: https://github.com/apache/datafusion/pull/17397
I would like to re-use `ProjectionStream` for
https://github.com/apache/datafusion/issues/14993:
https://github.com/apache/datafusion/blob/0a9dcec265309d1d948e46e7d6878a267b950f1d/datafus
