comphead commented on code in PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#discussion_r1847143142
##
datafusion/functions/src/datetime/to_date.rs:
##
@@ -162,7 +151,7 @@ impl ScalarUDFImpl for ToDateFunc {
}
fn documentation(&self) -> Option<&Docum
comphead commented on code in PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#discussion_r1844213622
##
Cargo.toml:
##
@@ -48,6 +48,8 @@ members = [
"datafusion-examples",
"test-utils",
"benchmarks",
+"datafusion/macros",
+"datafusion/pre-m
alamb commented on code in PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#discussion_r1844138228
##
Cargo.toml:
##
@@ -48,6 +48,8 @@ members = [
"datafusion-examples",
"test-utils",
"benchmarks",
+"datafusion/macros",
+"datafusion/pre-macr
comphead commented on code in PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#discussion_r1844073792
##
Cargo.toml:
##
@@ -48,6 +48,8 @@ members = [
"datafusion-examples",
"test-utils",
"benchmarks",
+"datafusion/macros",
+"datafusion/pre-m
alamb commented on code in PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#discussion_r1843953666
##
Cargo.toml:
##
@@ -48,6 +48,8 @@ members = [
"datafusion-examples",
"test-utils",
"benchmarks",
+"datafusion/macros",
+"datafusion/pre-macr
comphead commented on code in PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#discussion_r1843053612
##
Cargo.toml:
##
@@ -48,6 +48,8 @@ members = [
"datafusion-examples",
"test-utils",
"benchmarks",
+"datafusion/macros",
+"datafusion/pre-m
comphead commented on PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#issuecomment-2469410388
We should also take care on handing things like
https://github.com/apache/datafusion/pull/13367
--
This is an automated message from the Apache Git Service.
To respond to the mess
comphead commented on PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#issuecomment-2469408870
I'm closer to this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
comphead commented on PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#issuecomment-2423105120
I'll get back on it little later as need to finish some more urgent work
with joins
--
This is an automated message from the Apache Git Service.
To respond to the message, please
comphead commented on code in PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#discussion_r1797461538
##
datafusion/functions/src/datetime/to_date.rs:
##
@@ -26,9 +26,42 @@ use
datafusion_expr::scalar_doc_sections::DOC_SECTION_DATETIME;
use datafusion_expr::{
comphead commented on PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#issuecomment-2408027996
Thanks @Omega359 there is bunch of things needed to be added, its not a
final PR. I'll add some minor missing pieces and the PR will be ready for the
review, most likely next week.
Omega359 commented on code in PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#discussion_r1797270367
##
datafusion/functions/src/datetime/to_date.rs:
##
@@ -26,9 +26,42 @@ use
datafusion_expr::scalar_doc_sections::DOC_SECTION_DATETIME;
use datafusion_expr::{
Omega359 commented on code in PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#discussion_r1797256333
##
datafusion/macros/src/lib.rs:
##
@@ -0,0 +1,125 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
Omega359 commented on code in PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#discussion_r1797255095
##
datafusion/functions/src/datetime/to_date.rs:
##
@@ -26,9 +26,42 @@ use
datafusion_expr::scalar_doc_sections::DOC_SECTION_DATETIME;
use datafusion_expr::{
Omega359 commented on code in PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#discussion_r1797253482
##
datafusion/functions/src/datetime/to_date.rs:
##
@@ -26,9 +26,42 @@ use
datafusion_expr::scalar_doc_sections::DOC_SECTION_DATETIME;
use datafusion_expr::{
Omega359 commented on PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#issuecomment-2407852313
> @Omega359 is it good to have a `documentation` method on struct level
instead of impl?
I can't think of a reason why not off the top of my head. I'm hoping to have
time to
comphead commented on PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#issuecomment-2407800805
Thanks @alamb I'll consider the changes, @Omega359 is it good to have a
documentation method on struct level instead of impl?
--
This is an automated message from the Apache Git S
alamb commented on code in PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#discussion_r1797049163
##
datafusion/functions/src/datetime/to_date.rs:
##
@@ -26,9 +26,42 @@ use
datafusion_expr::scalar_doc_sections::DOC_SECTION_DATETIME;
use datafusion_expr::{
comphead commented on code in PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#discussion_r1795932350
##
datafusion/pre-macros/src/lib.rs:
##
@@ -0,0 +1,179 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreement
comphead commented on PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#issuecomment-2405804413
@alamb @Omega359 please have a look on real example `to_date` (I still need
to include argements to be called with the builder). As you can see it is the
same approach as before, th
comphead commented on PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#issuecomment-2402564649
> I find this intriguing and technically very interesting! I do have a few
questions:
>
> * What are you goals with this? I am assuming cleaner looking/easier to
create docs.
Omega359 commented on PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#issuecomment-2402261823
I find this intriguing and technically very interesting! I do have a few
questions:
- What are you goals with this? I am assuming cleaner looking/easier to
create docs. If so
alamb commented on code in PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#discussion_r1793362288
##
datafusion/functions/src/math/log.rs:
##
@@ -37,6 +38,7 @@ use datafusion_expr::{
};
use datafusion_expr::{ScalarUDFImpl, Signature, Volatility};
+#[udf_doc(d
comphead commented on PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#issuecomment-2400893643
WDYT should we move in this direction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
comphead commented on code in PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#discussion_r1792510641
##
datafusion/functions/src/math/log.rs:
##
@@ -37,6 +38,7 @@ use datafusion_expr::{
};
use datafusion_expr::{ScalarUDFImpl, Signature, Volatility};
+#[udf_do
comphead commented on PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#issuecomment-2400818202
@Omega359 @alamb I tried to play with custom attributes to wrap up the
documentation on top of the what @Omega359 already built. I'm experimenting
with just 2 fields(description and
comphead opened a new pull request, #12822:
URL: https://github.com/apache/datafusion/pull/12822
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
## Are these changes tested?
comphead commented on code in PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#discussion_r1792510829
##
datafusion/functions/src/math/log.rs:
##
@@ -472,4 +471,16 @@ mod tests {
SortProperties::Unordered
);
}
+
+#[test]
+fn test
comphead commented on code in PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#discussion_r1792507680
##
Cargo.toml:
##
@@ -48,6 +48,8 @@ members = [
"datafusion-examples",
"test-utils",
"benchmarks",
+"datafusion/macros",
+"datafusion/pre-m
29 matches
Mail list logo
