Re: [PR] WIP: parse true and false as identifiers in mssql [datafusion-sqlparser-rs]

2024-11-10 Thread via GitHub
lovasoa commented on PR #1510: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1510#issuecomment-2466693830 Ok, I fixed all the tests, this is ready for review @iffyio, @alamb :) -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] WIP: parse true and false as identifiers in mssql [datafusion-sqlparser-rs]

2024-11-10 Thread via GitHub
lovasoa commented on PR #1510: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1510#issuecomment-2466632368 There are 7 failing tests at the moment. From a quick glance, it looks like it's the tests that are incorrect: they rely on the existence of boolean literals in all diale

[PR] WIP: parse true and false as identifiers in mssql [datafusion-sqlparser-rs]

2024-11-10 Thread via GitHub
lovasoa opened a new pull request, #1510: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1510 fixes https://github.com/apache/datafusion-sqlparser-rs/issues/1508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and