huaxingao commented on PR #360:
URL: https://github.com/apache/datafusion-comet/pull/360#issuecomment-2960779443
I don't think this is needed any more, so closing it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
huaxingao closed pull request #360: chore: add a utils method to
getColumnReader with SQLConf
URL: https://github.com/apache/datafusion-comet/pull/360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove commented on PR #360:
URL: https://github.com/apache/datafusion-comet/pull/360#issuecomment-2960623336
@huaxingao Is this PR still needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
advancedxy commented on code in PR #360:
URL: https://github.com/apache/datafusion-comet/pull/360#discussion_r1590680585
##
common/src/main/java/org/apache/comet/parquet/Utils.java:
##
@@ -22,18 +22,20 @@
import org.apache.parquet.column.ColumnDescriptor;
import org.apache.par
viirya commented on PR #360:
URL: https://github.com/apache/datafusion-comet/pull/360#issuecomment-203549
Hmm, I think @parthchandra meant that by adding SQLConf, `common` will
depend on Spark. Does it conflict with the direction to make `common` not Spark
dependent?
--
This is an au
huaxingao commented on PR #360:
URL: https://github.com/apache/datafusion-comet/pull/360#issuecomment-2088821957
> This will make it harder to make the column reader Spark agnostic as
you're adding one more point of dependency.
We need a way for users to config `useLazyMaterialization
parthchandra commented on code in PR #360:
URL: https://github.com/apache/datafusion-comet/pull/360#discussion_r1586534478
##
common/src/main/java/org/apache/comet/parquet/Utils.java:
##
@@ -22,18 +22,20 @@
import org.apache.parquet.column.ColumnDescriptor;
import org.apache.p
huaxingao commented on code in PR #360:
URL: https://github.com/apache/datafusion-comet/pull/360#discussion_r1586512837
##
common/src/main/java/org/apache/comet/parquet/Utils.java:
##
@@ -22,18 +22,20 @@
import org.apache.parquet.column.ColumnDescriptor;
import org.apache.parq
viirya commented on code in PR #360:
URL: https://github.com/apache/datafusion-comet/pull/360#discussion_r1586509104
##
common/src/main/java/org/apache/comet/parquet/Utils.java:
##
@@ -22,18 +22,20 @@
import org.apache.parquet.column.ColumnDescriptor;
import org.apache.parquet
kazuyukitanimura commented on code in PR #360:
URL: https://github.com/apache/datafusion-comet/pull/360#discussion_r1586503411
##
common/src/main/java/org/apache/comet/parquet/Utils.java:
##
@@ -22,18 +22,20 @@
import org.apache.parquet.column.ColumnDescriptor;
import org.apac
huaxingao commented on code in PR #360:
URL: https://github.com/apache/datafusion-comet/pull/360#discussion_r1586419627
##
common/src/main/java/org/apache/comet/parquet/Utils.java:
##
@@ -22,18 +22,19 @@
import org.apache.parquet.column.ColumnDescriptor;
import org.apache.parq
kazuyukitanimura commented on code in PR #360:
URL: https://github.com/apache/datafusion-comet/pull/360#discussion_r1586015665
##
common/src/main/java/org/apache/comet/parquet/Utils.java:
##
@@ -22,18 +22,19 @@
import org.apache.parquet.column.ColumnDescriptor;
import org.apac
huaxingao opened a new pull request, #360:
URL: https://github.com/apache/datafusion-comet/pull/360
## Which issue does this PR close?
Closes #.
## Rationale for this change
Add a Utils method `getColumnReader` which can passed in `SQLConf`, so
Iceberg can pa
13 matches
Mail list logo
