Re: [PR] fix: `ColumnReader.loadVector` should initiate `CometDictionary` after re-import arrays [datafusion-comet]

2024-05-28 Thread via GitHub
viirya commented on PR #473: URL: https://github.com/apache/datafusion-comet/pull/473#issuecomment-2135939279 I got the reason why it has regression. I will propose a fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] fix: `ColumnReader.loadVector` should initiate `CometDictionary` after re-import arrays [datafusion-comet]

2024-05-27 Thread via GitHub
andygrove commented on PR #473: URL: https://github.com/apache/datafusion-comet/pull/473#issuecomment-2133964232 @viirya Just fyi, this commit caused a large regression for me in local runs of TPC-H. I will share full details tomorrow. ## before ![Screenshot from 2024-05-27 1

Re: [PR] fix: `ColumnReader.loadVector` should initiate `CometDictionary` after re-import arrays [datafusion-comet]

2024-05-25 Thread via GitHub
viirya commented on PR #473: URL: https://github.com/apache/datafusion-comet/pull/473#issuecomment-2131456605 Merged. Thanks @andygrove @sunchao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] fix: `ColumnReader.loadVector` should initiate `CometDictionary` after re-import arrays [datafusion-comet]

2024-05-25 Thread via GitHub
viirya merged PR #473: URL: https://github.com/apache/datafusion-comet/pull/473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@dataf

Re: [PR] fix: `ColumnReader.loadVector` should initiate `CometDictionary` after re-import arrays [datafusion-comet]

2024-05-25 Thread via GitHub
codecov-commenter commented on PR #473: URL: https://github.com/apache/datafusion-comet/pull/473#issuecomment-2131417599 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/473?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campai

Re: [PR] fix: `ColumnReader.loadVector` should initiate `CometDictionary` after re-import arrays [datafusion-comet]

2024-05-25 Thread via GitHub
viirya commented on code in PR #473: URL: https://github.com/apache/datafusion-comet/pull/473#discussion_r1614819511 ## common/src/main/java/org/apache/comet/parquet/ColumnReader.java: ## @@ -230,15 +230,15 @@ public CometDecodedVector loadVector() { // return plain vec

Re: [PR] fix: `ColumnReader.loadVector` should initiate `CometDictionary` after re-import arrays [datafusion-comet]

2024-05-25 Thread via GitHub
viirya commented on PR #473: URL: https://github.com/apache/datafusion-comet/pull/473#issuecomment-2131403965 cc @sunchao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[PR] fix: `ColumnReader.loadVector` should initiate `CometDictionary` after re-import arrays [datafusion-comet]

2024-05-25 Thread via GitHub
viirya opened a new pull request, #473: URL: https://github.com/apache/datafusion-comet/pull/473 ## Which issue does this PR close? Closes #. ## Rationale for this change ## What changes are included in this PR? ## How are these changes test