andygrove commented on PR #2155:
URL:
https://github.com/apache/datafusion-comet/pull/2155#issuecomment-3189824597
Thanks for the review @comphead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
andygrove merged PR #2155:
URL: https://github.com/apache/datafusion-comet/pull/2155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
andygrove commented on PR #2155:
URL:
https://github.com/apache/datafusion-comet/pull/2155#issuecomment-3189494802
> oh so do we use SMJ by default?
>
> ```
> val COMET_REPLACE_SMJ: ConfigEntry[Boolean] =
> conf(s"$COMET_EXEC_CONFIG_PREFIX.replaceSortMergeJoin")
>
codecov-commenter commented on PR #2155:
URL:
https://github.com/apache/datafusion-comet/pull/2155#issuecomment-3189319131
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/2155?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
andygrove commented on code in PR #2155:
URL: https://github.com/apache/datafusion-comet/pull/2155#discussion_r2277229709
##
native/core/src/execution/planner.rs:
##
@@ -2611,8 +2614,10 @@ impl From for DataFusionError {
/// data corruption from reusing the input batch.
fn can
andygrove opened a new pull request, #2155:
URL: https://github.com/apache/datafusion-comet/pull/2155
## Which issue does this PR close?
Closes https://github.com/apache/datafusion-comet/issues/2151
## Rationale for this change
## What changes are included
