github-actions[bot] closed pull request #16332: Add support for glob string in
datafusion-cli query
URL: https://github.com/apache/datafusion/pull/16332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
github-actions[bot] commented on PR #16332:
URL: https://github.com/apache/datafusion/pull/16332#issuecomment-3186505480
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
alamb commented on PR #16332:
URL: https://github.com/apache/datafusion/pull/16332#issuecomment-2970544930
> rather than a function for each file type (read_parquet, read_csv, etc).
You are correct that the latter is more common so will for this.
I think the reason that DuckDB et al u
a-agmon commented on PR #16332:
URL: https://github.com/apache/datafusion/pull/16332#issuecomment-2961294401
@alamb - thank you very much for the generous comments. I appreciate it.
Re naming - I completely agree. Was just wondering whether its better to
introduce one function that infe
alamb commented on code in PR #16332:
URL: https://github.com/apache/datafusion/pull/16332#discussion_r2139195148
##
datafusion-cli/src/functions.rs:
##
@@ -460,3 +473,92 @@ impl TableFunctionImpl for ParquetMetadataFunc {
Ok(Arc::new(parquet_metadata))
}
}
+
+///
a-agmon commented on code in PR #16332:
URL: https://github.com/apache/datafusion/pull/16332#discussion_r2134804642
##
datafusion-cli/tests/sql/integration/glob_test.sql:
##
@@ -0,0 +1,15 @@
+-- Test glob function with files available in CI
+-- Test 1: Single CSV file - verify b
a-agmon commented on code in PR #16332:
URL: https://github.com/apache/datafusion/pull/16332#discussion_r2134812154
##
datafusion-cli/tests/sql/integration/glob_test.sql:
##
@@ -0,0 +1,15 @@
+-- Test glob function with files available in CI
+-- Test 1: Single CSV file - verify b
a-agmon commented on code in PR #16332:
URL: https://github.com/apache/datafusion/pull/16332#discussion_r2134812154
##
datafusion-cli/tests/sql/integration/glob_test.sql:
##
@@ -0,0 +1,15 @@
+-- Test glob function with files available in CI
+-- Test 1: Single CSV file - verify b
a-agmon commented on code in PR #16332:
URL: https://github.com/apache/datafusion/pull/16332#discussion_r2134804642
##
datafusion-cli/tests/sql/integration/glob_test.sql:
##
@@ -0,0 +1,15 @@
+-- Test glob function with files available in CI
+-- Test 1: Single CSV file - verify b
comphead commented on code in PR #16332:
URL: https://github.com/apache/datafusion/pull/16332#discussion_r2134795185
##
datafusion-cli/tests/sql/integration/glob_test.sql:
##
@@ -0,0 +1,15 @@
+-- Test glob function with files available in CI
+-- Test 1: Single CSV file - verify
comphead commented on code in PR #16332:
URL: https://github.com/apache/datafusion/pull/16332#discussion_r2134794430
##
datafusion-cli/src/functions.rs:
##
@@ -460,3 +473,94 @@ impl TableFunctionImpl for ParquetMetadataFunc {
Ok(Arc::new(parquet_metadata))
}
}
+
+
comphead commented on code in PR #16332:
URL: https://github.com/apache/datafusion/pull/16332#discussion_r2134794387
##
datafusion-cli/src/functions.rs:
##
@@ -460,3 +473,94 @@ impl TableFunctionImpl for ParquetMetadataFunc {
Ok(Arc::new(parquet_metadata))
}
}
+
+
12 matches
Mail list logo
