Omega359 commented on issue #14317:
URL: https://github.com/apache/datafusion/issues/14317#issuecomment-2619180799
I personally haven't had the need to go into a LogicalPlan from a dataframe
and back again but I could see it being useful.
--
This is an automated message from the A
berkaysynnada closed issue #14226: Variant on `AnalysisContext` to represent
empty-set
URL: https://github.com/apache/datafusion/issues/14226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
jatin510 commented on PR #1205:
URL:
https://github.com/apache/datafusion-comet/pull/1205#issuecomment-2619369218
> @jatin510 builds are failing:
>
> ```
> error[E0308]: mismatched types
>--> core/src/execution/planner.rs:787:48
> |
> 787 | matc
andygrove commented on PR #1325:
URL:
https://github.com/apache/datafusion-comet/pull/1325#issuecomment-2619399645
@parthchandra @wForget fyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
xudong963 commented on code in PR #14338:
URL: https://github.com/apache/datafusion/pull/14338#discussion_r1932426376
##
datafusion/sqllogictest/test_files/joins.slt:
##
@@ -4274,16 +4270,155 @@ EXPLAIN SELECT * FROM t0 FULL JOIN t1 ON t0.c1 = t1.c1
AND t0.c2 >= t1.c2 LIMIT
lo
xudong963 commented on code in PR #14245:
URL: https://github.com/apache/datafusion/pull/14245#discussion_r1932431727
##
datafusion/core/tests/dataframe/mod.rs:
##
@@ -5182,3 +5177,32 @@ async fn register_non_parquet_file() {
"1.json' does not match the expected extensi
Chen-Yuan-Lai opened a new pull request, #14341:
URL: https://github.com/apache/datafusion/pull/14341
## Which issue does this PR close?
Closes #14115 .
## Rationale for this change
As mentioned in #14115 , several examples in DataFusion codebase still
using
kazantsev-maksim commented on code in PR #1343:
URL: https://github.com/apache/datafusion-comet/pull/1343#discussion_r1932434647
##
native/core/src/execution/planner.rs:
##
@@ -818,6 +819,22 @@ impl PhysicalPlanner {
));
Ok(array_join_expr)
xudong963 commented on code in PR #14245:
URL: https://github.com/apache/datafusion/pull/14245#discussion_r1932436336
##
datafusion/physical-optimizer/src/limit_pushdown.rs:
##
@@ -247,7 +246,15 @@ pub fn pushdown_limit_helper(
}
} else {
// Ad
iffyio merged PR #1677:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
iffyio opened a new pull request, #1685:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1685
Minor follow up from #1677
Support was added for both Clickhouse and Postgres but the test only covered
Clickhouse. This move the test to common and to use the `all_dialects_where`
f
zhuqi-lucas commented on code in PR #14245:
URL: https://github.com/apache/datafusion/pull/14245#discussion_r1932211238
##
datafusion/physical-optimizer/src/limit_pushdown.rs:
##
@@ -247,7 +246,14 @@ pub fn pushdown_limit_helper(
}
} else {
//
andygrove commented on issue #1344:
URL:
https://github.com/apache/datafusion-comet/issues/1344#issuecomment-2619316628
Thanks for raising this, @EmilyFlarionIO. The build times can be
frustrating. If we were to start by adopting step 1, I assume we would not need
to change any of the Mave
andygrove commented on issue #1233:
URL:
https://github.com/apache/datafusion-comet/issues/1233#issuecomment-2619321231
This was completed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
andygrove closed issue #1333: Investigate implications of arrow-rs dropping
support for tracking dictionary ids in schema
URL: https://github.com/apache/datafusion-comet/issues/1333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
andygrove commented on issue #1333:
URL:
https://github.com/apache/datafusion-comet/issues/1333#issuecomment-2619318857
Closing this since there seems to be no impact
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
andygrove closed issue #1233: Release Comet 0.5.0 (Jan 2025)
URL: https://github.com/apache/datafusion-comet/issues/1233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
andygrove commented on PR #1325:
URL:
https://github.com/apache/datafusion-comet/pull/1325#issuecomment-2619596347
> Does this implicitly affect any data read that originated as `uint64`? I
believe it gets converted to `DECIMAL(20,0)`.
Yes, in the context of a user calling the `hash`
iffyio commented on code in PR #1679:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1679#discussion_r1932557587
##
src/ast/value.rs:
##
@@ -97,6 +97,32 @@ pub enum Value {
Placeholder(String),
}
+impl Into for Value {
+fn into(self) -> String {
+
comphead merged PR #14288:
URL: https://github.com/apache/datafusion/pull/14288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
graup commented on code in PR #1679:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1679#discussion_r1932661673
##
tests/sqlparser_bigquery.rs:
##
@@ -2214,6 +2214,30 @@ fn test_select_as_value() {
assert_eq!(Some(ValueTableMode::AsValue), select.value_table_m
graup commented on code in PR #1679:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1679#discussion_r1932661673
##
tests/sqlparser_bigquery.rs:
##
@@ -2214,6 +2214,30 @@ fn test_select_as_value() {
assert_eq!(Some(ValueTableMode::AsValue), select.value_table_m
kylebarron commented on code in PR #1000:
URL:
https://github.com/apache/datafusion-python/pull/1000#discussion_r1932699499
##
src/config.rs:
##
@@ -40,7 +42,7 @@ impl PyConfig {
#[staticmethod]
pub fn from_env() -> PyResult {
Review Comment:
Instead of always cal
andygrove commented on PR #1332:
URL:
https://github.com/apache/datafusion-comet/pull/1332#issuecomment-2619823980
> I think the PR is good in general but what concerns me is really lots of
code added just to do the migration. I'm wondering was there breaking changes
in DF or Arrow, as loo
graup commented on code in PR #1679:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1679#discussion_r1932661673
##
tests/sqlparser_bigquery.rs:
##
@@ -2214,6 +2214,30 @@ fn test_select_as_value() {
assert_eq!(Some(ValueTableMode::AsValue), select.value_table_m
korowa commented on code in PR #13681:
URL: https://github.com/apache/datafusion/pull/13681#discussion_r1932677883
##
datafusion/functions-aggregate/src/median.rs:
##
@@ -230,6 +276,212 @@ impl Accumulator for
MedianAccumulator {
}
}
+/// The median groups accumulator a
korowa commented on code in PR #13681:
URL: https://github.com/apache/datafusion/pull/13681#discussion_r1932677883
##
datafusion/functions-aggregate/src/median.rs:
##
@@ -230,6 +276,212 @@ impl Accumulator for
MedianAccumulator {
}
}
+/// The median groups accumulator a
graup commented on code in PR #1679:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1679#discussion_r1932685294
##
src/ast/value.rs:
##
@@ -97,6 +97,32 @@ pub enum Value {
Placeholder(String),
}
+impl Into for Value {
+fn into(self) -> String {
+
graup commented on code in PR #1679:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1679#discussion_r1932686299
##
tests/sqlparser_bigquery.rs:
##
@@ -39,7 +39,7 @@ fn parse_literal_string() {
r#"'''triple-single'unescaped''', "#,
r#""double\"esca
askalt opened a new issue, #14342:
URL: https://github.com/apache/datafusion/issues/14342
## Problem ##
While implementing the saving of prepared statements in our storage based on
the DataFusion, we encountered the following issue:
It is inefficient to save the logical plan and r
JanKaul commented on PR #14286:
URL: https://github.com/apache/datafusion/pull/14286#issuecomment-2619873876
For your information, I was able to reproduce the IO stall error with a very
[simple
example](https://github.com/JanKaul/cpu-io-executor/blob/main/src/single_runtime.rs).
In case an
askalt commented on issue #14342:
URL: https://github.com/apache/datafusion/issues/14342#issuecomment-2619881519
About physical placeholders challenges. For example, postgresql uses the
following heuristic to choose "use generic plan" or "rebuild plan with inlined
parameters when they becom
gatesn commented on PR #14074:
URL: https://github.com/apache/datafusion/pull/14074#issuecomment-2619891822
Any other blockers @alamb ? Thanks for hustling this through
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
ozankabak commented on PR #14074:
URL: https://github.com/apache/datafusion/pull/14074#issuecomment-2619923329
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
iffyio commented on code in PR #1678:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1678#discussion_r1931794118
##
src/dialect/mod.rs:
##
@@ -821,11 +821,24 @@ pub trait Dialect: Debug + Any {
false
}
+/// Returns reserved keywords when looking
eliaperantoni commented on code in PR #13664:
URL: https://github.com/apache/datafusion/pull/13664#discussion_r1931798459
##
datafusion/expr-common/src/type_coercion/binary.rs:
##
@@ -68,11 +70,57 @@ impl Signature {
}
}
-/// Returns a [`Signature`] for applying `op` to
eliaperantoni commented on code in PR #13664:
URL: https://github.com/apache/datafusion/pull/13664#discussion_r1931797862
##
datafusion/expr-common/src/type_coercion/binary.rs:
##
@@ -68,11 +70,57 @@ impl Signature {
}
}
-/// Returns a [`Signature`] for applying `op` to
iffyio merged PR #1680:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
Omega359 commented on PR #14331:
URL: https://github.com/apache/datafusion/pull/14331#issuecomment-2618612893
I took a look at the updates, I think they should work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
alamb commented on code in PR #13681:
URL: https://github.com/apache/datafusion/pull/13681#discussion_r1931936141
##
datafusion/functions-aggregate/src/median.rs:
##
@@ -230,6 +276,201 @@ impl Accumulator for
MedianAccumulator {
}
}
+/// The median groups accumulator ac
cht42 commented on code in PR #1341:
URL: https://github.com/apache/datafusion-comet/pull/1341#discussion_r1931944408
##
native/spark-expr/src/math_funcs/round.rs:
##
@@ -85,9 +85,10 @@ pub fn spark_round(
let (precision, scale) = get_precision_scale(data_type);
ion-elgreco commented on issue #14154:
URL: https://github.com/apache/datafusion/issues/14154#issuecomment-2618645919
@alamb yes this indeed worked fine on DF43. I tested it against deltalake
v0.23.3
--
This is an automated message from the Apache Git Service.
To respond to the message, p
cht42 commented on code in PR #1341:
URL: https://github.com/apache/datafusion-comet/pull/1341#discussion_r1931942453
##
native/spark-expr/src/math_funcs/round.rs:
##
@@ -85,9 +85,10 @@ pub fn spark_round(
let (precision, scale) = get_precision_scale(data_type);
iffyio merged PR #1675:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
eliaperantoni commented on code in PR #13664:
URL: https://github.com/apache/datafusion/pull/13664#discussion_r1931890521
##
datafusion/common/src/column.rs:
##
@@ -18,10 +18,11 @@
//! Column
use arrow_schema::{Field, FieldRef};
+use sqlparser::tokenizer::Span;
Review Comme
berkaysynnada commented on code in PR #14271:
URL: https://github.com/apache/datafusion/pull/14271#discussion_r1932018364
##
datafusion/expr/src/udaf.rs:
##
@@ -39,6 +39,26 @@ use crate::utils::AggregateOrderSensitivity;
use crate::{Accumulator, Expr};
use crate::{Documentatio
berkaysynnada commented on code in PR #14271:
URL: https://github.com/apache/datafusion/pull/14271#discussion_r1932023820
##
datafusion/expr/src/udaf.rs:
##
@@ -635,6 +655,14 @@ pub trait AggregateUDFImpl: Debug + Send + Sync {
fn documentation(&self) -> Option<&Documentati
matko commented on code in PR #1000:
URL:
https://github.com/apache/datafusion-python/pull/1000#discussion_r1932009641
##
src/pyarrow_util.rs:
##
Review Comment:
it would be good to have the conversion functions in this file also
available directly on a `ScalarValue`, whi
berkaysynnada commented on code in PR #14271:
URL: https://github.com/apache/datafusion/pull/14271#discussion_r1932037809
##
datafusion/expr/src/udaf.rs:
##
@@ -635,6 +655,14 @@ pub trait AggregateUDFImpl: Debug + Send + Sync {
fn documentation(&self) -> Option<&Documentati
berkaysynnada commented on code in PR #14271:
URL: https://github.com/apache/datafusion/pull/14271#discussion_r1932023820
##
datafusion/expr/src/udaf.rs:
##
@@ -635,6 +655,14 @@ pub trait AggregateUDFImpl: Debug + Send + Sync {
fn documentation(&self) -> Option<&Documentati
DanCodedThis commented on issue #6876:
URL: https://github.com/apache/datafusion/issues/6876#issuecomment-2618807796
Hello, I have implemented `date_add` (also `date_diff`) akin to Snowflake
spec. My company would like me to contribute to Datafusion (if it's needed). Do
I need to open a dif
alamb commented on PR #14207:
URL: https://github.com/apache/datafusion/pull/14207#issuecomment-2620061423
I plan to review this PR later today or tomorrow as it is on my "45
blockers" list
Thank you for your patience @xudong963
--
This is an automated message from the Apache Git
buraksenn commented on PR #14331:
URL: https://github.com/apache/datafusion/pull/14331#issuecomment-2620086827
> Thanks @buraksenn
>
> When testing such PRs I normally put them on the `main` branch in my own
fork and then try it out there
Thanks @alamb. As you've said I've star
rluvaton commented on code in PR #14299:
URL: https://github.com/apache/datafusion/pull/14299#discussion_r1932880307
##
datafusion/functions-aggregate/src/array_agg.rs:
##
@@ -177,6 +177,67 @@ impl ArrayAggAccumulator {
datatype: datatype.clone(),
})
}
rluvaton commented on PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#issuecomment-2620107324
FYI Spark regex is not the same as Rust regex and can have different results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
alamb commented on code in PR #14268:
URL: https://github.com/apache/datafusion/pull/14268#discussion_r1932866009
##
datafusion/functions/src/string/bit_length.rs:
##
@@ -55,7 +58,10 @@ impl Default for BitLengthFunc {
impl BitLengthFunc {
pub fn new() -> Self {
S
rluvaton commented on PR #14289:
URL: https://github.com/apache/datafusion/pull/14289#issuecomment-2620098993
I don't like the name strict as it can mean different things (like fail on
parsing invalid strings), I think it should be an enum on null handling
--
This is an automated message
rluvaton commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1932904240
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
rluvaton commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1932901931
##
docs/source/user-guide/sql/scalar_functions.md:
##
@@ -1919,6 +1920,31 @@ SELECT regexp_replace('aBc', '(b|d)', 'Ab\\1a', 'i');
Additional examples can be f
Omega359 commented on PR #14345:
URL: https://github.com/apache/datafusion/pull/14345#issuecomment-2620125142
I actually saw this in the extended tests ... I am watching those :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
jkosh44 commented on PR #14289:
URL: https://github.com/apache/datafusion/pull/14289#issuecomment-2620139202
> I don't like the name strict as it can mean different things (like fail on
parsing invalid strings), I think it should be an enum on null handling
How about something like
rluvaton commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1932896635
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
eliaperantoni commented on code in PR #13664:
URL: https://github.com/apache/datafusion/pull/13664#discussion_r1932058436
##
datafusion/common/src/diagnostic.rs:
##
@@ -0,0 +1,112 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license a
alamb commented on issue #14335:
URL: https://github.com/apache/datafusion/issues/14335#issuecomment-2618837699
I wrote some tests for this here:
- https://github.com/apache/datafusion/pull/14336
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
alamb commented on issue #14335:
URL: https://github.com/apache/datafusion/issues/14335#issuecomment-2618831985
I think @zhuqi-lucas found the issue. This line is almost certainly wrong:
https://github.com/apache/datafusion/blob/e3db3592a846cb4d5ce175b624c1aecc70441981/datafusion/op
alamb commented on issue #14326:
URL: https://github.com/apache/datafusion/issues/14326#issuecomment-2618849932
Thanks @askalt -- we'll check it out
FYI @ozankabak and @berkaysynnada
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
alamb opened a new issue, #14337:
URL: https://github.com/apache/datafusion/issues/14337
### Is your feature request related to a problem or challenge?
We rely on
[`MemoryExec`](https://github.com/alamb/datafusion/blob/f77579108d1dc0285636fbfb24507d2bfca66446/datafusion/physical-plan/
alamb commented on issue #14335:
URL: https://github.com/apache/datafusion/issues/14335#issuecomment-2618877800
I also filed this ticket to track making it easier to test for this kind of
thing
- https://github.com/apache/datafusion/issues/14337
--
This is an automated message from the
eliaperantoni commented on code in PR #13664:
URL: https://github.com/apache/datafusion/pull/13664#discussion_r1932086369
##
datafusion/sqllogictest/test_files/create_external_table.slt:
##
@@ -33,23 +33,23 @@ statement error DataFusion error: SQL error:
ParserError\("Missing L
eliaperantoni commented on code in PR #13664:
URL: https://github.com/apache/datafusion/pull/13664#discussion_r1932071772
##
datafusion/common/src/diagnostic.rs:
##
@@ -0,0 +1,112 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license a
eliaperantoni commented on code in PR #13664:
URL: https://github.com/apache/datafusion/pull/13664#discussion_r1932071276
##
datafusion/sqllogictest/test_files/unnest.slt:
##
@@ -899,7 +899,7 @@ logical_plan
07)Unnest: lists[__unnest_placeholder(outer_ref(u.column1))|de
alamb opened a new issue, #14335:
URL: https://github.com/apache/datafusion/issues/14335
### Describe the bug
`LIMIT`s are incorrectly pushed through `FULL OUTER` Joins
### To Reproduce
```sql
COPY (values (1), (2), (3), (4), (5)) TO '/tmp/t1.csv' STORED AS CSV;
--
alamb opened a new pull request, #14336:
URL: https://github.com/apache/datafusion/pull/14336
## Which issue does this PR close?
- Related to https://github.com/apache/datafusion/issues/14335
## Rationale for this change
I wrote these test cases finding the bug, so I want
alamb commented on code in PR #14245:
URL: https://github.com/apache/datafusion/pull/14245#discussion_r1932060065
##
datafusion/sqllogictest/test_files/joins.slt:
##
@@ -4247,8 +4247,10 @@ logical_plan
physical_plan
01)CoalesceBatchesExec: target_batch_size=3, fetch=2
02)--Ha
eliaperantoni commented on code in PR #13664:
URL: https://github.com/apache/datafusion/pull/13664#discussion_r1932058075
##
datafusion/common/src/column.rs:
##
@@ -254,6 +288,19 @@ impl Column {
.collect(),
})
}
+
+pub fn spans(&self) -> &Span
alamb commented on issue #14335:
URL: https://github.com/apache/datafusion/issues/14335#issuecomment-2618842149
I don't think this is a regression (it has been like this for while)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
alamb commented on PR #12963:
URL: https://github.com/apache/datafusion/pull/12963#issuecomment-2618846767
I think this optimization produces incorrect results. See
- https://github.com/apache/datafusion/pull/12963
--
This is an automated message from the Apache Git Service.
To respond
alamb commented on issue #14317:
URL: https://github.com/apache/datafusion/issues/14317#issuecomment-2618856619
This seems like a good idea to me
As I understand it, it would allow things like
```rust
let df = ctx.sql("SELECT * from foo");
let df = df.map(my_awesome_rewri
matko commented on code in PR #964:
URL: https://github.com/apache/datafusion-python/pull/964#discussion_r1932064792
##
python/datafusion/context.py:
##
@@ -534,12 +543,20 @@ def sql(self, query: str, options: SQLOptions | None =
None) -> DataFrame:
Args:
timsaucer commented on issue #14317:
URL: https://github.com/apache/datafusion/issues/14317#issuecomment-2618893233
We have something similar in `datafusion-python`
[here](https://github.com/apache/datafusion-python/blob/main/python/datafusion/dataframe.py#L835).
It lets you do something li
berkaysynnada commented on PR #14327:
URL: https://github.com/apache/datafusion/pull/14327#issuecomment-2618903320
Thank you @askalt. I'll review this in detail.
One initial suggestion: instead of adding a unit test and introducing
additional testing components, I believe the same log
zhuqi-lucas commented on issue #14335:
URL: https://github.com/apache/datafusion/issues/14335#issuecomment-2618913801
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
zhuqi-lucas commented on issue #14335:
URL: https://github.com/apache/datafusion/issues/14335#issuecomment-2618916414
I want to take this task, and for the first step, i think we should disable
full out join push down limit.
For further improvement, we can investigate if we have some
berkaysynnada commented on code in PR #14307:
URL: https://github.com/apache/datafusion/pull/14307#discussion_r1931714859
##
datafusion/functions/src/math/monotonicity.rs:
##
@@ -558,3 +558,405 @@ pub fn get_tanh_doc() -> &'static Documentation {
.build()
})
}
+
+
berkaysynnada closed issue #10595: Expand Test Coverage for ScalarUDF's
URL: https://github.com/apache/datafusion/issues/10595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
eliaperantoni commented on code in PR #13664:
URL: https://github.com/apache/datafusion/pull/13664#discussion_r1931818796
##
datafusion/expr/src/expr.rs:
##
@@ -1663,6 +1667,13 @@ impl Expr {
| Expr::Placeholder(..) => false,
}
}
+
+pub fn spans(&s
dependabot[bot] opened a new pull request, #14334:
URL: https://github.com/apache/datafusion/pull/14334
Updates the requirements on
[rand_distr](https://github.com/rust-random/rand) to permit the latest version.
Changelog
Sourced from https://github.com/rust-random/rand/blob/master
eliaperantoni commented on code in PR #13664:
URL: https://github.com/apache/datafusion/pull/13664#discussion_r1931814763
##
datafusion/expr/src/expr_rewriter/mod.rs:
##
@@ -181,10 +178,14 @@ pub fn create_col_from_scalar_expr(
Some::(subqry_alias.into()),
eliaperantoni commented on code in PR #13664:
URL: https://github.com/apache/datafusion/pull/13664#discussion_r1931822190
##
datafusion/expr-common/src/type_coercion/binary.rs:
##
@@ -68,11 +70,57 @@ impl Signature {
}
}
-/// Returns a [`Signature`] for applying `op` to
eliaperantoni commented on code in PR #13664:
URL: https://github.com/apache/datafusion/pull/13664#discussion_r1931825255
##
datafusion/expr-common/src/type_coercion/binary.rs:
##
@@ -68,11 +70,57 @@ impl Signature {
}
}
-/// Returns a [`Signature`] for applying `op` to
logan-keede commented on code in PR #14332:
URL: https://github.com/apache/datafusion/pull/14332#discussion_r1931760587
##
datafusion/catalog/src/lib.rs:
##
@@ -15,6 +15,16 @@
// specific language governing permissions and limitations
// under the License.
+//! Interfaces an
jayzhan211 commented on issue #14296:
URL: https://github.com/apache/datafusion/issues/14296#issuecomment-2618344472
> > We have type coercion in logical plan now, consider the case where we
want to separate logical types and physical types, should we add another type
coercion layer in phys
logan-keede commented on PR #14332:
URL: https://github.com/apache/datafusion/pull/14332#issuecomment-2618361269
@alamb can this please get a review?
Thanks,
Logan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
logan-keede commented on code in PR #14332:
URL: https://github.com/apache/datafusion/pull/14332#discussion_r1931760587
##
datafusion/catalog/src/lib.rs:
##
@@ -15,6 +15,16 @@
// specific language governing permissions and limitations
// under the License.
+//! Interfaces an
eliaperantoni commented on code in PR #13664:
URL: https://github.com/apache/datafusion/pull/13664#discussion_r1931793970
##
datafusion/common/src/diagnostic.rs:
##
@@ -0,0 +1,112 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license a
eliaperantoni commented on code in PR #13664:
URL: https://github.com/apache/datafusion/pull/13664#discussion_r1931802942
##
datafusion/sql/src/set_expr.rs:
##
@@ -36,8 +40,17 @@ impl SqlToRel<'_, S> {
right,
set_quantifier,
} => {
berkaysynnada merged PR #14307:
URL: https://github.com/apache/datafusion/pull/14307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
dependabot[bot] opened a new pull request, #14333:
URL: https://github.com/apache/datafusion/pull/14333
Updates the requirements on [rand](https://github.com/rust-random/rand) to
permit the latest version.
Changelog
Sourced from https://github.com/rust-random/rand/blob/master/CHANG
Omega359 commented on issue #13351:
URL: https://github.com/apache/datafusion/issues/13351#issuecomment-2618686024
I think throwing an error on invalid format may be useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
eliaperantoni commented on code in PR #13664:
URL: https://github.com/apache/datafusion/pull/13664#discussion_r1931896684
##
datafusion/expr-common/Cargo.toml:
##
@@ -41,3 +41,4 @@ arrow = { workspace = true }
datafusion-common = { workspace = true }
itertools = { workspace =
1 - 100 of 268 matches
Mail list logo
