shehabgamin commented on issue #12635:
URL: https://github.com/apache/datafusion/issues/12635#issuecomment-2655822219
@findepi Thank you for thoroughly exploring this topic and creating such a
detailed design document!
@linhr and I have reviewed it and have some initial thoughts:
2010YOUY01 commented on issue #14633:
URL: https://github.com/apache/datafusion/issues/14633#issuecomment-2655916784
> > So as a workaround we could use any dialect that supports it (e.g.
postgresql), gotcha.
>
> That sounds like it should work. From some googling it looks like the
`
mvzink opened a new pull request, #1726:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1726
And same for RIGHT JOIN.
Although these are generally syntactically equivalent, I believe it is
preferable to preserve the original input when rendering.
--
This is an automate
wiedld commented on PR #14650:
URL: https://github.com/apache/datafusion/pull/14650#issuecomment-2657959828
> Thank you for starting to work on this code @xudong963
>
> BTW I believe @wiedld is also plans to work to make this code better, see
>
>
> Maybe you can work togethe
Chen-Yuan-Lai commented on issue #14432:
URL: https://github.com/apache/datafusion/issues/14432#issuecomment-2658302749
Hi @eliaperantoni sorry for the long delay. I’ve been taking some time to
familiarize myself with this issue. I found that the "wrong number of argument"
error may occur i
xudong963 commented on PR #14650:
URL: https://github.com/apache/datafusion/pull/14650#issuecomment-2658391157
> Also, it looks like the failing CI tests are related to the sort
enforcement. Such as not removing unnecessary sorts in some of the children.
The problem is that the code s
xudong963 commented on PR #14650:
URL: https://github.com/apache/datafusion/pull/14650#issuecomment-2658392362
> I can make sure to add you as a reviewers on those. Please lmk if/how you
want to coordinate.
Sure, please add me.
--
This is an automated message from the Apache Git Se
jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1955414348
##
datafusion/expr-common/src/signature.rs:
##
@@ -365,7 +365,12 @@ impl TypeSignature {
}
}
-/// get all possible types for the given `Type
jayzhan211 commented on PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#issuecomment-2658030158
Enum looks good to me but "adding user defined coercion variant" is not
clear to me since I think the Coercible signature is user-defined builtin, they
can change the type they ne
andygrove commented on issue #1393:
URL:
https://github.com/apache/datafusion-comet/issues/1393#issuecomment-2658030599
I agree that the documentation is in need of improvement. I also found that
the files get generated to `$SPARK_HOME`, so I usually set this env var to
point to the root o
andygrove commented on issue #1393:
URL:
https://github.com/apache/datafusion-comet/issues/1393#issuecomment-2658031676
It is also necessary to use different Java versions for different Spark
versions. I use JDK 11 for Spark 3.x.x and JDK 17 for Spark 4.x.x
--
This is an automated messag
xudong963 opened a new issue, #14659:
URL: https://github.com/apache/datafusion/issues/14659
### Is your feature request related to a problem or challenge?
```sql
> select to_unixtime(arrow_cast('2020-01-01 00:10:20.123'::timestamp,
'Timestamp(Second, Some("America/New_York"))'));
simonvandel opened a new issue, #14660:
URL: https://github.com/apache/datafusion/issues/14660
### Is your feature request related to a problem or challenge?
Google BigQuery is releasing support for a pipe operator in their supported
Sql dialect. See https://cloud.google.com/bigquery/
eliaperantoni commented on issue #14432:
URL: https://github.com/apache/datafusion/issues/14432#issuecomment-2658498131
Hey @Chen-Yuan-Lai, absolutely no problem! Was checking in to see if you
needed any help 😊. I see, that's a bit unfortunate. It seems like the first
message is produced by
github-actions[bot] commented on PR #1260:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1260#issuecomment-2658092811
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or
Weijun-H commented on PR #14411:
URL: https://github.com/apache/datafusion/pull/14411#issuecomment-2658410453
> > > > I wonder why tpch_mem_sf10 is slower for some queries? Might it be
possible the created memtable is not created evenly because of the new round
robin (that might be fixable
xuchen-plus commented on issue #12136:
URL: https://github.com/apache/datafusion/issues/12136#issuecomment-2655841477
> Thanks [@xuchen-plus](https://github.com/xuchen-plus) , unluckily after
change to 32MB for sort_spill_reservation_bytes, it still failed for me, i am
not sure which i am m
wForget commented on issue #1393:
URL:
https://github.com/apache/datafusion-comet/issues/1393#issuecomment-2655858437
You can try adding `-am` like `./mvnw -am -pl spark ...`, or run your
command after `mvn install`.
--
This is an automated message from the Apache Git Service.
To respond
alamb commented on code in PR #14631:
URL: https://github.com/apache/datafusion/pull/14631#discussion_r1954394569
##
datafusion/core/src/datasource/memory.rs:
##
@@ -648,9 +649,14 @@ mod tests {
// Create a table scan logical plan to read from the source table
alamb commented on issue #12136:
URL: https://github.com/apache/datafusion/issues/12136#issuecomment-2656430639
> I have also encountered the same problem with string views.
>
> DataFusion uses `interleave` function to produce merged batches, and
`interleave` tends to produce batches
alamb commented on issue #14408:
URL: https://github.com/apache/datafusion/issues/14408#issuecomment-2656435262
Since we have released DF 45 I think we can claim the testing is complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
alamb commented on issue #14161:
URL: https://github.com/apache/datafusion/issues/14161#issuecomment-2656437386
Now that we have DataSouceExec is this still an issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
alamb closed issue #14408: Test DataFusion 45.0.0 with Sail
URL: https://github.com/apache/datafusion/issues/14408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
Kontinuation commented on issue #12136:
URL: https://github.com/apache/datafusion/issues/12136#issuecomment-2656449956
> I think the fix for
[apache/arrow-rs#6779](https://github.com/apache/arrow-rs/pull/6779) is in
DataFusion 45 -- does this still happen?
I am using the latest main
alamb closed issue #4398: Reduce duplicate Projection when
PARQUET_PUSHDOWN_FILTERS is on.
URL: https://github.com/apache/datafusion/issues/4398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
alamb commented on issue #4398:
URL: https://github.com/apache/datafusion/issues/4398#issuecomment-2656452977
The current plan on main has no extra ProjectonExec:
```
(venv)
andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion/benchmarks/data/tpch_sf1$
datafusion-cli
DataFusi
EmilyMatt commented on PR #1390:
URL:
https://github.com/apache/datafusion-comet/pull/1390#issuecomment-2656455632
@andygrove I've updated "test final min/max/count with result expressions"
in the Aggregate suite to verify this more deeply, and I think many of the
queries in the stability
alamb closed issue #1792: Support lazy `SchemaProvider`s
URL: https://github.com/apache/datafusion/issues/1792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
parthchandra commented on PR #1387:
URL:
https://github.com/apache/datafusion-comet/pull/1387#issuecomment-2656383868
More info -
with `native_iceberg_compat`:
```
from_type: Timestamp(Nanosecond, None) to_type: Timestamp(Microsecond,
Some("America/Los_Angeles"))
array: Primi
ch-sc commented on PR #14523:
URL: https://github.com/apache/datafusion/pull/14523#issuecomment-2656384285
> I try to add support for NotEq. If I find a solution, I can fix it within
this PR itself—if that's okay with you.
Sure, feel free to make any adjustment as you see fit.
--
T
Kontinuation commented on issue #12136:
URL: https://github.com/apache/datafusion/issues/12136#issuecomment-2656400964
I have also encountered the same problem with string views.
DataFusion uses `interleave` function to produce merged batches, and
`interleave` tends to produce batches
Kontinuation opened a new pull request, #14642:
URL: https://github.com/apache/datafusion/pull/14642
## Which issue does this PR close?
- Closes #14641.
## Rationale for this change
I had to run sort-tpch queries with memory limit when testing fixes for
memory re
alamb closed issue #8529: Make
`datafusion::physical_optimizer::projection_pushdown` public
URL: https://github.com/apache/datafusion/issues/8529
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
alamb commented on issue #8529:
URL: https://github.com/apache/datafusion/issues/8529#issuecomment-2656443656
It appears `projection_pushdown` is now public:
https://docs.rs/datafusion/latest/datafusion/physical_optimizer/projection_pushdown/index.html
--
This is an automated message f
chenkovsky commented on PR #14057:
URL: https://github.com/apache/datafusion/pull/14057#issuecomment-2656443184
> I am sorry I have not been following along this PR closely -- is it ready
for a final review @chenkovsky and @adriangb ?
@alamb The discussion was very lively.
fro
logan-keede opened a new pull request, #14643:
URL: https://github.com/apache/datafusion/pull/14643
## Which issue does this PR close?
- part of #1
## Rationale for this change
refer to discussion in https://github.com/apache/datafusion/pull/14616
## Wh
alamb commented on issue #2326:
URL: https://github.com/apache/datafusion/issues/2326#issuecomment-2656486069
I think we will claim datafusion has pretty good structured type support
now, so let's close this epic and treat additional work as new issues / items
--
This is an automated mess
alamb commented on issue #11746:
URL: https://github.com/apache/datafusion/issues/11746#issuecomment-2656489040
I think this is woring wekk now
```
> create table t as values
(
[
{'name': 'n1', 'info': {'color': 'r', 'size': 1}},
{'name': 'n2', 'info'
alamb closed issue #2326: [EPIC] Improved support for nested / structured types
(`Struct` , `List`, `ListArray`, and other Composite types)
URL: https://github.com/apache/datafusion/issues/2326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
Kontinuation opened a new pull request, #14644:
URL: https://github.com/apache/datafusion/pull/14644
## Which issue does this PR close?
- Hopefully it closes #10073, but it is still an incomplete solution.
## Rationale for this change
I had a hard time making Data
alamb closed issue #11746: Add the ability to create tables with deeply nested
schemas in SQL
URL: https://github.com/apache/datafusion/issues/11746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
oznur-synnada commented on PR #14629:
URL: https://github.com/apache/datafusion/pull/14629#issuecomment-2656493238
Sure, @alamb I'll dive in and come up with a list of links that could be
added to this page.
--
This is an automated message from the Apache Git Service.
To respond to the me
alamb opened a new pull request, #14645:
URL: https://github.com/apache/datafusion/pull/14645
## Which issue does this PR close?
- closes https://github.com/apache/datafusion/issues/825
- closes https://github.com/apache/datafusion/issues/1222
## Rationale for this change
alamb commented on issue #825:
URL: https://github.com/apache/datafusion/issues/825#issuecomment-2656506160
Proposed to add in
- https://github.com/apache/datafusion/pull/14645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
alamb commented on issue #1222:
URL: https://github.com/apache/datafusion/issues/1222#issuecomment-2656506031
Proposed to add in
- https://github.com/apache/datafusion/pull/14645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
m09526 opened a new issue, #14646:
URL: https://github.com/apache/datafusion/issues/14646
### Is your feature request related to a problem or challenge?
[Sleeper](https://github.com/gchq/sleeper) is GCHQ's open-source,
cloud-native, log-structured merge tree based, scalable key-value
alamb commented on issue #1116:
URL: https://github.com/apache/datafusion/issues/1116#issuecomment-2656521042
When exact pushdown is enabled, there is no filter being applied in
DataFusion anymore 🎉
Specifically, there is no `FilterExec` in this plan:
```sql
> set datafusio
alamb closed issue #1116: Exact filter pushdown can be duplicated in some
instances
URL: https://github.com/apache/datafusion/issues/1116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
alamb commented on issue #14646:
URL: https://github.com/apache/datafusion/issues/14646#issuecomment-2656525714
Thanks @m09526 -- this is a great idea -- can you make a PR to do so in
https://github.com/apache/datafusion/blob/3802adf685e828ee6fbac3d16f1890e9ef33a34f/docs/source/user
UBarney commented on PR #14567:
URL: https://github.com/apache/datafusion/pull/14567#issuecomment-2656543100
@alamb
This transformation is correct in this case
according to this
[doc](https://docs.rs/datafusion/latest/datafusion/physical_optimizer/pruning/struct.PruningPredicate.h
milenkovicm commented on PR #14631:
URL: https://github.com/apache/datafusion/pull/14631#issuecomment-2655995363
thanks @alamb will address comments and do cleanup later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
alamb commented on PR #14595:
URL: https://github.com/apache/datafusion/pull/14595#issuecomment-2656160457
> So back to the semantics of the lateral join,
Thank you @skyzh -- this is an amazing description. THank you -- hopefully
we can include that in the source code eventually once
mbutrovich commented on PR #1387:
URL:
https://github.com/apache/datafusion-comet/pull/1387#issuecomment-2656275607
> So it looks like this PR does not have a negative impact on
`native_iceberg_compat`
Well that's good news!
--
This is an automated message from the Apache Git Service.
mbutrovich commented on code in PR #1387:
URL: https://github.com/apache/datafusion-comet/pull/1387#discussion_r1954307910
##
native/spark-expr/src/utils.rs:
##
@@ -72,9 +72,6 @@ pub fn array_with_timezone(
Some(DataType::Timestamp(_, Some(_))) => {
mbutrovich commented on PR #1387:
URL:
https://github.com/apache/datafusion-comet/pull/1387#issuecomment-2656274826
> I had the impression that this PR had originally reduced the number of
failures in native_iceberg_compat as well but that is no longer true after the
cleanup. Is that corre
jayzhan211 commented on PR #14532:
URL: https://github.com/apache/datafusion/pull/14532#issuecomment-2656285292
`array_element` doesn't change the list so not coerce to list makes sense to
me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
Kontinuation commented on PR #14642:
URL: https://github.com/apache/datafusion/pull/14642#issuecomment-2656545407
`sort_spill_reservation_bytes` is also an important configuration to tune
for benchmarks involving sorts, so I think we may also want to add it to
benchmarking tools.
--
This
alamb commented on PR #14629:
URL: https://github.com/apache/datafusion/pull/14629#issuecomment-2656544122
Thank you !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
Dandandan commented on issue #14161:
URL: https://github.com/apache/datafusion/issues/14161#issuecomment-2656539839
I took the liberty to edit the title according what @berkaysynnada shared.
It seems it could use a test to show the embedded projection from
`NestedLoopJoinExec` isn't pushe
alamb commented on PR #14567:
URL: https://github.com/apache/datafusion/pull/14567#issuecomment-2656570666
> @alamb Thanks for such a detailed example and explanation. I think this
transformation is correct in this case.
>
> according to this
[doc](https://docs.rs/datafusion/latest/d
wugeer commented on code in PR #1653:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1653#discussion_r1954510319
##
src/ast/query.rs:
##
@@ -2537,6 +2542,19 @@ impl fmt::Display for GroupByWithModifier {
GroupByWithModifier::Rollup => write!(f, "WITH R
Kontinuation commented on code in PR #14644:
URL: https://github.com/apache/datafusion/pull/14644#discussion_r1954497832
##
datafusion/physical-plan/src/sorts/sort.rs:
##
@@ -369,7 +356,7 @@ impl ExternalSorter {
.with_metrics(self.metrics.baseline.clone())
alamb commented on code in PR #14567:
URL: https://github.com/apache/datafusion/pull/14567#discussion_r1954515692
##
datafusion/physical-optimizer/src/pruning.rs:
##
@@ -1710,6 +1711,76 @@ fn build_like_match(
Some(combined)
}
+// For predicate `col NOT LIKE 'const_prefi
wugeer commented on code in PR #1653:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1653#discussion_r1954497259
##
src/parser/mod.rs:
##
@@ -9092,6 +9092,16 @@ impl<'a> Parser<'a> {
});
}
}
+if self.di
Kontinuation commented on code in PR #14644:
URL: https://github.com/apache/datafusion/pull/14644#discussion_r1954496042
##
datafusion/physical-plan/src/sorts/stream.rs:
##
@@ -171,20 +173,32 @@ impl std::fmt::Debug for
FieldCursorStream {
}
impl FieldCursorStream {
-pu
jkosh44 commented on PR #14532:
URL: https://github.com/apache/datafusion/pull/14532#issuecomment-2656668319
Thanks for the review @jayzhan211 and for all of your helpful feedback!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
alamb commented on PR #14567:
URL: https://github.com/apache/datafusion/pull/14567#issuecomment-2656655495
> `t.parquet` in is [zip
file](https://github.com/user-attachments/files/18784196/t.zip) (github doesn't
allow upload parquet file 😓)
BTW you can create such files using datafu
adriangb commented on PR #14057:
URL: https://github.com/apache/datafusion/pull/14057#issuecomment-2656813742
yep I agree. TLDR Andrew is:
1. There are two approaches, #14057 (this PR) and #14362.
2. Fundamentally it is not super clear how to define the feature set of a
"system column
logan-keede commented on PR #14643:
URL: https://github.com/apache/datafusion/pull/14643#issuecomment-2656628651
do we want `DataSource` trait in `datasource` crate? will that be a breaking
change since we won't be able to re-export `DataSource` in
`datafusion_physical_plan` without non-tri
logan-keede commented on PR #14643:
URL: https://github.com/apache/datafusion/pull/14643#issuecomment-2656630232
> do we want `DataSource` trait in `datasource` crate? will that be a
breaking change since we won't be able to re-export `DataSource` in
`datafusion_physical_plan` without non-t
wugeer commented on code in PR #1653:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1653#discussion_r1954521877
##
src/parser/mod.rs:
##
@@ -9092,6 +9092,16 @@ impl<'a> Parser<'a> {
});
}
}
+if self.di
wugeer commented on PR #1653:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1653#issuecomment-2656643152
@iffyio Thank you for your guidance! I have resubmitted the code and hope to
receive your review again. :)
--
This is an automated message from the Apache Git Service.
T
AdamGS commented on issue #14607:
URL: https://github.com/apache/datafusion/issues/14607#issuecomment-2656656413
that seems like an appropriate place, I'll try and play around with that
sometime this week and I'll share if I get anything I like.
--
This is an automated message from the Ap
jayzhan211 commented on PR #14643:
URL: https://github.com/apache/datafusion/pull/14643#issuecomment-2656705498
We should! It is in physical-plan because there is no datasource then. It
should be part of datasource crate
--
This is an automated message from the Apache Git Service.
To resp
jonahgao commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1954582396
##
datafusion/common/src/dfschema.rs:
##
@@ -1028,21 +1028,41 @@ impl SchemaExt for Schema {
})
}
-fn logically_equivalent_names_and_types
jonahgao commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1954592060
##
datafusion/common/src/dfschema.rs:
##
@@ -1028,21 +1028,41 @@ impl SchemaExt for Schema {
})
}
-fn logically_equivalent_names_and_types
chenkovsky opened a new pull request, #1020:
URL: https://github.com/apache/datafusion-python/pull/1020
# Which issue does this PR close?
No
# Rationale for this change
to_timestamp_nanos has a wrapper, but not exported from rust.
# What changes are included in th
jonahgao commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1954600078
##
datafusion/common/src/dfschema.rs:
##
@@ -1028,21 +1028,32 @@ impl SchemaExt for Schema {
})
}
-fn logically_equivalent_names_and_types
UBarney commented on code in PR #14567:
URL: https://github.com/apache/datafusion/pull/14567#discussion_r1954594478
##
datafusion/physical-optimizer/src/pruning.rs:
##
@@ -4061,6 +4132,106 @@ mod tests {
prune_with_expr(expr, &schema, &statistics, expected_ret);
}
jonahgao commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1954616404
##
datafusion/sqllogictest/test_files/insert_to_external.slt:
##
@@ -60,17 +60,16 @@ STORED AS parquet
LOCATION 'test_files/scratch/insert_to_external/parquet_ty
m09526 opened a new pull request, #14648:
URL: https://github.com/apache/datafusion/pull/14648
## Which issue does this PR close?
- Closes #14646.
## Rationale for this change
## What changes are included in this PR?
Modifies
[https://githu
jkosh44 commented on issue #14633:
URL: https://github.com/apache/datafusion/issues/14633#issuecomment-2656871273
> > > So as a workaround we could use any dialect that supports it (e.g.
postgresql), gotcha.
> >
> >
> > That sounds like it should work. From some googling it looks
eliaperantoni commented on issue #14433:
URL: https://github.com/apache/datafusion/issues/14433#issuecomment-2656881495
Hey @alan910127 how is it going with this ticket :) Can I help with anything?
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
eliaperantoni commented on issue #14430:
URL: https://github.com/apache/datafusion/issues/14430#issuecomment-2656885264
Hey @onlyjackfrost how is it going with this ticket :) Can I help with
anything?
--
This is an automated message from the Apache Git Service.
To respond to the message,
eliaperantoni commented on issue #14432:
URL: https://github.com/apache/datafusion/issues/14432#issuecomment-2656884080
Hey @Chen-Yuan-Lai how is it going with this ticket :) Can I help with
anything?
--
This is an automated message from the Apache Git Service.
To respond to the message,
eliaperantoni commented on issue #14438:
URL: https://github.com/apache/datafusion/issues/14438#issuecomment-2656882826
Hey @irenji how is it going with this ticket :) Can I help with anything?
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
eliaperantoni commented on issue #14437:
URL: https://github.com/apache/datafusion/issues/14437#issuecomment-2656882461
Hey @irenjj how is it going with this ticket :) Can I help with anything?
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
eliaperantoni commented on issue #14436:
URL: https://github.com/apache/datafusion/issues/14436#issuecomment-2656883539
Hey @zjregee how is it going with this ticket :) Can I help with anything?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
eliaperantoni commented on issue #14434:
URL: https://github.com/apache/datafusion/issues/14434#issuecomment-2656882060
Hey @ugoa how is it going with this ticket :) Can I help with anything?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
eliaperantoni commented on issue #14431:
URL: https://github.com/apache/datafusion/issues/14431#issuecomment-2656884665
Hey @dentiny how is it going with this ticket :) Can I help with anything?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
Omega359 commented on issue #13775:
URL: https://github.com/apache/datafusion/issues/13775#issuecomment-2656916888
I think the bug is still there but I haven't seen it in a while tbh so
whatever changes were made to the sqllogictests seem to no longer trigger
it.
On Thu, Feb 13,
zhuqi-lucas commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1954710305
##
datafusion/common/src/dfschema.rs:
##
@@ -1028,21 +1028,41 @@ impl SchemaExt for Schema {
})
}
-fn logically_equivalent_names_and_ty
ctsk commented on PR #14566:
URL: https://github.com/apache/datafusion/pull/14566#issuecomment-2656916325
Thank you for taking the time to review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jkosh44 commented on PR #14532:
URL: https://github.com/apache/datafusion/pull/14532#issuecomment-2656959911
I think this might also be an API change? I don't have the permissions to
add the tag though.
--
This is an automated message from the Apache Git Service.
To respond to the message
alamb commented on PR #14611:
URL: https://github.com/apache/datafusion/pull/14611#issuecomment-2656230770
Sorry for the back and forth @Ramjee194
From my perspective the issue is that I don't understand the implications of
this change
The ticket and this PR baiscally say "th
alamb closed issue #14581: coercion of input types in `coalesce` leads to type
unsupported arrow cast
URL: https://github.com/apache/datafusion/issues/14581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
alamb opened a new pull request, #14640:
URL: https://github.com/apache/datafusion/pull/14640
Draft until https://github.com/apache/datafusion/pull/12116 is done
## Which issue does this PR close?
- follow on to https://github.com/apache/datafusion/pull/12116
alamb merged PR #14602:
URL: https://github.com/apache/datafusion/pull/14602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #14629:
URL: https://github.com/apache/datafusion/pull/14629#issuecomment-2656242973
THANK YOU!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
alamb commented on PR #14629:
URL: https://github.com/apache/datafusion/pull/14629#issuecomment-2656247444
@oznur-synnada I wonder if you might be willing to add some additional
links to this page.
For example there are some links on the weekly summaries I write that maybe
could be
1 - 100 of 197 matches
Mail list logo
