Re: [I] Error "entered unreachable code: NamedStructField should be rewritten in OperatorToFunction" after upgrade to 37 [datafusion]

2024-05-07 Thread via GitHub
andygrove closed issue #10181: Error "entered unreachable code: NamedStructField should be rewritten in OperatorToFunction" after upgrade to 37 URL: https://github.com/apache/datafusion/issues/10181 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] Error "entered unreachable code: NamedStructField should be rewritten in OperatorToFunction" after upgrade to 37 [datafusion]

2024-05-01 Thread via GitHub
alamb commented on issue #10181: URL: https://github.com/apache/datafusion/issues/10181#issuecomment-2088929490 Here is a PR with a proposed new API: https://github.com/apache/datafusion/pull/10330 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] Error "entered unreachable code: NamedStructField should be rewritten in OperatorToFunction" after upgrade to 37 [datafusion]

2024-04-25 Thread via GitHub
alamb commented on issue #10181: URL: https://github.com/apache/datafusion/issues/10181#issuecomment-2078024545 > I am not entirely sure, in delta-rs we just parse SQL strings into logical exprs and then convert it to physical exprs without doing any adjustments there. I think in

Re: [I] Error "entered unreachable code: NamedStructField should be rewritten in OperatorToFunction" after upgrade to 37 [datafusion]

2024-04-25 Thread via GitHub
ion-elgreco commented on issue #10181: URL: https://github.com/apache/datafusion/issues/10181#issuecomment-2077614189 > > @alamb just checking in, is there something we need to refactor? Or are you simplifying the API and automatically handling this within datafusion on all code paths?

Re: [I] Error "entered unreachable code: NamedStructField should be rewritten in OperatorToFunction" after upgrade to 37 [datafusion]

2024-04-25 Thread via GitHub
alamb commented on issue #10181: URL: https://github.com/apache/datafusion/issues/10181#issuecomment-2077591431 > @alamb just checking in, is there something we need to refactor? Or are you simplifying the API and automatically handling this within datafusion on all code paths? I

Re: [I] Error "entered unreachable code: NamedStructField should be rewritten in OperatorToFunction" after upgrade to 37 [datafusion]

2024-04-25 Thread via GitHub
ion-elgreco commented on issue #10181: URL: https://github.com/apache/datafusion/issues/10181#issuecomment-2076660482 @alamb just checking in, is there something we need to refactor? Or are you simplifying the API and automatically handle this within datafusion on all code paths? --

Re: [I] Error "entered unreachable code: NamedStructField should be rewritten in OperatorToFunction" after upgrade to 37 [datafusion]

2024-04-23 Thread via GitHub
alamb commented on issue #10181: URL: https://github.com/apache/datafusion/issues/10181#issuecomment-2071951668 I am thinking I'll try and make a PR with such an API over the next day or two to see how it might look -- This is an automated message from the Apache Git Service. To respond

Re: [I] Error "entered unreachable code: NamedStructField should be rewritten in OperatorToFunction" after upgrade to 37 [datafusion]

2024-04-23 Thread via GitHub
alamb commented on issue #10181: URL: https://github.com/apache/datafusion/issues/10181#issuecomment-2071950006 > Another way to tackle it could be to leave the concept of a GetIndexedField node at the parsing layer and pull it out of Expr (or deprecate). This would force the conversion to

Re: [I] Error "entered unreachable code: NamedStructField should be rewritten in OperatorToFunction" after upgrade to 37 [datafusion]

2024-04-22 Thread via GitHub
jayzhan211 commented on issue #10181: URL: https://github.com/apache/datafusion/issues/10181#issuecomment-2071461117 > done between the parse plan and the logical plan I had also thought about deprecate `Expr` and use functions directly in parsing phase. I think it might be a good