JosiahWI commented on code in PR #10603:
URL: https://github.com/apache/trafficserver/pull/10603#discussion_r1361456327
##
iocore/cache/CacheEvacuateDocVC.h:
##
@@ -0,0 +1,72 @@
+/** @file
+
+ A brief file description
+
+ @section license License
+
+ Licensed to the Apache So
JosiahWI commented on PR #10603:
URL: https://github.com/apache/trafficserver/pull/10603#issuecomment-1765584758
Excellent observation, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
cmcfarlen opened a new pull request, #10629:
URL: https://github.com/apache/trafficserver/pull/10629
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
masaori335 commented on code in PR #9403:
URL: https://github.com/apache/trafficserver/pull/9403#discussion_r1361434922
##
iocore/eventsystem/I_VConnection.h:
##
@@ -362,7 +362,13 @@ class VConnection : public Continuation
return false;
}
-public:
+ // This function s
bneradt commented on PR #10626:
URL: https://github.com/apache/trafficserver/pull/10626#issuecomment-1765547348
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
masaori335 commented on PR #10603:
URL: https://github.com/apache/trafficserver/pull/10603#issuecomment-1765537732
It's better to change `int Vol::evacuateWrite(CacheVC *evacuator, int event,
Event *e)` to `int Vol::evacuateWrite(CacheEvacuateDocVC *evacuator, int event,
Event *e)` to make
masaori335 commented on code in PR #10603:
URL: https://github.com/apache/trafficserver/pull/10603#discussion_r1361425432
##
iocore/cache/CacheEvacuateDocVC.h:
##
@@ -0,0 +1,72 @@
+/** @file
+
+ A brief file description
+
+ @section license License
+
+ Licensed to the Apache
bneradt merged PR #10606:
URL: https://github.com/apache/trafficserver/pull/10606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@tra
bneradt merged PR #10611:
URL: https://github.com/apache/trafficserver/pull/10611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@tra
zwoop commented on code in PR #10559:
URL: https://github.com/apache/trafficserver/pull/10559#discussion_r1361328932
##
plugins/experimental/rate_limit/sni_selector.cc:
##
@@ -139,6 +262,26 @@ SniSelector::setupQueueCont()
_queue_cont = TSContCreate(sni_queue_cont, TSMutexC
ywkaras closed pull request #9587: Add Au test for TSSslSecretXxx API functions.
URL: https://github.com/apache/trafficserver/pull/9587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
bneradt commented on PR #10300:
URL: https://github.com/apache/trafficserver/pull/10300#issuecomment-1765372300
Looks like there's a trailing whitespace issue:
https://ci.trafficserver.apache.org/job/Github_Builds/job/clang-format/3365/console
```
+ git grep -IE ' +$'
+ f
masaori335 merged PR #10543:
URL: https://github.com/apache/trafficserver/pull/10543
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
ywkaras closed pull request #10231: Move Cleanup.h from include/tscpp/api to
include/ts.
URL: https://github.com/apache/trafficserver/pull/10231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
masaori335 merged PR #10542:
URL: https://github.com/apache/trafficserver/pull/10542
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
bryancall commented on PR #10300:
URL: https://github.com/apache/trafficserver/pull/10300#issuecomment-1765368404
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
duke8253 merged PR #10561:
URL: https://github.com/apache/trafficserver/pull/10561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@tr
ezelkow1 merged PR #10623:
URL: https://github.com/apache/trafficserver/pull/10623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@tr
bneradt commented on PR #10611:
URL: https://github.com/apache/trafficserver/pull/10611#issuecomment-1765352328
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
moonchen commented on PR #10626:
URL: https://github.com/apache/trafficserver/pull/10626#issuecomment-1765345501
[approve ci Ubuntu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
bneradt merged PR #10613:
URL: https://github.com/apache/trafficserver/pull/10613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@tra
bneradt commented on PR #10606:
URL: https://github.com/apache/trafficserver/pull/10606#issuecomment-1765343165
[approve ci freebsd]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
maskit opened a new pull request, #10627:
URL: https://github.com/apache/trafficserver/pull/10627
This PR adds below to enable us to implement/improve gate keeping plugins:
- Metrics that count the numbers of H2 frames (global)
- Internal counters that counts the number of H2 frames (se
moonchen opened a new pull request, #10626:
URL: https://github.com/apache/trafficserver/pull/10626
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
moonchen commented on PR #10317:
URL: https://github.com/apache/trafficserver/pull/10317#issuecomment-1765324843
> @moonchen This has merge conflicts, probably because of #10269 ? Can you
make a branch PR for 9.2.x please?
Created: #10625
--
This is an automated message from the Ap
moonchen opened a new pull request, #10625:
URL: https://github.com/apache/trafficserver/pull/10625
-Report disk I/O failure synchronously.
-Fix a signed/unsigned bug when checking disk I/O result. -Rename a couple
of symbols for clarity.
--
This is an automated message from the Apache
bneradt commented on PR #10613:
URL: https://github.com/apache/trafficserver/pull/10613#issuecomment-1765304441
[approve ci rocky]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
bneradt merged PR #239:
URL: https://github.com/apache/trafficserver-ci/pull/239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@traf
bneradt merged PR #238:
URL: https://github.com/apache/trafficserver-ci/pull/238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@traf
bneradt opened a new pull request, #238:
URL: https://github.com/apache/trafficserver-ci/pull/238
Reverts apache/trafficserver-ci#237
Reverting until we get freebsd working pthread_create:
```
[ 25%] Linking CXX executable test_tscore
cd
/usr/home/jenkins/workspace/Github
zwoop merged PR #10605:
URL: https://github.com/apache/trafficserver/pull/10605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@traff
zwoop merged PR #10619:
URL: https://github.com/apache/trafficserver/pull/10619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@traff
bneradt commented on PR #10606:
URL: https://github.com/apache/trafficserver/pull/10606#issuecomment-1765191541
[approve ci freebsd]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
bneradt merged PR #237:
URL: https://github.com/apache/trafficserver-ci/pull/237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@traf
bneradt opened a new pull request, #237:
URL: https://github.com/apache/trafficserver-ci/pull/237
Hopefully the resolv issue is addressed to the satisfaction of freebsd:
https://github.com/apache/trafficserver/issues/10620
Putting this back in to try it out.
--
This is an automated
cmcfarlen merged PR #10624:
URL: https://github.com/apache/trafficserver/pull/10624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@t
bneradt merged PR #10612:
URL: https://github.com/apache/trafficserver/pull/10612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@tra
zwoop merged PR #10622:
URL: https://github.com/apache/trafficserver/pull/10622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@traff
zwoop merged PR #10621:
URL: https://github.com/apache/trafficserver/pull/10621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@traff
maskit opened a new pull request, #10623:
URL: https://github.com/apache/trafficserver/pull/10623
(cherry picked from commit a8efca589716168a9c9cb32a74ddcb0915d59f7f)
Conflicts:
proxy/http2/Http2ConnectionState.cc
--
This is an automated message from the Apache Git Service.
maskit commented on PR #10583:
URL: https://github.com/apache/trafficserver/pull/10583#issuecomment-1765031095
For 8.1.x
https://github.com/apache/trafficserver/pull/10623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
maskit commented on PR #10583:
URL: https://github.com/apache/trafficserver/pull/10583#issuecomment-1765012810
For 9.2.x
https://github.com/apache/trafficserver/pull/10622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
bneradt commented on PR #10612:
URL: https://github.com/apache/trafficserver/pull/10612#issuecomment-1765007830
[approve ci rat]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
bneradt merged PR #10587:
URL: https://github.com/apache/trafficserver/pull/10587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@tra
maskit opened a new pull request, #10622:
URL: https://github.com/apache/trafficserver/pull/10622
(cherry picked from commit a8efca589716168a9c9cb32a74ddcb0915d59f7f)
Conflicts:
proxy/http2/Http2ConnectionState.cc
--
This is an automated message from the Apache Git Service.
bneradt merged PR #236:
URL: https://github.com/apache/trafficserver-ci/pull/236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@traf
bneradt opened a new pull request, #236:
URL: https://github.com/apache/trafficserver-ci/pull/236
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
maskit commented on PR #10584:
URL: https://github.com/apache/trafficserver/pull/10584#issuecomment-1765003799
For 9.2.x
https://github.com/apache/trafficserver/pull/10621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
maskit opened a new pull request, #10621:
URL: https://github.com/apache/trafficserver/pull/10621
Should respond with FRAME_SIZE_ERROR when receiving reset frame of incorrect
size before looking to see if the stream exists.
(cherry picked from commit bb951e905e7844f304e6635a84acbd0734
cmcfarlen merged PR #10614:
URL: https://github.com/apache/trafficserver/pull/10614
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@t
bneradt commented on PR #10614:
URL: https://github.com/apache/trafficserver/pull/10614#issuecomment-1764998521
Thanks @cmcfarlen .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
bneradt commented on PR #10612:
URL: https://github.com/apache/trafficserver/pull/10612#issuecomment-1764981931
[approve ci freebsd]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
bneradt merged PR #235:
URL: https://github.com/apache/trafficserver-ci/pull/235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@traf
bneradt opened a new pull request, #235:
URL: https://github.com/apache/trafficserver-ci/pull/235
This reverts commit 8f66b112dca6aa164db3488c7f642a0e81667072.
Reverting until the following is resolved for ATS builds for freebsd:
https://github.com/apache/trafficserver/issues/10620
bneradt commented on PR #10612:
URL: https://github.com/apache/trafficserver/pull/10612#issuecomment-1764947041
[approve ci freebsd]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
bneradt commented on PR #10612:
URL: https://github.com/apache/trafficserver/pull/10612#issuecomment-1764936491
[approve ci freebsd]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
bneradt merged PR #234:
URL: https://github.com/apache/trafficserver-ci/pull/234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@traf
bneradt opened a new pull request, #234:
URL: https://github.com/apache/trafficserver-ci/pull/234
Evan helped me install cmake on the freebsd boxes, so we should be able to
do cmake builds on them now.
--
This is an automated message from the Apache Git Service.
To respond to the message,
zwoop commented on PR #10556:
URL: https://github.com/apache/trafficserver/pull/10556#issuecomment-1764915706
Cherry-picked to v9.2.x
This has a trivial merge conflict due to TSDebug vs Dbg, which I resolved.
--
This is an automated message from the Apache Git Service.
To respond to
zwoop commented on PR #10317:
URL: https://github.com/apache/trafficserver/pull/10317#issuecomment-1764903898
@moonchen This has merge conflicts, probably because of #10269 ? Can you
make a branch PR for 9.2.x please?
--
This is an automated message from the Apache Git Service.
To respond
zwoop commented on PR #10551:
URL: https://github.com/apache/trafficserver/pull/10551#issuecomment-1764901720
Cherry-picked to v9.2.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
zwoop commented on PR #10286:
URL: https://github.com/apache/trafficserver/pull/10286#issuecomment-1764899890
Cherry-picked to v9.2.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
zwoop commented on PR #10579:
URL: https://github.com/apache/trafficserver/pull/10579#issuecomment-1764892826
Cherry-picked to v9.2.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
zwoop commented on PR #10540:
URL: https://github.com/apache/trafficserver/pull/10540#issuecomment-1764887193
Cherry-picked to v9.2.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
zwoop commented on PR #10520:
URL: https://github.com/apache/trafficserver/pull/10520#issuecomment-1764885747
Cherry-picked to v9.2.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
zwoop commented on PR #10521:
URL: https://github.com/apache/trafficserver/pull/10521#issuecomment-1764884280
@bneradt This gets merge conflicts because this plugin has moved on master.
If you want this on 9.2.x, please make another branch PR.
--
This is an automated message from the Apac
ezelkow1 commented on PR #10611:
URL: https://github.com/apache/trafficserver/pull/10611#issuecomment-1764877380
[approve ci osx]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
ezelkow1 merged PR #233:
URL: https://github.com/apache/trafficserver-ci/pull/233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@tra
zwoop opened a new pull request, #10619:
URL: https://github.com/apache/trafficserver/pull/10619
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
ezelkow1 opened a new pull request, #233:
URL: https://github.com/apache/trafficserver-ci/pull/233
copy over pull code from other pipelines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
zwoop commented on PR #10507:
URL: https://github.com/apache/trafficserver/pull/10507#issuecomment-1764871772
Cherry-picked to v9.2.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
zwoop commented on PR #10503:
URL: https://github.com/apache/trafficserver/pull/10503#issuecomment-1764859265
Cherry-picked to v9.2.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
zwoop commented on PR #10558:
URL: https://github.com/apache/trafficserver/pull/10558#issuecomment-1764803144
Also, with this landed, everyone better be ready and prepared to make branch
PRs, because cherry-picking from master to 9.x is not going to be trivial
anymore. :)
--
This is an a
bryancall merged PR #10618:
URL: https://github.com/apache/trafficserver/pull/10618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@t
zwoop commented on PR #10558:
URL: https://github.com/apache/trafficserver/pull/10558#issuecomment-1764783087
I agree with everything Chris said. :-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
maskit commented on PR #10591:
URL: https://github.com/apache/trafficserver/pull/10591#issuecomment-1764730623
https://github.com/apache/trafficserver/pull/10618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
maskit opened a new pull request, #10618:
URL: https://github.com/apache/trafficserver/pull/10618
(cherry picked from commit 641704b5c078edaba5b8082de6262a40bcd2d4fa)
Conflicts:
doc/admin-guide/plugins/block_errors.en.rst
--
This is an automated message from the Apache Git
cmcfarlen commented on PR #10558:
URL: https://github.com/apache/trafficserver/pull/10558#issuecomment-1764701612
This looks OK to me except for moving the `P_.*` files. These are private
headers that would have been in `.cc` files were it not for the odd "redefine
and include" trick with
JosiahWI commented on PR #10612:
URL: https://github.com/apache/trafficserver/pull/10612#issuecomment-1764511178
This is a good point. I can change it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
cmcfarlen commented on PR #10612:
URL: https://github.com/apache/trafficserver/pull/10612#issuecomment-1764329718
IMO just setting CMAKE_CXX_STANDARD directly is less mysterious than a
custom setting for the same. Also, we will have to maintain this one when we
want to build with C++23 or
cmcfarlen opened a new pull request, #10614:
URL: https://github.com/apache/trafficserver/pull/10614
This adds the `rat` target that behaves the same as the autotools version.
CI will still need to post-process the output to determine if there are
violations.
--
This is an automated mes
brbzull0 commented on code in PR #10559:
URL: https://github.com/apache/trafficserver/pull/10559#discussion_r1360305424
##
plugins/experimental/rate_limit/sni_selector.cc:
##
@@ -16,117 +16,240 @@
* limitations under the License.
*/
#include "tscore/ink_config.h"
+#include
82 matches
Mail list logo
