cmcfarlen opened a new pull request, #10774:
URL: https://github.com/apache/trafficserver/pull/10774
Since `tscore/DiagsType.h` includes `tscpp/util/Regex.h`, `tscore` needs a
PUBLIC dependency on `tscpputil`.
--
This is an automated message from the Apache Git Service.
To respond to the
traeak commented on code in PR #10723:
URL: https://github.com/apache/trafficserver/pull/10723#discussion_r1391895120
##
plugins/experimental/uri_signing/unit_tests/CMakeLists.txt:
##
@@ -26,8 +26,6 @@ add_executable(
${PROJECT_SOURCE_DIR}/match.cc
${PROJECT_SOURCE_DIR}/no
ywkaras commented on code in PR #10723:
URL: https://github.com/apache/trafficserver/pull/10723#discussion_r1391805747
##
plugins/experimental/uri_signing/unit_tests/CMakeLists.txt:
##
@@ -26,8 +26,6 @@ add_executable(
${PROJECT_SOURCE_DIR}/match.cc
${PROJECT_SOURCE_DIR}/n
ywkaras commented on code in PR #10723:
URL: https://github.com/apache/trafficserver/pull/10723#discussion_r1391805747
##
plugins/experimental/uri_signing/unit_tests/CMakeLists.txt:
##
@@ -26,8 +26,6 @@ add_executable(
${PROJECT_SOURCE_DIR}/match.cc
${PROJECT_SOURCE_DIR}/n
SolidWallOfCode merged PR #10722:
URL: https://github.com/apache/trafficserver/pull/10722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubsc
ywkaras commented on code in PR #10723:
URL: https://github.com/apache/trafficserver/pull/10723#discussion_r1391803434
##
plugins/experimental/uri_signing/unit_tests/CMakeLists.txt:
##
@@ -26,8 +26,6 @@ add_executable(
${PROJECT_SOURCE_DIR}/match.cc
${PROJECT_SOURCE_DIR}/n
duke8253 merged PR #10745:
URL: https://github.com/apache/trafficserver/pull/10745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@tr
cmcfarlen commented on code in PR #10769:
URL: https://github.com/apache/trafficserver/pull/10769#discussion_r1391772420
##
src/proxy/http/CMakeLists.txt:
##
@@ -45,7 +45,7 @@ if(BUILD_REGRESSION_TESTING)
target_sources(http PRIVATE RegressionHttpTransact.cc)
endif()
-targ
dragon512 commented on PR #10759:
URL: https://github.com/apache/trafficserver/pull/10759#issuecomment-1809226855
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dragon512 commented on code in PR #10769:
URL: https://github.com/apache/trafficserver/pull/10769#discussion_r1391732737
##
plugins/experimental/stek_share/CMakeLists.txt:
##
@@ -18,7 +18,7 @@
if(nuraft_FOUND)
add_atsplugin(stek_share common.cc log_store.cc stek_share.cc ste
SolidWallOfCode merged PR #10156:
URL: https://github.com/apache/trafficserver/pull/10156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubsc
lzx404243 opened a new pull request, #10771:
URL: https://github.com/apache/trafficserver/pull/10771
As titled. Don't see any usage of these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
dragon512 commented on PR #10759:
URL: https://github.com/apache/trafficserver/pull/10759#issuecomment-1808918107
> Autotools used PkgConfig in some places, but maybe we should convert this
Find module to follow the same format as the others. It is the only Find module
we have that uses Pkg
JosiahWI commented on PR #10759:
URL: https://github.com/apache/trafficserver/pull/10759#issuecomment-1808892461
Autotools used PkgConfig in some places, but maybe we should convert this
Find module to follow the same format as the others. It is the only Find module
we have that uses PkgCon
JosiahWI commented on PR #10759:
URL: https://github.com/apache/trafficserver/pull/10759#issuecomment-180835
This already used PkgConfig prior to these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
dragon512 commented on PR #10759:
URL: https://github.com/apache/trafficserver/pull/10759#issuecomment-180119
> Please fix the case on the FindLuaJIT.cmake file (It should be
Findluajit.cmake). Also, this adds a requirement of pkg-config being available
on the system. We have not requir
JosiahWI commented on code in PR #10769:
URL: https://github.com/apache/trafficserver/pull/10769#discussion_r1391561243
##
plugins/experimental/stek_share/CMakeLists.txt:
##
@@ -18,7 +18,7 @@
if(nuraft_FOUND)
add_atsplugin(stek_share common.cc log_store.cc stek_share.cc stek
serrislew merged PR #10701:
URL: https://github.com/apache/trafficserver/pull/10701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@t
dragon512 opened a new pull request, #10769:
URL: https://github.com/apache/trafficserver/pull/10769
This addresses some odd build paths I was finding in the build.
for example `-Iplugins/experimental/stek_share/nuraft::nuraft`
CMake seems to be adding the path correctly without
lzx404243 opened a new pull request, #10768:
URL: https://github.com/apache/trafficserver/pull/10768
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
JosiahWI commented on code in PR #10759:
URL: https://github.com/apache/trafficserver/pull/10759#discussion_r1391484713
##
cmake/FindLuaJIT.cmake:
##
@@ -15,35 +15,36 @@
#
###
-# FindLuaJIT.cmake
+# Findluajit.cmake
#
# This will define the following va
bneradt commented on PR #10627:
URL: https://github.com/apache/trafficserver/pull/10627#issuecomment-1808604213
[approve ci clang-format]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
bneradt commented on PR #10672:
URL: https://github.com/apache/trafficserver/pull/10672#issuecomment-1808602530
[approve ci clang-format]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
bneradt commented on PR #10701:
URL: https://github.com/apache/trafficserver/pull/10701#issuecomment-1808601353
[approve ci clang-format]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
bneradt commented on PR #10710:
URL: https://github.com/apache/trafficserver/pull/10710#issuecomment-1808600512
[approve ci clang-format]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
bneradt commented on PR #10722:
URL: https://github.com/apache/trafficserver/pull/10722#issuecomment-1808599311
[approve ci clang-format]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
bneradt commented on PR #10762:
URL: https://github.com/apache/trafficserver/pull/10762#issuecomment-1808595298
[approve ci clang-format]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
bneradt merged PR #10764:
URL: https://github.com/apache/trafficserver/pull/10764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@tra
duke8253 commented on PR #10742:
URL: https://github.com/apache/trafficserver/pull/10742#issuecomment-1808504244
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
dragon512 merged PR #10758:
URL: https://github.com/apache/trafficserver/pull/10758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@t
dragon512 commented on code in PR #10759:
URL: https://github.com/apache/trafficserver/pull/10759#discussion_r1391302009
##
cmake/FindLuaJIT.cmake:
##
@@ -15,35 +15,36 @@
#
###
-# FindLuaJIT.cmake
+# Findluajit.cmake
#
# This will define the following v
31 matches
Mail list logo
