[PR] Pull out down origin check from HttpSM::apply_ip_allow_filter [trafficserver]

2023-11-21 Thread via GitHub
bneradt opened a new pull request, #10831: URL: https://github.com/apache/trafficserver/pull/10831 In a refactor on master for the ip_allow implementation in HttpSM (see #9845) put into HttpSM::apply_ip_allow_filter. However, the down origin feature is orthogonal to ip_allow and it is confu

Re: [PR] Validation of YAML root structure for WIP SplitDNS YAML config [trafficserver]

2023-11-21 Thread via GitHub
bneradt commented on PR #10732: URL: https://github.com/apache/trafficserver/pull/10732#issuecomment-1821162502 [approve ci rat] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Add new API TSContScheduleOnEntirePool and TSContScheduleEveryOnEntirePool [trafficserver]

2023-11-21 Thread via GitHub
bneradt commented on PR #10742: URL: https://github.com/apache/trafficserver/pull/10742#issuecomment-1821160408 [approve ci rat] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] trafic_crashlog: Moving the removed ATS backtrace logs. [trafficserver]

2023-11-21 Thread via GitHub
bneradt commented on code in PR #10811: URL: https://github.com/apache/trafficserver/pull/10811#discussion_r1400780073 ## src/traffic_crashlog/backtrace.cc: ## @@ -0,0 +1,178 @@ +#include "tscore/ink_config.h" Review Comment: Thank you for the heads up, @randall and @brbzull

Re: [PR] DO NOT MERGE: testing rat check [trafficserver]

2023-11-21 Thread via GitHub
bneradt closed pull request #10830: DO NOT MERGE: testing rat check URL: https://github.com/apache/trafficserver/pull/10830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] DO NOT MERGE: testing rat check [trafficserver]

2023-11-21 Thread via GitHub
bneradt commented on PR #10830: URL: https://github.com/apache/trafficserver/pull/10830#issuecomment-1821150439 Test completed. Closing this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[PR] DO NOT MERGE: testing rat check [trafficserver]

2023-11-21 Thread via GitHub
bneradt opened a new pull request, #10830: URL: https://github.com/apache/trafficserver/pull/10830 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] Remove many standard UNIX HAVE_*_H build envs [trafficserver]

2023-11-21 Thread via GitHub
bneradt commented on PR #10824: URL: https://github.com/apache/trafficserver/pull/10824#issuecomment-1821140995 [approve ci rat] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] trafic_crashlog: Moving the removed ATS backtrace logs. [trafficserver]

2023-11-21 Thread via GitHub
bneradt commented on PR #10811: URL: https://github.com/apache/trafficserver/pull/10811#issuecomment-1821136010 [approve ci] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Fix the RAT CI to check for failures [trafficserver-ci]

2023-11-21 Thread via GitHub
bneradt merged PR #296: URL: https://github.com/apache/trafficserver-ci/pull/296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@traf

[PR] Fix the RAT CI to check for failures [trafficserver-ci]

2023-11-21 Thread via GitHub
bneradt opened a new pull request, #296: URL: https://github.com/apache/trafficserver-ci/pull/296 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] Add missing stdint.h to ink_file.h [trafficserver]

2023-11-21 Thread via GitHub
traeak commented on PR #10821: URL: https://github.com/apache/trafficserver/pull/10821#issuecomment-1820907467 Isn't better to use than ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe