Re: [PR] Rename vol to stripe (defined in the CacheVC.h) [trafficserver]

masaori335 commented on PR #10737: URL: https://github.com/apache/trafficserver/pull/10737#issuecomment-1829095053 Resolved conflicts. Please take another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[PR] Support gRPC traffic [trafficserver]

bneradt opened a new pull request, #9987: URL: https://github.com/apache/trafficserver/pull/9987 Now that we support HTTP/2 to origin, we can now support gRPC traffic end to end. This PR is made up of three patches: 1. A new gRPC autest. 2. Updates from @keesspoelstra to support tu

Re: [PR] Support gRPC traffic [trafficserver]

bneradt commented on PR #9987: URL: https://github.com/apache/trafficserver/pull/9987#issuecomment-1828974265 Sorry github-actions. We have to land this, so we can't close it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] Make dubiously correct changes to Japanese docs for TSDebug -> Dbg. [trafficserver]

ywkaras merged PR #10807: URL: https://github.com/apache/trafficserver/pull/10807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@tra

Re: [PR] Support gRPC traffic [trafficserver]

github-actions[bot] closed pull request #9987: Support gRPC traffic URL: https://github.com/apache/trafficserver/pull/9987 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] CMake: Add "nice" file to contain persistent options. [trafficserver]

SolidWallOfCode commented on PR #10839: URL: https://github.com/apache/trafficserver/pull/10839#issuecomment-1828873786 From my point of view, the key advantages are 1. Self contained - I don't need to do anything else in my IDE or on the command line to make it work. E.g. no `--prese

Re: [PR] Removes the tsxs command line tool [trafficserver]

bneradt commented on code in PR #10790: URL: https://github.com/apache/trafficserver/pull/10790#discussion_r1406910312 ## tests/gold_tests/autest-site/setup.cli.ext: ## @@ -123,22 +122,13 @@ if ENV['ATS_BIN'] is not None: Variables.trafficserver_version = out host.Writ

Re: [PR] Add check in ts.h that language is C++, version 17 or later. [trafficserver]

ywkaras merged PR #10796: URL: https://github.com/apache/trafficserver/pull/10796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@tra

Re: [PR] remove curl depends from traffic_top [trafficserver]

bryancall commented on PR #10814: URL: https://github.com/apache/trafficserver/pull/10814#issuecomment-1828811242 I need to email the dev@ mailing list before this gets merged in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] TS_USE_MMAP: mmap+memcopy instead pread+pwrite [trafficserver]

bryancall commented on PR #10832: URL: https://github.com/apache/trafficserver/pull/10832#issuecomment-1828799309 Do you have a benchmark comparing the performance of mmap vs pread? New features would go into the master branch and we most likely wouldn't backport this change into 9.x

Re: [PR] CMake: Add "nice" file to contain persistent options. [trafficserver]

SolidWallOfCode closed pull request #10839: CMake: Add "nice" file to contain persistent options. URL: https://github.com/apache/trafficserver/pull/10839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Coverity 1497421: Uninitialized scalar variable in ESI plugin [trafficserver]

serrislew commented on code in PR #10834: URL: https://github.com/apache/trafficserver/pull/10834#discussion_r1406889231 ## plugins/esi/common/gzip.cc: ## @@ -79,9 +79,12 @@ EsiLib::gzip(const ByteBlockList &blocks, std::string &cdata) { cdata.assign(GZIP_HEADER_SIZE, 0); //

Re: [PR] Rename vol to stripe (local vars & args) [trafficserver]

masaori335 merged PR #10847: URL: https://github.com/apache/trafficserver/pull/10847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] Update _read_vio.cont/_write_vio.cont when application is changed to QPACK [trafficserver]

duke8253 merged PR #10851: URL: https://github.com/apache/trafficserver/pull/10851 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@tr

Re: [PR] Cleanup/Flatten out some headers inclusion [trafficserver]

lzx404243 merged PR #10768: URL: https://github.com/apache/trafficserver/pull/10768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@t

Re: [PR] Adds txn counts for outbound conns & cleanup [trafficserver]

SolidWallOfCode commented on code in PR #10848: URL: https://github.com/apache/trafficserver/pull/10848#discussion_r1406862416 ## src/cripts/Error.cc: ## @@ -29,7 +29,7 @@ Error::execute(Cript::Context *context) // These are static, to be used with the get() wrapper void -Er

Re: [PR] Core implementation of ip_category for ip_allow.yaml [trafficserver]

ywkaras commented on code in PR #10840: URL: https://github.com/apache/trafficserver/pull/10840#discussion_r1406859964 ## example/plugins/c-api/ip_category/ip_category.cc: ## @@ -0,0 +1,122 @@ +/** @file + + Demonstrate a TS_HTTP_IP_ALLOW_CATEGORY_HOOK plugin. + + @section lic

Re: [PR] Update to libswoc 1.5.8 [trafficserver]

SolidWallOfCode commented on PR #10849: URL: https://github.com/apache/trafficserver/pull/10849#issuecomment-1828727162 [approve ci] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Update _read_vio.cont/_write_vio.cont when application is changed to QPACK [trafficserver]

maskit commented on PR #10851: URL: https://github.com/apache/trafficserver/pull/10851#issuecomment-1828687324 [approve ci centos] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Core implementation of ip_category for ip_allow.yaml [trafficserver]

bneradt commented on code in PR #10840: URL: https://github.com/apache/trafficserver/pull/10840#discussion_r1406803072 ## example/plugins/c-api/ip_category/ip_category.cc: ## @@ -0,0 +1,122 @@ +/** @file + + Demonstrate a TS_HTTP_IP_ALLOW_CATEGORY_HOOK plugin. + + @section lic

Re: [PR] Core implementation of ip_category for ip_allow.yaml [trafficserver]

ywkaras commented on code in PR #10840: URL: https://github.com/apache/trafficserver/pull/10840#discussion_r1406764706 ## example/plugins/c-api/ip_category/ip_category.cc: ## @@ -0,0 +1,122 @@ +/** @file + + Demonstrate a TS_HTTP_IP_ALLOW_CATEGORY_HOOK plugin. + + @section lic

Re: [PR] Core implementation of ip_category for ip_allow.yaml [trafficserver]

ywkaras commented on code in PR #10840: URL: https://github.com/apache/trafficserver/pull/10840#discussion_r1406764706 ## example/plugins/c-api/ip_category/ip_category.cc: ## @@ -0,0 +1,122 @@ +/** @file + + Demonstrate a TS_HTTP_IP_ALLOW_CATEGORY_HOOK plugin. + + @section lic

Re: [PR] Coverity 1518588: Out-of-bounds read in healthchecks plugin [trafficserver]

maskit commented on code in PR #10841: URL: https://github.com/apache/trafficserver/pull/10841#discussion_r1406735896 ## plugins/healthchecks/healthchecks.cc: ## @@ -213,10 +213,10 @@ hc_thread(void *data ATS_UNUSED) } if (len >= 0) { - int i = 0; + uint32_

Re: [PR] Coverity 1518588: Out-of-bounds read in healthchecks plugin [trafficserver]

maskit commented on code in PR #10841: URL: https://github.com/apache/trafficserver/pull/10841#discussion_r1406735896 ## plugins/healthchecks/healthchecks.cc: ## @@ -213,10 +213,10 @@ hc_thread(void *data ATS_UNUSED) } if (len >= 0) { - int i = 0; + uint32_

Re: [PR] cmake: Update pre-commit even if it exists [trafficserver]

cmcfarlen merged PR #10776: URL: https://github.com/apache/trafficserver/pull/10776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@t

[PR] Update _read_vio.cont/_write_vio.cont when application is changed to QPACK [trafficserver]

duke8253 opened a new pull request, #10851: URL: https://github.com/apache/trafficserver/pull/10851 This resolves #9748. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Coverity 1523683: Uninitialized scalar variable in s3_auth unit test [trafficserver]

bryancall merged PR #10833: URL: https://github.com/apache/trafficserver/pull/10833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@t

Re: [PR] Coverity 1497314: Uninitialized scalar variable in ESI plugin [trafficserver]

bryancall merged PR #10835: URL: https://github.com/apache/trafficserver/pull/10835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@t

Re: [PR] Coverity 1497273: Uninitialized scalar variable in Machine class [trafficserver]

bryancall merged PR #10836: URL: https://github.com/apache/trafficserver/pull/10836 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@t

Re: [PR] Coverity 1521594: Uninitialized pointer read for InterceptIO::vc [trafficserver]

bryancall merged PR #10838: URL: https://github.com/apache/trafficserver/pull/10838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@t

Re: [PR] Coverity 1497238: Uninitialized scalar variable in DiagsConfigState class [trafficserver]

bryancall merged PR #10837: URL: https://github.com/apache/trafficserver/pull/10837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@t

Re: [PR] Coverity 1518587: Buffer not null terminated in healthchecks plugin [trafficserver]

bryancall merged PR #10842: URL: https://github.com/apache/trafficserver/pull/10842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@t

Re: [PR] Coverity 1518588: Out-of-bounds read in healthchecks plugin [trafficserver]

bryancall commented on code in PR #10841: URL: https://github.com/apache/trafficserver/pull/10841#discussion_r1406726695 ## plugins/healthchecks/healthchecks.cc: ## @@ -213,10 +213,10 @@ hc_thread(void *data ATS_UNUSED) } if (len >= 0) { - int i = 0; + uint

Re: [PR] Remove the direct dependency for HttpCacheSM from iocore/cache [trafficserver]

maskit merged PR #10721: URL: https://github.com/apache/trafficserver/pull/10721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@traf

Re: [PR] Coverity 1518588: Out-of-bounds read in healthchecks plugin [trafficserver]

maskit commented on code in PR #10841: URL: https://github.com/apache/trafficserver/pull/10841#discussion_r1406717169 ## plugins/healthchecks/healthchecks.cc: ## @@ -213,10 +213,10 @@ hc_thread(void *data ATS_UNUSED) } if (len >= 0) { - int i = 0; + uint32_

[PR] Update to libswoc 1.5.8 [trafficserver]

SolidWallOfCode opened a new pull request, #10849: URL: https://github.com/apache/trafficserver/pull/10849 Minor cleanups. Improvements in `Errata` to help with #10112. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Adds txn counts for outbound conns & cleanup [trafficserver]

SolidWallOfCode commented on code in PR #10848: URL: https://github.com/apache/trafficserver/pull/10848#discussion_r1406699775 ## src/cripts/Headers.cc: ## @@ -22,24 +22,21 @@ // Constants const Header::Iterator Header::Iterator::_end = Header::Iterator("__END__", Header::Ite

Re: [PR] Cleanup/Flatten out some headers inclusion [trafficserver]

cmcfarlen commented on PR #10768: URL: https://github.com/apache/trafficserver/pull/10768#issuecomment-1828474897 This lgtm, but needs rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Add Errata support to YAML configuration support (promoted from IPAllow) [trafficserver]

SolidWallOfCode merged PR #10809: URL: https://github.com/apache/trafficserver/pull/10809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

Re: [PR] Improve seen list for the RAM cache [trafficserver]

SolidWallOfCode commented on code in PR #10662: URL: https://github.com/apache/trafficserver/pull/10662#discussion_r1406604459 ## src/iocore/cache/RamCacheLRU.cc: ## @@ -107,11 +109,11 @@ RamCacheLRU::resize_hashtable() } bucket = new_bucket; nbuckets = anbuckets; -

Re: [PR] Improve seen list for the RAM cache [trafficserver]

SolidWallOfCode commented on code in PR #10662: URL: https://github.com/apache/trafficserver/pull/10662#discussion_r1406601047 ## src/iocore/cache/RamCacheLRU.cc: ## @@ -107,11 +109,11 @@ RamCacheLRU::resize_hashtable() } bucket = new_bucket; nbuckets = anbuckets; -

Re: [PR] Improve seen list for the RAM cache [trafficserver]

SolidWallOfCode commented on code in PR #10662: URL: https://github.com/apache/trafficserver/pull/10662#discussion_r1406600721 ## src/iocore/cache/RamCacheLRU.cc: ## @@ -84,13 +85,14 @@ RamCacheLRU::size() const ClassAllocator ramCacheLRUEntryAllocator("RamCacheLRUEntry");

Re: [PR] Remove code for old openssl [trafficserver]

maskit merged PR #10792: URL: https://github.com/apache/trafficserver/pull/10792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@traf

Re: [PR] Improve seen list for the RAM cache [trafficserver]

SolidWallOfCode commented on code in PR #10662: URL: https://github.com/apache/trafficserver/pull/10662#discussion_r1406594186 ## src/iocore/cache/RamCacheLRU.cc: ## @@ -84,13 +85,14 @@ RamCacheLRU::size() const ClassAllocator ramCacheLRUEntryAllocator("RamCacheLRUEntry");

Re: [PR] Improve seen list for the RAM cache [trafficserver]

SolidWallOfCode commented on code in PR #10662: URL: https://github.com/apache/trafficserver/pull/10662#discussion_r1406592391 ## src/iocore/cache/RamCacheLRU.cc: ## @@ -47,7 +48,7 @@ struct RamCacheLRU : public RamCache { void init(int64_t max_bytes, Vol *vol) override;

Re: [PR] Clang Format: remove unused values. [trafficserver]

bneradt commented on PR #10845: URL: https://github.com/apache/trafficserver/pull/10845#issuecomment-1828236265 > No - if you change them, it has no effect. It seems more like a trap than useful. Oh, that's interesting. I had wondered that when I first saw this, but I confirmed that

Re: [PR] MPTCP warnings and clean up [trafficserver]

serrislew merged PR #10802: URL: https://github.com/apache/trafficserver/pull/10802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@t

Re: [PR] Clang Format: remove unused values. [trafficserver]

SolidWallOfCode commented on PR #10845: URL: https://github.com/apache/trafficserver/pull/10845#issuecomment-1828185884 No - if you change them, it has no effect. It seems more like a trap than useful. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Cleanup: remove some autotools files from .gitignore. [trafficserver]

SolidWallOfCode merged PR #10843: URL: https://github.com/apache/trafficserver/pull/10843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc