bneradt commented on code in PR #10856:
URL: https://github.com/apache/trafficserver/pull/10856#discussion_r1423366205
##
tests/gold_tests/timeout/create_request.sh:
##
@@ -16,5 +16,42 @@
# See the License for the specific language governing permissions and
# limitations und
ywkaras commented on code in PR #10918:
URL: https://github.com/apache/trafficserver/pull/10918#discussion_r1423350979
##
src/api/InkAPI.cc:
##
@@ -6575,10 +6575,6 @@ tsapi::c::TSPluginVCIOBufferWaterMarkGet(TSHttpTxn txnp)
return TS_IOBUFFER_WATER_MARK_PLUGIN_VC_DEFAULT;
}
ywkaras commented on code in PR #10918:
URL: https://github.com/apache/trafficserver/pull/10918#discussion_r1423350979
##
src/api/InkAPI.cc:
##
@@ -6575,10 +6575,6 @@ tsapi::c::TSPluginVCIOBufferWaterMarkGet(TSHttpTxn txnp)
return TS_IOBUFFER_WATER_MARK_PLUGIN_VC_DEFAULT;
}
bneradt commented on code in PR #10889:
URL: https://github.com/apache/trafficserver/pull/10889#discussion_r1423350974
##
src/api/CMakeLists.txt:
##
@@ -52,12 +51,28 @@ target_link_libraries(
)
# Items that even tscore can depend on
-add_library(tsapicore Metrics.cc DbgCtl.c
ywkaras commented on code in PR #10918:
URL: https://github.com/apache/trafficserver/pull/10918#discussion_r1423349124
##
doc/developer-guide/api/functions/TSIpStringToAddr.en.rst:
##
@@ -53,4 +49,3 @@ Notes
=
This API may be changed in the future version since it is exp
SolidWallOfCode commented on PR #10900:
URL: https://github.com/apache/trafficserver/pull/10900#issuecomment-1851220897
CMake build should work on all supported operating systems, as you can see
from the CI.
--
This is an automated message from the Apache Git Service.
To respond to the me
SolidWallOfCode commented on PR #10900:
URL: https://github.com/apache/trafficserver/pull/10900#issuecomment-1851068153
Sorry, I got distracted. The build directory is not present initially,
running `cmake -B build` should create that directory. If you use CLion or
VSCode it's easier as you
cmcfarlen commented on code in PR #10908:
URL: https://github.com/apache/trafficserver/pull/10908#discussion_r1423236615
##
rc/trafficserver.in:
##
@@ -248,7 +248,7 @@ do_stop()
# 1 if daemon was already stopped
# 2 if daemon could not be stopped
# other if a fail
bneradt commented on PR #10908:
URL: https://github.com/apache/trafficserver/pull/10908#issuecomment-1851060558
[approve ci osx]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
duke8253 commented on PR #10924:
URL: https://github.com/apache/trafficserver/pull/10924#issuecomment-1851042909
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
duke8253 opened a new pull request, #10924:
URL: https://github.com/apache/trafficserver/pull/10924
Updating `traffic_via` to be able to recognize Read While Write.
i.e.
```
Via header is [cWs f ], Length is 6
Via Header Details:
Result of Traffic Server cache lookup f
SolidWallOfCode closed pull request #10839: CMake: Add "nice" file to contain
persistent options.
URL: https://github.com/apache/trafficserver/pull/10839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
cmcfarlen merged PR #10899:
URL: https://github.com/apache/trafficserver/pull/10899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@t
cmcfarlen commented on code in PR #10899:
URL: https://github.com/apache/trafficserver/pull/10899#discussion_r1422780176
##
src/tscore/Diags.cc:
##
@@ -213,6 +214,37 @@ Diags::~Diags()
deactivate_all(DiagsTagType_Action);
}
+struct DiagTimestamp {
+ std::chrono::time_poin
ywkaras merged PR #10920:
URL: https://github.com/apache/trafficserver/pull/10920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@tra
moleksy commented on PR #10832:
URL: https://github.com/apache/trafficserver/pull/10832#issuecomment-1850154236
@SolidWallOfCode
Hello Alan, would you like us to provide additional information so that the
PR can be approved?
Best Regards
Maciej
--
This is an automated message fr
masaori335 commented on code in PR #10923:
URL: https://github.com/apache/trafficserver/pull/10923#discussion_r1422454162
##
src/iocore/cache/Cache.cc:
##
@@ -693,40 +659,56 @@ CacheProcessor::cacheInitialized()
// Dump some ram_cache size information in debug mode.
masaori335 commented on code in PR #10923:
URL: https://github.com/apache/trafficserver/pull/10923#discussion_r1422436396
##
src/iocore/cache/Cache.cc:
##
@@ -645,45 +634,22 @@ CacheProcessor::cacheInitialized()
break;
}
}
+
+ int64_t http_ram_cac
masaori335 commented on code in PR #10923:
URL: https://github.com/apache/trafficserver/pull/10923#discussion_r1422436396
##
src/iocore/cache/Cache.cc:
##
@@ -645,45 +634,22 @@ CacheProcessor::cacheInitialized()
break;
}
}
+
+ int64_t http_ram_cac
masaori335 commented on code in PR #10923:
URL: https://github.com/apache/trafficserver/pull/10923#discussion_r1422431085
##
src/iocore/cache/Cache.cc:
##
@@ -576,8 +576,6 @@ CacheProcessor::diskInitialized()
void
CacheProcessor::cacheInitialized()
{
- int i;
-
if (theCac
masaori335 commented on code in PR #10923:
URL: https://github.com/apache/trafficserver/pull/10923#discussion_r1422431085
##
src/iocore/cache/Cache.cc:
##
@@ -576,8 +576,6 @@ CacheProcessor::diskInitialized()
void
CacheProcessor::cacheInitialized()
{
- int i;
-
if (theCac
masaori335 opened a new pull request, #10923:
URL: https://github.com/apache/trafficserver/pull/10923
Alternative approach of #10922 to fix #10921.
The root cause is `CacheProcessor::cacheInitialized` has ton of duplicated
code for `AUTO_SIZE_RAM_CACHE` case and configured case. This
masaori335 closed pull request #10922: Increment cache.volume_N.stripes with
auto size ram cache
URL: https://github.com/apache/trafficserver/pull/10922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
23 matches
Mail list logo
