Re: [PR] Cleanup: Span and Store [trafficserver]

2024-01-05 Thread via GitHub
oknet commented on PR #10952: URL: https://github.com/apache/trafficserver/pull/10952#issuecomment-1879586573 If we don't need to recall the old `MultiCache`, then these cleanups are OK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] Transforms: Handle INT64_MAX TSVConnWrite values [trafficserver]

2024-01-05 Thread via GitHub
oknet commented on PR #10965: URL: https://github.com/apache/trafficserver/pull/10965#issuecomment-1879583678 There are 2 types of transforms: `Post Transform` and `Response Transform`. The `Transform` read data from upstream and write data to downstream. As the writer of plugin

Re: [PR] multiplexer: debug logging and variable name updates [trafficserver]

2024-01-05 Thread via GitHub
oknet commented on code in PR #10964: URL: https://github.com/apache/trafficserver/pull/10964#discussion_r1443645447 ## plugins/multiplexer/post.cc: ## @@ -48,55 +52,65 @@ postTransform(const TSCont c, PostState &s) { assert(c != nullptr); - const TSVConn vconnection = TS

Re: [PR] Comment out the broken exporter [trafficserver-ingress-controller]

2024-01-05 Thread via GitHub
shukitchan merged PR #176: URL: https://github.com/apache/trafficserver-ingress-controller/pull/176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gith

[PR] Comment out the broken exporter [trafficserver-ingress-controller]

2024-01-05 Thread via GitHub
shukitchan opened a new pull request, #176: URL: https://github.com/apache/trafficserver-ingress-controller/pull/176 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] tools/install_cmake.sh [trafficserver]

2024-01-05 Thread via GitHub
bneradt commented on PR #10970: URL: https://github.com/apache/trafficserver/pull/10970#issuecomment-1879486579 > I don't mind having this script as long as I'm not required to use it, You're definitely not required to use it. I was asked to write this to make it easier for people to

Re: [PR] tools/install_cmake.sh [trafficserver]

2024-01-05 Thread via GitHub
maskit commented on PR #10970: URL: https://github.com/apache/trafficserver/pull/10970#issuecomment-1879446949 I don't mind having this script as long as I'm not required to use it, but I wonder why the script uses Homebrew for MacOS where the repository has binaries for MacOS as well. The

[PR] tools/install_cmake.sh [trafficserver]

2024-01-05 Thread via GitHub
bneradt opened a new pull request, #10970: URL: https://github.com/apache/trafficserver/pull/10970 This adds tools/install_cmake.sh which installs a recent version of CMake. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Fix a bug in OCSP update with dual cert configuration [trafficserver]

2024-01-05 Thread via GitHub
maskit commented on code in PR #10959: URL: https://github.com/apache/trafficserver/pull/10959#discussion_r1443412016 ## src/iocore/net/OCSPStapling.cc: ## @@ -1256,33 +1256,40 @@ ocsp_update() time_t current_time; SSLCertificateConfig::scoped_config certLookup; - const

[PR] Add missing ts::records dep to block_errors plugin [trafficserver]

2024-01-05 Thread via GitHub
JosiahWI opened a new pull request, #10969: URL: https://github.com/apache/trafficserver/pull/10969 This makes the symbol TS_ALPN_PROTOCOL_HTTP_2_0, which is defined in the records library, visible to the block_errors plugin. Just like #10968, this is not a good long term fix. -- This is

Re: [PR] Add tscore to access_control dependencies [trafficserver]

2024-01-05 Thread via GitHub
bneradt merged PR #10968: URL: https://github.com/apache/trafficserver/pull/10968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@tra

Re: [PR] Add auto options for all experimental plugins [trafficserver]

2024-01-05 Thread via GitHub
JosiahWI commented on PR #10967: URL: https://github.com/apache/trafficserver/pull/10967#issuecomment-1879115643 Blocking on #10968. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Fix a bug in OCSP update with dual cert configuration [trafficserver]

2024-01-05 Thread via GitHub
bneradt commented on code in PR #10959: URL: https://github.com/apache/trafficserver/pull/10959#discussion_r1443226562 ## src/iocore/net/OCSPStapling.cc: ## @@ -1256,33 +1256,40 @@ ocsp_update() time_t current_time; SSLCertificateConfig::scoped_config certLookup; - cons

Re: [PR] Persist bad disks [trafficserver]

2024-01-05 Thread via GitHub
bneradt commented on code in PR #10960: URL: https://github.com/apache/trafficserver/pull/10960#discussion_r1443212011 ## doc/admin-guide/files/records.yaml.en.rst: ## @@ -2488,6 +2488,29 @@ Cache Control used from the asynchronous IO threads when IO finishes and the ``Cache

Re: [PR] Persist bad disks [trafficserver]

2024-01-05 Thread via GitHub
bneradt commented on code in PR #10960: URL: https://github.com/apache/trafficserver/pull/10960#discussion_r1443208889 ## doc/admin-guide/files/records.yaml.en.rst: ## @@ -2488,6 +2488,29 @@ Cache Control used from the asynchronous IO threads when IO finishes and the ``Cache

Re: [PR] Persist bad disks [trafficserver]

2024-01-05 Thread via GitHub
bneradt commented on PR #10960: URL: https://github.com/apache/trafficserver/pull/10960#issuecomment-1879057804 [approve ci ubuntu] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Add auto options for all experimental plugins [trafficserver]

2024-01-05 Thread via GitHub
bneradt commented on PR #10967: URL: https://github.com/apache/trafficserver/pull/10967#issuecomment-1879055979 In case it's helpful: https://ci.trafficserver.apache.org/job/Github_Builds/job/ubuntu/3647/console ``` INFO: YAML_CPP version 0.8.0 CMake Error at cmake/AutoOptionH

[PR] Add auto options for all experimental plugins [trafficserver]

2024-01-05 Thread via GitHub
JosiahWI opened a new pull request, #10967: URL: https://github.com/apache/trafficserver/pull/10967 Auto options were added for the experimental plugins with special dependencies in #10741. This adds options for the remaining experimental plugins. -- This is an automated message from the

Re: [PR] Update build.yml [trafficserver-ingress-controller]

2024-01-05 Thread via GitHub
shukitchan merged PR #175: URL: https://github.com/apache/trafficserver-ingress-controller/pull/175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gith

[PR] Update build.yml [trafficserver-ingress-controller]

2024-01-05 Thread via GitHub
shukitchan opened a new pull request, #175: URL: https://github.com/apache/trafficserver-ingress-controller/pull/175 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Remove Stripe::add_agg_todo [trafficserver]

2024-01-05 Thread via GitHub
JosiahWI commented on PR #10827: URL: https://github.com/apache/trafficserver/pull/10827#issuecomment-1878939501 I observed a failure in the `cache-request-method` AuTest, which went away on subsequent runs, so it seems to be due to `CACHE_AGG_FAIL_RATE` being turned on. I don't think this