[PR] Doc: storage.yaml [trafficserver]

2024-01-22 Thread via GitHub
masaori335 opened a new pull request, #11000: URL: https://github.com/apache/trafficserver/pull/11000 Draft PR for discuss details of making `volume.config` and `storage.config` into one YAML file. Most of the docs were written by @SolidWallOfCode last year and I made some changes fr

Re: [PR] Move session pool metrics calls outside critical section [trafficserver]

2024-01-22 Thread via GitHub
traeak commented on code in PR #10996: URL: https://github.com/apache/trafficserver/pull/10996#discussion_r1462586206 ## src/proxy/http/HttpSessionManager.cc: ## @@ -491,6 +494,11 @@ HttpSessionManager::_acquire_session(sockaddr const *ip, CryptoHash const &hostn }

Re: [PR] Move session pool metrics calls outside critical section [trafficserver]

2024-01-22 Thread via GitHub
traeak commented on code in PR #10996: URL: https://github.com/apache/trafficserver/pull/10996#discussion_r1462585285 ## src/proxy/http/HttpSessionManager.cc: ## @@ -491,6 +494,11 @@ HttpSessionManager::_acquire_session(sockaddr const *ip, CryptoHash const &hostn }

Re: [PR] Cleanup: CacheProcessor::start_internal [trafficserver]

2024-01-22 Thread via GitHub
masaori335 merged PR #10998: URL: https://github.com/apache/trafficserver/pull/10998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] Add auto options for all experimental plugins [trafficserver]

2024-01-22 Thread via GitHub
bryancall commented on PR #10967: URL: https://github.com/apache/trafficserver/pull/10967#issuecomment-1905041912 [approve ci osx] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Add missing ts::records dep to block_errors plugin [trafficserver]

2024-01-22 Thread via GitHub
JosiahWI closed pull request #10969: Add missing ts::records dep to block_errors plugin URL: https://github.com/apache/trafficserver/pull/10969 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Move session pool metrics calls outside critical section [trafficserver]

2024-01-22 Thread via GitHub
bneradt commented on code in PR #10996: URL: https://github.com/apache/trafficserver/pull/10996#discussion_r1462558776 ## src/proxy/http/HttpSessionManager.cc: ## @@ -491,6 +494,11 @@ HttpSessionManager::_acquire_session(sockaddr const *ip, CryptoHash const &hostn }

Re: [PR] CMAKE_INSTALL_FULL_LOGDIR and CMAKE_INSTALL_FULL_CACHEDIR [trafficserver]

2024-01-22 Thread via GitHub
bneradt merged PR #10983: URL: https://github.com/apache/trafficserver/pull/10983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@tra

Re: [PR] Support gRPC traffic [trafficserver]

2024-01-22 Thread via GitHub
kspoelstra-aviatrix commented on PR #9987: URL: https://github.com/apache/trafficserver/pull/9987#issuecomment-1904662364 @maskit , this looks good to me, ran without any issues locally, and we will be keeping an eye on this and testing this a lot more when this lands. -- This is an autom

Re: [PR] Restore IntrusiveHashMap insert code from tscore (ats92) [trafficserver]

2024-01-22 Thread via GitHub
traeak commented on PR #10992: URL: https://github.com/apache/trafficserver/pull/10992#issuecomment-1904287248 [approve ci autest] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com