Re: [PR] Added namespace fmt to function call format_to in Cripts [trafficserver]

2024-02-29 Thread via GitHub
bryancall merged PR #6: URL: https://github.com/apache/trafficserver/pull/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@t

[PR] Added namespace fmt to function call format_to in Cripts [trafficserver]

2024-02-29 Thread via GitHub
bryancall opened a new pull request, #6: URL: https://github.com/apache/trafficserver/pull/6 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] Use EMERGENCY instead of FATAL for some certificate loading errors [trafficserver]

2024-02-29 Thread via GitHub
lzx404243 merged PR #11108: URL: https://github.com/apache/trafficserver/pull/11108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@t

Re: [PR] Change Regex class to use PCRE2 [trafficserver]

2024-02-29 Thread via GitHub
bryancall merged PR #11014: URL: https://github.com/apache/trafficserver/pull/11014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@t

Re: [PR] Change Regex class to use PCRE2 [trafficserver]

2024-02-29 Thread via GitHub
bryancall commented on PR #11014: URL: https://github.com/apache/trafficserver/pull/11014#issuecomment-1971834139 [approve ci] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Change Regex class to use PCRE2 [trafficserver]

2024-02-29 Thread via GitHub
bryancall commented on PR #11014: URL: https://github.com/apache/trafficserver/pull/11014#issuecomment-1971789612 [approve ci autest] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Add libswoc unit tests [trafficserver]

2024-02-29 Thread via GitHub
bneradt merged PR #11106: URL: https://github.com/apache/trafficserver/pull/11106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@tra

Re: [PR] Change Regex class to use PCRE2 [trafficserver]

2024-02-29 Thread via GitHub
bryancall commented on PR #11014: URL: https://github.com/apache/trafficserver/pull/11014#issuecomment-1971788181 [approve ci autest] [approve ci autest] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Change Regex class to use PCRE2 [trafficserver]

2024-02-29 Thread via GitHub
bryancall commented on PR #11014: URL: https://github.com/apache/trafficserver/pull/11014#issuecomment-1971725867 [approve ci autest] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Change Regex class to use PCRE2 [trafficserver]

2024-02-29 Thread via GitHub
bryancall commented on PR #11014: URL: https://github.com/apache/trafficserver/pull/11014#issuecomment-1971708852 [approve ci autest] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Change Regex class to use PCRE2 [trafficserver]

2024-02-29 Thread via GitHub
bryancall commented on PR #11014: URL: https://github.com/apache/trafficserver/pull/11014#issuecomment-1971646574 Rebased the PR. There was a change in `tls_bridge/CMakeLists.txt` that was conflicting. -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] Add libswoc unit tests [trafficserver]

2024-02-29 Thread via GitHub
bneradt commented on PR #11106: URL: https://github.com/apache/trafficserver/pull/11106#issuecomment-1971629422 [approve ci autest] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Improve seen list for the RAM cache [trafficserver]

2024-02-29 Thread via GitHub
zwoop commented on code in PR #10662: URL: https://github.com/apache/trafficserver/pull/10662#discussion_r1507938552 ## src/iocore/cache/RamCacheLRU.cc: ## @@ -47,7 +48,7 @@ struct RamCacheLRU : public RamCache { void init(int64_t max_bytes, Vol *vol) override; // privat

Re: [PR] Improve seen list for the RAM cache [trafficserver]

2024-02-29 Thread via GitHub
zwoop commented on code in PR #10662: URL: https://github.com/apache/trafficserver/pull/10662#discussion_r1507938079 ## src/iocore/cache/RamCacheLRU.cc: ## @@ -84,13 +85,14 @@ RamCacheLRU::size() const ClassAllocator ramCacheLRUEntryAllocator("RamCacheLRUEntry"); -static co

Re: [PR] Improve seen list for the RAM cache [trafficserver]

2024-02-29 Thread via GitHub
zwoop commented on code in PR #10662: URL: https://github.com/apache/trafficserver/pull/10662#discussion_r1506922465 ## src/iocore/cache/RamCacheLRU.cc: ## @@ -107,11 +109,11 @@ RamCacheLRU::resize_hashtable() } bucket = new_bucket; nbuckets = anbuckets; - ats_free(s

Re: [PR] Use EMERGENCY instead of FATAL for some certificate loading errors [trafficserver]

2024-02-29 Thread via GitHub
lzx404243 commented on PR #11108: URL: https://github.com/apache/trafficserver/pull/11108#issuecomment-1971502954 @maskit Do you mind approving this again? Missed an Autest update previously... -- This is an automated message from the Apache Git Service. To respond to the message, please

[PR] Coverity: trying fixing some of the issues related to an unitialized variant member. [trafficserver]

2024-02-29 Thread via GitHub
brbzull0 opened a new pull request, #2: URL: https://github.com/apache/trafficserver/pull/2 Trying to fix some of the following CID issues: 1534738 1534732 1534699 1534727 1534717 not sure if this will work, but let's try. -- This is an automated message f