Re: [PR] Work around a GCC bug for __sync_val_compare_and_swap on ARMv8.1+ [trafficserver]

2024-03-12 Thread via GitHub
ywkaras commented on code in PR #11147: URL: https://github.com/apache/trafficserver/pull/11147#discussion_r1522102776 ## include/tscore/ink_queue.h: ## @@ -57,10 +57,12 @@ void ink_queue_load_64(void *dst, void *src); #define INK_QUEUE_LD64(dst, src) (ink_queue_load_64((void *

Re: [PR] Fix a couple misspellings [trafficserver]

2024-03-12 Thread via GitHub
cmcfarlen commented on PR #11137: URL: https://github.com/apache/trafficserver/pull/11137#issuecomment-1992503807 Cherry-picked to v10.0.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] set CMAKE_HOST for TS_BUILD_CANONICAL_HOST [trafficserver]

2024-03-12 Thread via GitHub
cmcfarlen commented on PR #11154: URL: https://github.com/apache/trafficserver/pull/11154#issuecomment-1992505508 Cherry-picked to v10.0.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] install tsutil files even if tsutil is static [trafficserver]

2024-03-12 Thread via GitHub
cmcfarlen commented on PR #11141: URL: https://github.com/apache/trafficserver/pull/11141#issuecomment-1992504639 Cherry-picked to v10.0.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] CID1534729: txnbox - avoid copying object. [trafficserver]

2024-03-12 Thread via GitHub
cmcfarlen commented on PR #11134: URL: https://github.com/apache/trafficserver/pull/11134#issuecomment-1992502126 Cherry-picked to v10.0.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] CID1534716: use after move on txn_box ip_space module. [trafficserver]

2024-03-12 Thread via GitHub
cmcfarlen commented on PR #11133: URL: https://github.com/apache/trafficserver/pull/11133#issuecomment-1992501505 Cherry-picked to v10.0.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] cmake: Link pcre2 to src/api [trafficserver]

2024-03-12 Thread via GitHub
cmcfarlen commented on PR #11120: URL: https://github.com/apache/trafficserver/pull/11120#issuecomment-1992500426 Cherry-picked to v10.0.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] libsowc - remove legacy Errata. [trafficserver]

2024-03-12 Thread via GitHub
cmcfarlen commented on PR #10986: URL: https://github.com/apache/trafficserver/pull/10986#issuecomment-1992499436 Cherry-picked to v10.0.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] set CMAKE_HOST for TS_BUILD_CANONICAL_HOST [trafficserver]

2024-03-12 Thread via GitHub
cmcfarlen merged PR #11154: URL: https://github.com/apache/trafficserver/pull/11154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@t

Re: [PR] install tsutil files even if tsutil is static [trafficserver]

2024-03-12 Thread via GitHub
cmcfarlen merged PR #11141: URL: https://github.com/apache/trafficserver/pull/11141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@t

Re: [PR] Remove support for session id based session resumption [trafficserver]

2024-03-12 Thread via GitHub
duke8253 closed pull request #11155: Remove support for session id based session resumption URL: https://github.com/apache/trafficserver/pull/11155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Remove support for session id based session resumption [trafficserver]

2024-03-12 Thread via GitHub
duke8253 commented on PR #11155: URL: https://github.com/apache/trafficserver/pull/11155#issuecomment-1992338113 Closing this as discussed, new PR is #11157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[PR] Remove support for session id based session resumption [trafficserver]

2024-03-12 Thread via GitHub
duke8253 opened a new pull request, #11157: URL: https://github.com/apache/trafficserver/pull/11157 As discussed, this change will be going into 11.x instead of 10.x, replacing PR #11155 . As discussed in the email, since session id bases session resumption is barely used anymore (0.

Re: [PR] Remove INKUDPXX api #6245 [trafficserver]

2024-03-12 Thread via GitHub
ywkaras commented on PR #11150: URL: https://github.com/apache/trafficserver/pull/11150#issuecomment-1992058542 We discussed this in today's meeting about the ATS 10 release. It was decided we should simply remove the INKUDPxxx function and types in release 10. I think we should note the

[PR] txn_box - Fix ASAN issue on txn_box string trie. [trafficserver]

2024-03-12 Thread via GitHub
brbzull0 opened a new pull request, #11156: URL: https://github.com/apache/trafficserver/pull/11156 Use `swoc::MemArena` instead of manual allocation. Beside the benefits of using the arena this change helps to mitigate a leak that was found while building with ASAN. The issue was on d

Re: [PR] libsowc - remove legacy Errata. [trafficserver]

2024-03-12 Thread via GitHub
brbzull0 merged PR #10986: URL: https://github.com/apache/trafficserver/pull/10986 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@tr

Re: [PR] libsowc - remove legacy Errata. [trafficserver]

2024-03-12 Thread via GitHub
brbzull0 commented on PR #10986: URL: https://github.com/apache/trafficserver/pull/10986#issuecomment-1991150718 > I guess we don't need the tests in test_Errata.cc anymore as these are covered by swoc? Yup. Thanks Chris -- This is an automated message from the Apache Git Servic

Re: [PR] CID1534716: use after move on txn_box ip_space module. [trafficserver]

2024-03-12 Thread via GitHub
brbzull0 merged PR #11133: URL: https://github.com/apache/trafficserver/pull/11133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@tr

Re: [PR] CID1534729: txnbox - avoid copying object. [trafficserver]

2024-03-12 Thread via GitHub
brbzull0 merged PR #11134: URL: https://github.com/apache/trafficserver/pull/11134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@tr