Re: [PR] Fix a build issue with autest plugins [trafficserver]

2024-03-25 Thread via GitHub
moonchen commented on PR #11165: URL: https://github.com/apache/trafficserver/pull/11165#issuecomment-2019108977 [approve ci autest] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Remove symbols with prefix INKUDP from plugin API. [trafficserver]

2024-03-25 Thread via GitHub
ywkaras merged PR #11171: URL: https://github.com/apache/trafficserver/pull/11171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@tra

Re: [PR] RegexContext instance created in the heap for each thread is leaked. [trafficserver]

2024-03-25 Thread via GitHub
ywkaras commented on PR #11164: URL: https://github.com/apache/trafficserver/pull/11164#issuecomment-2019010895 Replaced by https://github.com/apache/trafficserver/pull/11184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] RegexContext instance created in the heap for each thread is leaked. [trafficserver]

2024-03-25 Thread via GitHub
ywkaras closed pull request #11164: RegexContext instance created in the heap for each thread is leaked. URL: https://github.com/apache/trafficserver/pull/11164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Fixed asan leak issues with RegexContext [trafficserver]

2024-03-25 Thread via GitHub
ywkaras commented on PR #11184: URL: https://github.com/apache/trafficserver/pull/11184#issuecomment-2019009146 If you don't copy in these comments, https://github.com/apache/trafficserver/pull/11164/files#diff-8b89b132c9c9eb8fa6f58b050dd7bd3c47d55fd217d00239f4e13e21b270d679R161 , somebody

Re: [PR] Fixed asan leak issues with RegexContext [trafficserver]

2024-03-25 Thread via GitHub
moonchen commented on code in PR #11184: URL: https://github.com/apache/trafficserver/pull/11184#discussion_r1538295363 ## src/tsutil/Regex.cc: ## @@ -105,12 +120,20 @@ class RegexContext thread_local RegexContext *RegexContext::_regex_context = nullptr; //--

Re: [PR] magick.so: explicitly reference wand/core libraries [trafficserver]

2024-03-25 Thread via GitHub
cmcfarlen commented on code in PR #11183: URL: https://github.com/apache/trafficserver/pull/11183#discussion_r1538289837 ## plugins/experimental/magick/CMakeLists.txt: ## @@ -16,6 +16,11 @@ ### add_atsplugin(magick magick.cc) -target_link_libraries(magick

[PR] Fixed asan leak issues with RegexContext [trafficserver]

2024-03-25 Thread via GitHub
bryancall opened a new pull request, #11184: URL: https://github.com/apache/trafficserver/pull/11184 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] magick.so: explicitly reference wand/core libraries [trafficserver]

2024-03-25 Thread via GitHub
bneradt commented on PR #11183: URL: https://github.com/apache/trafficserver/pull/11183#issuecomment-2018964828 [approve ci autest] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Fix external yaml-cpp builds [trafficserver]

2024-03-25 Thread via GitHub
cmcfarlen commented on PR #11182: URL: https://github.com/apache/trafficserver/pull/11182#issuecomment-2018768393 Cherry-picked to v10.0.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Fix external libswoc builds [trafficserver]

2024-03-25 Thread via GitHub
cmcfarlen commented on PR #11179: URL: https://github.com/apache/trafficserver/pull/11179#issuecomment-2018767082 Cherry-picked to v10.0.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Version update: libswoc 1.5.11 [trafficserver]

2024-03-25 Thread via GitHub
cmcfarlen commented on PR #11177: URL: https://github.com/apache/trafficserver/pull/11177#issuecomment-2018765568 Cherry-picked to v10.0.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] SSL Diags - Use boringssl API to fetch a proper error description. [trafficserver]

2024-03-25 Thread via GitHub
cmcfarlen commented on PR #11176: URL: https://github.com/apache/trafficserver/pull/11176#issuecomment-2018763602 Cherry-picked to v10.0.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Update HTTP3 test to use hostname instead of numeric address. [trafficserver]

2024-03-25 Thread via GitHub
cmcfarlen commented on PR #11175: URL: https://github.com/apache/trafficserver/pull/11175#issuecomment-2018761386 Cherry-picked to v10.0.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] H3 deps build script update. [trafficserver]

2024-03-25 Thread via GitHub
cmcfarlen commented on PR #11174: URL: https://github.com/apache/trafficserver/pull/11174#issuecomment-2018759695 Cherry-picked to v10.0.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Work around a GCC bug for __sync_val_compare_and_swap on ARMv8.1+ [trafficserver]

2024-03-25 Thread via GitHub
cmcfarlen commented on PR #11147: URL: https://github.com/apache/trafficserver/pull/11147#issuecomment-2018756394 Cherry-picked to v10.0.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[PR] magick.so: explicitly reference wand/core libraries [trafficserver]

2024-03-25 Thread via GitHub
traeak opened a new pull request, #11183: URL: https://github.com/apache/trafficserver/pull/11183 Fixes the magick plugin linking for gcc ubuntu 20.04 and debian 11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Fix external yaml-cpp builds [trafficserver]

2024-03-25 Thread via GitHub
bneradt merged PR #11182: URL: https://github.com/apache/trafficserver/pull/11182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@tra

Re: [PR] Fix external yaml-cpp builds [trafficserver]

2024-03-25 Thread via GitHub
bneradt commented on PR #11182: URL: https://github.com/apache/trafficserver/pull/11182#issuecomment-2018494609 [approve ci rocky] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] PR rocky: use /opt/yaml-cpp and /opt/libswoc [trafficserver-ci]

2024-03-25 Thread via GitHub
bneradt merged PR #330: URL: https://github.com/apache/trafficserver-ci/pull/330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@traf

[PR] PR rocky: use /opt/yaml-cpp and /opt/libswoc [trafficserver-ci]

2024-03-25 Thread via GitHub
bneradt opened a new pull request, #330: URL: https://github.com/apache/trafficserver-ci/pull/330 Now that yaml-cpp and libswoc are installed in /opt in the rocky images, use those install dirs instead of building each of these for each build. -- This is an automated message from the Apac

[PR] Add yaml-cpp and libswoc installs to rockylinux:[8,9] [trafficserver-ci]

2024-03-25 Thread via GitHub
bneradt opened a new pull request, #329: URL: https://github.com/apache/trafficserver-ci/pull/329 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] Add yaml-cpp and libswoc installs to rockylinux:[8,9] [trafficserver-ci]

2024-03-25 Thread via GitHub
bneradt merged PR #329: URL: https://github.com/apache/trafficserver-ci/pull/329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@traf

Re: [PR] Fixes for SRV records handling in hostdb rewrite [trafficserver]

2024-03-25 Thread via GitHub
cmcfarlen commented on code in PR #11180: URL: https://github.com/apache/trafficserver/pull/11180#discussion_r1537776152 ## src/iocore/hostdb/HostDBInfo.cc: ## @@ -73,7 +73,7 @@ HostDBInfo::assign(SRV const *srv, char const *name) -> self_type & data.srv.srv_priority = srv->