Re: [PR] Fixed asan issue with global SSLAPIHooks not being deleted on shutdown [trafficserver]

2024-03-28 Thread via GitHub
JosiahWI commented on PR #11142: URL: https://github.com/apache/trafficserver/pull/11142#issuecomment-2026419954 If `init_global_ssl_hooks()` was called multiple times without the null check, that would probably leak memory. -- This is an automated message from the Apache Git Service. To

Re: [PR] http2: change stream state to closed from open if END_STREAM is sent and received [trafficserver]

2024-03-28 Thread via GitHub
masaori335 merged PR #11188: URL: https://github.com/apache/trafficserver/pull/11188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] Fixed asan issue with global SSLAPIHooks not being deleted on shutdown [trafficserver]

2024-03-28 Thread via GitHub
bryancall commented on PR #11142: URL: https://github.com/apache/trafficserver/pull/11142#issuecomment-2026189307 > Was the root problem the multiple allocations of `g_ssl_hooks` overwriting the old ones and leaking them? The problem was with deleting `g_ssl_hooks` on shutdown.

Re: [PR] Bump express from 4.18.2 to 4.19.2 in /k8s/images/node-app-2 [trafficserver-ingress-controller]

2024-03-28 Thread via GitHub
shukitchan merged PR #207: URL: https://github.com/apache/trafficserver-ingress-controller/pull/207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gith

Re: [PR] Bump express from 4.18.2 to 4.19.2 in /k8s/images/node-app-1 [trafficserver-ingress-controller]

2024-03-28 Thread via GitHub
shukitchan merged PR #208: URL: https://github.com/apache/trafficserver-ingress-controller/pull/208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gith

Re: [PR] Fixed asan issue with global SSLAPIHooks not being deleted on shutdown [trafficserver]

2024-03-28 Thread via GitHub
bneradt commented on PR #11142: URL: https://github.com/apache/trafficserver/pull/11142#issuecomment-2025999815 @JosiahWI and I have talked about this leaked resource in the past. Note that this comment, and another related global hook, has had this comment forever in the corresponding head

Re: [PR] Fixed asan issue with global SSLAPIHooks not being deleted on shutdown [trafficserver]

2024-03-28 Thread via GitHub
JosiahWI commented on PR #11142: URL: https://github.com/apache/trafficserver/pull/11142#issuecomment-2025865623 Was the root problem the multiple allocations of `g_ssl_hooks` overwriting the old ones and leaking them? -- This is an automated message from the Apache Git Service. To respon

Re: [PR] Fixed asan issue with global SSLAPIHooks not being deleted on shutdown [trafficserver]

2024-03-28 Thread via GitHub
JosiahWI commented on PR #11142: URL: https://github.com/apache/trafficserver/pull/11142#issuecomment-2025866175 [approve ci autest] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] This adds support for NOCASE on string compare / regex [trafficserver]

2024-03-28 Thread via GitHub
zwoop merged PR #11152: URL: https://github.com/apache/trafficserver/pull/11152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@traff

[PR] Don't delete QUIC stream until both read and write complete [trafficserver]

2024-03-28 Thread via GitHub
maskit opened a new pull request, #11196: URL: https://github.com/apache/trafficserver/pull/11196 This is for #11170. Looks like it happens when write_compete happens before read_complete, and there was a FIXME comment about it. This PR fixes it. -- This is an automated message fro

Re: [PR] Test PR for an asan fix - don't merge [trafficserver]

2024-03-28 Thread via GitHub
bryancall closed pull request #11194: Test PR for an asan fix - don't merge URL: https://github.com/apache/trafficserver/pull/11194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Fix HTTP/2 Buffering Issues [trafficserver]

2024-03-28 Thread via GitHub
bneradt commented on PR #11143: URL: https://github.com/apache/trafficserver/pull/11143#issuecomment-2025764366 [approve ci fedora] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] swoc: install swoc_ip_util.h [trafficserver]

2024-03-28 Thread via GitHub
bneradt merged PR #11190: URL: https://github.com/apache/trafficserver/pull/11190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@tra

Re: [PR] fedora build to use 40 [trafficserver-ci]

2024-03-28 Thread via GitHub
bneradt merged PR #336: URL: https://github.com/apache/trafficserver-ci/pull/336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@traf

Re: [PR] CMakePresets: branch-quiche: use boringssl nuraft [trafficserver]

2024-03-28 Thread via GitHub
bneradt merged PR #11195: URL: https://github.com/apache/trafficserver/pull/11195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@tra

[PR] fedora build to use 40 [trafficserver-ci]

2024-03-28 Thread via GitHub
bneradt opened a new pull request, #336: URL: https://github.com/apache/trafficserver-ci/pull/336 The autest build has at least v6 resolution issues which I hope will get resolved as fedora hardens up and comes out of beta. But for now we can at least use the updated compiler from fedora:40

Re: [PR] Fixed asan leak issues with RegexContext [trafficserver]

2024-03-28 Thread via GitHub
ywkaras commented on PR #11184: URL: https://github.com/apache/trafficserver/pull/11184#issuecomment-2025748983 Unfortunately, there is a race condition, if an object with static storage uses a DbgCtl object for the first time in its destructor. (That requires checking if its tag matches t

[PR] Bump express from 4.18.2 to 4.19.2 in /k8s/images/node-app-1 [trafficserver-ingress-controller]

2024-03-28 Thread via GitHub
dependabot[bot] opened a new pull request, #208: URL: https://github.com/apache/trafficserver-ingress-controller/pull/208 Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2. Release notes Sourced from https://github.com/expressjs/express/releases";>express's

[PR] Bump express from 4.18.2 to 4.19.2 in /k8s/images/node-app-2 [trafficserver-ingress-controller]

2024-03-28 Thread via GitHub
dependabot[bot] opened a new pull request, #207: URL: https://github.com/apache/trafficserver-ingress-controller/pull/207 Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2. Release notes Sourced from https://github.com/expressjs/express/releases";>express's

Re: [PR] Fixed asan leak issues with RegexContext [trafficserver]

2024-03-28 Thread via GitHub
bryancall commented on code in PR #11184: URL: https://github.com/apache/trafficserver/pull/11184#discussion_r1543348242 ## src/tsutil/Regex.cc: ## @@ -105,12 +120,20 @@ class RegexContext thread_local RegexContext *RegexContext::_regex_context = nullptr; //-

Re: [PR] boringssl nuraft [trafficserver-ci]

2024-03-28 Thread via GitHub
bneradt merged PR #335: URL: https://github.com/apache/trafficserver-ci/pull/335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@traf

[PR] boringssl nuraft [trafficserver-ci]

2024-03-28 Thread via GitHub
bneradt opened a new pull request, #335: URL: https://github.com/apache/trafficserver-ci/pull/335 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib