[PR] http2: Set SSN active on create_stream [trafficserver]

2024-04-03 Thread via GitHub
masaori335 opened a new pull request, #11210: URL: https://github.com/apache/trafficserver/pull/11210 Prior to the change, if a HTTP/2 stream is open on a session, but it doesn't make new transaction by some reason, the inactivity timeout of the connection never get fired. Current A

[PR] http2: close stream on sending RST_STREAM [trafficserver]

2024-04-03 Thread via GitHub
masaori335 opened a new pull request, #11209: URL: https://github.com/apache/trafficserver/pull/11209 When ATS receives HTTP/2 frame, sometimes stream error happens - e.g. malformed request. In such case, ATS sends RST_STREAM frame and make the stream state closed, but the stream is still i

Re: [PR] Clean up some of Cripts strings with modern libSWOC [trafficserver]

2024-04-03 Thread via GitHub
ywkaras commented on PR #11208: URL: https://github.com/apache/trafficserver/pull/11208#issuecomment-2035805249 [approve ci autest] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Clean up some of Cripts strings with modern libSWOC [trafficserver]

2024-04-03 Thread via GitHub
ywkaras commented on code in PR #11208: URL: https://github.com/apache/trafficserver/pull/11208#discussion_r1550640184 ## include/cripts/Lulu.hpp: ## @@ -74,7 +74,6 @@ template class StringViewMixin Review Comment: The short rule of thumb (since C++17) is, `f(T v)` and `f

Re: [PR] Clean up some of Cripts strings with modern libSWOC [trafficserver]

2024-04-03 Thread via GitHub
zwoop commented on code in PR #11208: URL: https://github.com/apache/trafficserver/pull/11208#discussion_r1550600833 ## include/cripts/Lulu.hpp: ## @@ -74,7 +74,6 @@ template class StringViewMixin Review Comment: Probably. Alan kinda convinced me that these gets optimized

Re: [PR] Fix HTTP/2 Buffering Issues [trafficserver]

2024-04-03 Thread via GitHub
bneradt merged PR #11143: URL: https://github.com/apache/trafficserver/pull/11143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@tra

Re: [PR] Fix HTTP/2 Buffering Issues [trafficserver]

2024-04-03 Thread via GitHub
bneradt commented on PR #11143: URL: https://github.com/apache/trafficserver/pull/11143#issuecomment-2035581847 Thank you @maskit and @moonchen for the thoughtful review comments and feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] Clean up some of Cripts strings with modern libSWOC [trafficserver]

2024-04-03 Thread via GitHub
ywkaras commented on code in PR #11208: URL: https://github.com/apache/trafficserver/pull/11208#discussion_r1550401765 ## include/cripts/Lulu.hpp: ## @@ -74,7 +74,6 @@ template class StringViewMixin Review Comment: Seems like this should be: ``` constexpr StringView

Re: [PR] Clean up some of Cripts strings with modern libSWOC [trafficserver]

2024-04-03 Thread via GitHub
zwoop commented on PR #11208: URL: https://github.com/apache/trafficserver/pull/11208#issuecomment-2035435814 [approve ci autest] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Fix HTTP/2 Buffering Issues [trafficserver]

2024-04-03 Thread via GitHub
bneradt commented on PR #11143: URL: https://github.com/apache/trafficserver/pull/11143#issuecomment-2035347643 [approve ci autest] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Clean up some of Cripts strings with modern libSWOC [trafficserver]

2024-04-03 Thread via GitHub
zwoop commented on PR #11208: URL: https://github.com/apache/trafficserver/pull/11208#issuecomment-2035264630 [approve ci autest] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Don't send "None" as a server name [trafficserver]

2024-04-03 Thread via GitHub
maskit merged PR #11204: URL: https://github.com/apache/trafficserver/pull/11204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@traf

Re: [PR] Add proxy.config.http2.max_continuation_frames_per_minute [trafficserver]

2024-04-03 Thread via GitHub
maskit merged PR #11205: URL: https://github.com/apache/trafficserver/pull/11205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@traf

Re: [PR] Add proxy.config.http2.max_continuation_frames_per_minute [trafficserver]

2024-04-03 Thread via GitHub
ezelkow1 merged PR #11207: URL: https://github.com/apache/trafficserver/pull/11207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@tr

Re: [PR] Add proxy.config.http2.max_continuation_frames_per_minute [trafficserver]

2024-04-03 Thread via GitHub
bryancall merged PR #11206: URL: https://github.com/apache/trafficserver/pull/11206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@t

[PR] Add proxy.config.http2.max_continuation_frames_per_minute [trafficserver]

2024-04-03 Thread via GitHub
maskit opened a new pull request, #11207: URL: https://github.com/apache/trafficserver/pull/11207 This adds the ability to rate limite HTTP/2 CONTINUATION frames per stream per minute. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[PR] Add proxy.config.http2.max_continuation_frames_per_minute [trafficserver]

2024-04-03 Thread via GitHub
maskit opened a new pull request, #11206: URL: https://github.com/apache/trafficserver/pull/11206 This adds the ability to rate limite HTTP/2 CONTINUATION frames per stream per minute. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] Add proxy.config.http2.max_continuation_frames_per_minute [trafficserver]

2024-04-03 Thread via GitHub
maskit opened a new pull request, #11205: URL: https://github.com/apache/trafficserver/pull/11205 This adds the ability to rate limite HTTP/2 CONTINUATION frames per stream per minute. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Add default toolchain file and adjust RelWithDebInfo flags [trafficserver]

2024-04-03 Thread via GitHub
cmcfarlen closed pull request #11198: Add default toolchain file and adjust RelWithDebInfo flags URL: https://github.com/apache/trafficserver/pull/11198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] ja3_fingerprint: Add condition to run test only if the plugin was built. [trafficserver]

2024-04-03 Thread via GitHub
brbzull0 merged PR #11202: URL: https://github.com/apache/trafficserver/pull/11202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@tr