masaori335 commented on PR #11354:
URL: https://github.com/apache/trafficserver/pull/11354#issuecomment-2126341913
Adding AuTest looks good idea, but let me do that in another PR later.
Because we need to have a special client or extend proxy-verifier. ( I have a
client to test this code bu
freak82 commented on PR #11382:
URL: https://github.com/apache/trafficserver/pull/11382#issuecomment-2126298815
Updated the pull request.
Overall the situation with this "maybe-negative-length" pattern is a bit
confusing (at least for me).
I mean, if there this usage:
```
voi
zwoop merged PR #11379:
URL: https://github.com/apache/trafficserver/pull/11379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@traff
bneradt commented on PR #11384:
URL: https://github.com/apache/trafficserver/pull/11384#issuecomment-2126077121
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
github-actions[bot] closed pull request #11010: Add storage.yaml
URL: https://github.com/apache/trafficserver/pull/11010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
github-actions[bot] closed pull request #11000: Doc: storage.yaml
URL: https://github.com/apache/trafficserver/pull/11000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
bneradt commented on PR #11384:
URL: https://github.com/apache/trafficserver/pull/11384#issuecomment-2126010520
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
ywkaras commented on PR #11382:
URL: https://github.com/apache/trafficserver/pull/11382#issuecomment-2125996214
Masakazu prefers `TSHttpTxnServerPush` support negative URL length by
calling `strlen` on the URL pointer if the length is negative.
--
This is an automated message from the Apa
zwoop commented on PR #11384:
URL: https://github.com/apache/trafficserver/pull/11384#issuecomment-2125975877
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
bryancall commented on PR #11387:
URL: https://github.com/apache/trafficserver/pull/11387#issuecomment-2125947928
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
zwoop commented on PR #11384:
URL: https://github.com/apache/trafficserver/pull/11384#issuecomment-2125925110
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
zwoop commented on PR #11384:
URL: https://github.com/apache/trafficserver/pull/11384#issuecomment-2125924743
[approve ci rocky]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
bryancall commented on PR #11387:
URL: https://github.com/apache/trafficserver/pull/11387#issuecomment-2125917093
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
zwoop commented on PR #11384:
URL: https://github.com/apache/trafficserver/pull/11384#issuecomment-2125908157
[approve ci rocky]
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
bryancall merged PR #11386:
URL: https://github.com/apache/trafficserver/pull/11386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@t
bryancall merged PR #11385:
URL: https://github.com/apache/trafficserver/pull/11385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@t
bryancall commented on PR #11387:
URL: https://github.com/apache/trafficserver/pull/11387#issuecomment-2125797749
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
bryancall commented on code in PR #11386:
URL: https://github.com/apache/trafficserver/pull/11386#discussion_r1610491526
##
plugins/header_rewrite/header_rewrite.cc:
##
@@ -199,23 +199,22 @@ RulesConfig::parse_config(const std::string &fname,
TSHttpHookID default_hook, c
}
bryancall commented on PR #11386:
URL: https://github.com/apache/trafficserver/pull/11386#issuecomment-2125524903
[approve ci centos]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
maskit commented on code in PR #11386:
URL: https://github.com/apache/trafficserver/pull/11386#discussion_r1610474974
##
plugins/header_rewrite/header_rewrite.cc:
##
@@ -199,23 +199,22 @@ RulesConfig::parse_config(const std::string &fname,
TSHttpHookID default_hook, c
}
bryancall opened a new pull request, #11386:
URL: https://github.com/apache/trafficserver/pull/11386
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
zwoop commented on code in PR #11384:
URL: https://github.com/apache/trafficserver/pull/11384#discussion_r1610415805
##
doc/admin-guide/plugins/header_rewrite.en.rst:
##
@@ -775,6 +775,14 @@ changing the remapped destination, should be
used to indicate the
component that
zwoop commented on code in PR #11384:
URL: https://github.com/apache/trafficserver/pull/11384#discussion_r1610415805
##
doc/admin-guide/plugins/header_rewrite.en.rst:
##
@@ -775,6 +775,14 @@ changing the remapped destination, should be
used to indicate the
component that
zwoop commented on code in PR #11384:
URL: https://github.com/apache/trafficserver/pull/11384#discussion_r1610415315
##
doc/admin-guide/plugins/header_rewrite.en.rst:
##
@@ -1333,6 +1342,11 @@ The following ruleset removes any query parameters set
by the client.::
cond %{RE
bryancall merged PR #11362:
URL: https://github.com/apache/trafficserver/pull/11362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@t
bryancall merged PR #11383:
URL: https://github.com/apache/trafficserver/pull/11383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@t
bryancall opened a new pull request, #11385:
URL: https://github.com/apache/trafficserver/pull/11385
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
shukitchan commented on code in PR #11384:
URL: https://github.com/apache/trafficserver/pull/11384#discussion_r1610364625
##
doc/admin-guide/plugins/header_rewrite.en.rst:
##
@@ -775,6 +775,14 @@ changing the remapped destination, should be
used to indicate the
component
shukitchan commented on code in PR #11384:
URL: https://github.com/apache/trafficserver/pull/11384#discussion_r1610364625
##
doc/admin-guide/plugins/header_rewrite.en.rst:
##
@@ -775,6 +775,14 @@ changing the remapped destination, should be
used to indicate the
component
mlibbey commented on code in PR #11384:
URL: https://github.com/apache/trafficserver/pull/11384#discussion_r1610363375
##
doc/admin-guide/plugins/header_rewrite.en.rst:
##
@@ -1333,6 +1342,11 @@ The following ruleset removes any query parameters set
by the client.::
cond %{
ywkaras commented on PR #11382:
URL: https://github.com/apache/trafficserver/pull/11382#issuecomment-2125260560
I'm not sure what the consensus is about this. I asked in the slack
channel: https://the-asf.slack.com/archives/CHQ1FJ9EG/p1716395850701069
--
This is an automated message fro
bryancall commented on PR #11383:
URL: https://github.com/apache/trafficserver/pull/11383#issuecomment-2125259192
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
zwoop commented on PR #11384:
URL: https://github.com/apache/trafficserver/pull/11384#issuecomment-2125197917
I'm adding this to Project 10.0.x, but I think this would be fine to go into
v10.1.0 as well.
--
This is an automated message from the Apache Git Service.
To respond to the messag
zwoop opened a new pull request, #11384:
URL: https://github.com/apache/trafficserver/pull/11384
This also adds the [I] / [INV] modifier to operators, where the logic should
be INVerted. In this case, inverted means "remove all *but* the listed query
parameters".
--
This is an automated
freak82 commented on PR #11382:
URL: https://github.com/apache/trafficserver/pull/11382#issuecomment-2125104401
My bad. I'm not very accustomed to this pattern yet.
Do you think I should add the `sdk_assert` in `TSHttpTxnServerPush` or I
should add the check with the `if (len < 0) len = s
bryancall commented on code in PR #11383:
URL: https://github.com/apache/trafficserver/pull/11383#discussion_r1610220328
##
plugins/background_fetch/headers.cc:
##
@@ -97,19 +97,15 @@ set_header(TSMBuffer bufp, TSMLoc hdr_loc, const char
*header, int len, const ch
void
dump_h
bryancall opened a new pull request, #11383:
URL: https://github.com/apache/trafficserver/pull/11383
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
zwoop merged PR #11352:
URL: https://github.com/apache/trafficserver/pull/11352
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@traff
shukitchan merged PR #228:
URL: https://github.com/apache/trafficserver-ingress-controller/pull/228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gith
ywkaras commented on PR #11382:
URL: https://github.com/apache/trafficserver/pull/11382#issuecomment-2124912526
Good find! It looks like `add_url_to_pushed_table` is only used in
`TSHttpTxnServerPush` (in `src/api/InkAPI.cc`). As a part of this PR, I
suggest you add `sdk_assert(url && url
freak82 opened a new pull request, #11382:
URL: https://github.com/apache/trafficserver/pull/11382
The signature of the function in question is
```
void
Http2CommonSession::add_url_to_pushed_table(const char *url, int url_len)
```
The given `url` is used when emplacing/insertin
41 matches
Mail list logo
