[PR] Some cleanup of error handling in statichit plugin. [trafficserver]

ywkaras opened a new pull request, #11404: URL: https://github.com/apache/trafficserver/pull/11404 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] Doc: storage.yaml [trafficserver]

github-actions[bot] closed pull request #11000: Doc: storage.yaml URL: https://github.com/apache/trafficserver/pull/11000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] Add storage.yaml [trafficserver]

github-actions[bot] closed pull request #11010: Add storage.yaml URL: https://github.com/apache/trafficserver/pull/11010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] HRW: Adds an optional list of query params to remove/keep [trafficserver]

shukitchan commented on PR #11384: URL: https://github.com/apache/trafficserver/pull/11384#issuecomment-2140929418 [approve ci autest] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] XPACK: update_maximum_size for storage [trafficserver]

bneradt merged PR #11396: URL: https://github.com/apache/trafficserver/pull/11396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@tra

Re: [PR] Fixes Bundles errors, and better checks [trafficserver]

zwoop commented on PR #11398: URL: https://github.com/apache/trafficserver/pull/11398#issuecomment-2140688352 [approve ci autest] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Add ts::hex and ts::unhex [trafficserver]

cmcfarlen merged PR #11392: URL: https://github.com/apache/trafficserver/pull/11392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@t

Re: [PR] Fixes Bundles errors, and better checks [trafficserver]

JosiahWI commented on code in PR #11398: URL: https://github.com/apache/trafficserver/pull/11398#discussion_r1621061925 ## src/cripts/CMakeLists.txt: ## @@ -45,8 +45,10 @@ set(CRIPTS_PUBLIC_HEADERS ${PROJECT_SOURCE_DIR}/include/cripts/Urls.hpp ${PROJECT_SOURCE_DIR}/inc

Re: [PR] Add Sphinx documentation for statichit plugin. [trafficserver]

ywkaras commented on PR #11389: URL: https://github.com/apache/trafficserver/pull/11389#issuecomment-2140121905 This is purely a documentation and testing enhancement. Backports are desirable but not crucial. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Fix race conditions in Regex.cc. [trafficserver]

ywkaras commented on PR #11399: URL: https://github.com/apache/trafficserver/pull/11399#issuecomment-2139984971 This is where the segment violation is occurring in Yahoo Prod: https://github.com/apache/trafficserver/blob/5f52c374dfcc3dc223a7c23bd885bac64ec2398f/src/tsutil/Regex.cc#L114 --

Re: [PR] Add Sphinx documentation for statichit plugin. [trafficserver]

ywkaras commented on PR #11389: URL: https://github.com/apache/trafficserver/pull/11389#issuecomment-2139962407 [approve ci autest] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Fix race conditions in Regex.cc. [trafficserver]

ywkaras commented on PR #11399: URL: https://github.com/apache/trafficserver/pull/11399#issuecomment-2139954860 > Should this be added to 10.0.x project as well for cherry-pick? Debatable. Any crashes would happen at shutdown, and seem infrequent (with limited testing in Yahoo Prod).

Re: [PR] Fixes Bundles errors, and better checks [trafficserver]

zwoop commented on code in PR #11398: URL: https://github.com/apache/trafficserver/pull/11398#discussion_r1620958459 ## src/cripts/CMakeLists.txt: ## @@ -45,8 +45,10 @@ set(CRIPTS_PUBLIC_HEADERS ${PROJECT_SOURCE_DIR}/include/cripts/Urls.hpp ${PROJECT_SOURCE_DIR}/includ

Re: [PR] Fixes Bundles errors, and better checks [trafficserver]

zwoop commented on code in PR #11398: URL: https://github.com/apache/trafficserver/pull/11398#discussion_r1620956371 ## src/cripts/CMakeLists.txt: ## @@ -64,6 +66,9 @@ set_target_properties( install(TARGETS cripts PUBLIC_HEADER DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/cripts)

Re: [PR] Fix race conditions in Regex.cc. [trafficserver]

cmcfarlen commented on PR #11399: URL: https://github.com/apache/trafficserver/pull/11399#issuecomment-2139868663 Should this be added to 10.0.x project as well for cherry-pick? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Coverity 1517812: COPY_INSTEAD_OF_MOVE [trafficserver]

bryancall merged PR #11361: URL: https://github.com/apache/trafficserver/pull/11361 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@t

[PR] Fix unused parameters in the tscpp source code [trafficserver]

freak82 opened a new pull request, #11402: URL: https://github.com/apache/trafficserver/pull/11402 This is related to the discussion [here](https://github.com/apache/trafficserver/issues/11377) -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Fixes Bundles errors, and better checks [trafficserver]

JosiahWI commented on code in PR #11398: URL: https://github.com/apache/trafficserver/pull/11398#discussion_r1620681144 ## src/cripts/CMakeLists.txt: ## @@ -45,8 +45,10 @@ set(CRIPTS_PUBLIC_HEADERS ${PROJECT_SOURCE_DIR}/include/cripts/Urls.hpp ${PROJECT_SOURCE_DIR}/inc

Re: [PR] Add tests for writing documents to the cache [trafficserver]

JosiahWI merged PR #11347: URL: https://github.com/apache/trafficserver/pull/11347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@tr

Re: [PR] Fix unused parameters in `tsutil` [trafficserver]

brbzull0 merged PR #11394: URL: https://github.com/apache/trafficserver/pull/11394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@tr