Re: [PR] Fix for OpenSSL 3.2+. [trafficserver]

ywkaras commented on PR #11501: URL: https://github.com/apache/trafficserver/pull/11501#issuecomment-2207876730 [approve ci autest] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Lowercase the headers appended by ja3_fingerprint [trafficserver]

JosiahWI merged PR #11504: URL: https://github.com/apache/trafficserver/pull/11504 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@tr

[PR] Fix quick_server autest to verify server response [trafficserver]

bneradt opened a new pull request, #11512: URL: https://github.com/apache/trafficserver/pull/11512 The quick_server.test.py autest incorrectly sent a literal '\r\n' four bytes instead of the expected 2 bytes. The test still largely functioned as needed, but didn't verify that the expected r

Re: [PR] Prioritize the library path for SSL library [trafficserver]

maskit merged PR #11511: URL: https://github.com/apache/trafficserver/pull/11511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@traf

Re: [PR] Promote write_bytes and gc_frags_evacuated metrics [trafficserver]

JosiahWI merged PR #11510: URL: https://github.com/apache/trafficserver/pull/11510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@tr

Re: [PR] Prioritize the library path for SSL library [trafficserver]

maskit commented on code in PR #11511: URL: https://github.com/apache/trafficserver/pull/11511#discussion_r1664600790 ## src/api/CMakeLists.txt: ## @@ -23,7 +23,7 @@ set(TSAPI_PUBLIC_HEADERS ${PROJECT_SOURCE_DIR}/include/ts/ts.h ${PROJECT_SOURCE_ ${PRO

Re: [PR] Prioritize the library path for SSL library [trafficserver]

JosiahWI commented on PR #11511: URL: https://github.com/apache/trafficserver/pull/11511#issuecomment-2206893426 What if we create our own PCRE target that depends on OpenSSL? Would that ensure the link order is correct everywhere? -- This is an automated message from the Apache Git Servi

Re: [PR] Prioritize the library path for SSL library [trafficserver]

JosiahWI commented on code in PR #11511: URL: https://github.com/apache/trafficserver/pull/11511#discussion_r1664553337 ## src/api/CMakeLists.txt: ## @@ -23,7 +23,7 @@ set(TSAPI_PUBLIC_HEADERS ${PROJECT_SOURCE_DIR}/include/ts/ts.h ${PROJECT_SOURCE_ ${P

Re: [PR] Prioritize the library path for SSL library [trafficserver]

JosiahWI commented on code in PR #11511: URL: https://github.com/apache/trafficserver/pull/11511#discussion_r1664552520 ## src/api/CMakeLists.txt: ## @@ -23,7 +23,7 @@ set(TSAPI_PUBLIC_HEADERS ${PROJECT_SOURCE_DIR}/include/ts/ts.h ${PROJECT_SOURCE_ ${P

Re: [PR] Prioritize the library path for SSL library [trafficserver]

maskit commented on code in PR #11511: URL: https://github.com/apache/trafficserver/pull/11511#discussion_r1664542163 ## src/api/CMakeLists.txt: ## @@ -23,7 +23,7 @@ set(TSAPI_PUBLIC_HEADERS ${PROJECT_SOURCE_DIR}/include/ts/ts.h ${PROJECT_SOURCE_ ${PRO

Re: [PR] Prioritize the library path for SSL library [trafficserver]

JosiahWI commented on code in PR #11511: URL: https://github.com/apache/trafficserver/pull/11511#discussion_r1664501847 ## src/api/CMakeLists.txt: ## @@ -23,7 +23,7 @@ set(TSAPI_PUBLIC_HEADERS ${PROJECT_SOURCE_DIR}/include/ts/ts.h ${PROJECT_SOURCE_ ${P

[PR] Promote write_bytes and gc_frags_evacuated metrics [trafficserver]

JosiahWI opened a new pull request, #11510: URL: https://github.com/apache/trafficserver/pull/11510 These metrics will now show up in release builds. As these were the only metrics that are debug-only, everything will now be more consistent and mistakes and unexpected behavior will be less

Re: [PR] Fix incorrect metric for agg_copy bytes written [trafficserver]

JosiahWI merged PR #11508: URL: https://github.com/apache/trafficserver/pull/11508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@tr

Re: [PR] H3: Make sure we remove streams when needed. [trafficserver]

brbzull0 merged PR #11490: URL: https://github.com/apache/trafficserver/pull/11490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@tr

Re: [PR] Fix incorrect metric for agg_copy bytes written [trafficserver]

JosiahWI commented on PR #11508: URL: https://github.com/apache/trafficserver/pull/11508#issuecomment-2206725175 [approve ci freebsd] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Remove jtest tool and its minions [trafficserver]

JosiahWI opened a new pull request, #11509: URL: https://github.com/apache/trafficserver/pull/11509 The JTest tool for ATS performance stress testing has been superceded by our other tests and utilities. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] Fix incorrect metric for agg_copy bytes written [trafficserver]

JosiahWI commented on PR #11508: URL: https://github.com/apache/trafficserver/pull/11508#issuecomment-2206651284 [approve ci freebsd] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fix incorrect metric for agg_copy bytes written [trafficserver]

JosiahWI commented on PR #11508: URL: https://github.com/apache/trafficserver/pull/11508#issuecomment-2206643015 [approve ci freebsd] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Fix incorrect metric for agg_copy bytes written [trafficserver]

JosiahWI opened a new pull request, #11508: URL: https://github.com/apache/trafficserver/pull/11508 We introduced an issue in f23826d where we count backlog failures when copying bytes to the aggregation buffer. The original, intended behavior, was to count the number of bytes copied. This

Re: [PR] Clean up agg_copy [trafficserver]

JosiahWI commented on PR #11456: URL: https://github.com/apache/trafficserver/pull/11456#issuecomment-2206450795 Waiting to rebase on #11508. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s