Re: [PR] Make the error handle deal with remap redirects [trafficserver]

zwoop commented on PR #11567: URL: https://github.com/apache/trafficserver/pull/11567#issuecomment-2238058336 [approve ci]. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Make the error handle deal with remap redirects [trafficserver]

zwoop commented on PR #11567: URL: https://github.com/apache/trafficserver/pull/11567#issuecomment-2238058012 [Approve CI] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Removes matrix parameters from HRW [trafficserver]

zwoop merged PR #11570: URL: https://github.com/apache/trafficserver/pull/11570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@traff

Re: [PR] Removes matrix parameters from regex_remap plugin [trafficserver]

zwoop merged PR #11571: URL: https://github.com/apache/trafficserver/pull/11571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@traff

Re: [PR] Removes the Matrix parameters from Cripts [trafficserver]

zwoop merged PR #11569: URL: https://github.com/apache/trafficserver/pull/11569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@traff

[PR] Fix build for Http3frame fuzz test [trafficserver]

shukitchan opened a new pull request, #11581: URL: https://github.com/apache/trafficserver/pull/11581 related to https://github.com/apache/trafficserver/pull/11497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Added Jasmin and remove Josiah from the collaborators list [trafficserver]

bryancall merged PR #11576: URL: https://github.com/apache/trafficserver/pull/11576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@t

[PR] Remove support of matrix parameters in Lua plugin [trafficserver]

shukitchan opened a new pull request, #11580: URL: https://github.com/apache/trafficserver/pull/11580 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] Reduce the number of checks for BoringSSL [trafficserver]

ywkaras commented on code in PR #11564: URL: https://github.com/apache/trafficserver/pull/11564#discussion_r1683580196 ## include/iocore/net/TLSSNISupport.h: ## @@ -45,11 +45,11 @@ class TLSSNISupport int perform_sni_action(SSL &ssl); // Callback functions for OpenSSL li

Re: [PR] Set `TS_HAVE_TLS_EARLY_DATA` correctly [trafficserver]

JosiahWI merged PR #11577: URL: https://github.com/apache/trafficserver/pull/11577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@tr

Re: [PR] Dispatch READ_COMPLETE when TLS handshake complete [trafficserver]

bneradt commented on code in PR #11574: URL: https://github.com/apache/trafficserver/pull/11574#discussion_r1683542666 ## src/iocore/net/UnixNetVConnection.cc: ## @@ -418,6 +418,12 @@ write_to_net_io(NetHandler *nh, UnixNetVConnection *vc, EThread *thread) if (vc->write.

Re: [PR] Reduce the number of checks for BoringSSL [trafficserver]

JosiahWI commented on code in PR #11564: URL: https://github.com/apache/trafficserver/pull/11564#discussion_r1683530524 ## CMakeLists.txt: ## @@ -485,6 +489,8 @@ endif() unset(CMAKE_REQUIRED_FLAGS) +set(TS_USE_HELLO_CB ${HAVE_SSL_CTX_SET_CLIENT_HELLO_CB} | ${HAVE_SSL_CTX_S

Re: [PR] Reduce the number of checks for BoringSSL [trafficserver]

JosiahWI commented on code in PR #11564: URL: https://github.com/apache/trafficserver/pull/11564#discussion_r1683530524 ## CMakeLists.txt: ## @@ -485,6 +489,8 @@ endif() unset(CMAKE_REQUIRED_FLAGS) +set(TS_USE_HELLO_CB ${HAVE_SSL_CTX_SET_CLIENT_HELLO_CB} | ${HAVE_SSL_CTX_S

Re: [PR] Dispatch READ_COMPLETE when TLS handshake complete [trafficserver]

maskit commented on code in PR #11574: URL: https://github.com/apache/trafficserver/pull/11574#discussion_r1683525070 ## src/iocore/net/UnixNetVConnection.cc: ## @@ -418,6 +418,12 @@ write_to_net_io(NetHandler *nh, UnixNetVConnection *vc, EThread *thread) if (vc->write.e

Re: [PR] Dispatch READ_COMPLETE when TLS handshake complete [trafficserver]

JosiahWI commented on PR #11574: URL: https://github.com/apache/trafficserver/pull/11574#issuecomment-2237643535 Fixes #11552. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Set `TS_HAVE_TLS_EARLY_DATA` correctly [trafficserver]

maskit commented on PR #11577: URL: https://github.com/apache/trafficserver/pull/11577#issuecomment-2237640725 [approve ci] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Removes matrix parameters from regex_remap plugin [trafficserver]

maskit commented on PR #11571: URL: https://github.com/apache/trafficserver/pull/11571#issuecomment-2237642666 [approve ci autest] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Remove matrix parameters from the cookie remap plugin [trafficserver]

maskit commented on PR #11579: URL: https://github.com/apache/trafficserver/pull/11579#issuecomment-2237640037 [approve ci] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Comment out an unused parameter in URLImpl::set_params [trafficserver]

maskit merged PR #11578: URL: https://github.com/apache/trafficserver/pull/11578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@traf

Re: [PR] Removes matrix parameters from regex_remap plugin [trafficserver]

zwoop commented on PR #11571: URL: https://github.com/apache/trafficserver/pull/11571#issuecomment-2237599681 [approve ci autest] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[PR] Removed the API TSUrlHttpParamsGet() from the cookie remap plugin [trafficserver]

bryancall opened a new pull request, #11579: URL: https://github.com/apache/trafficserver/pull/11579 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[PR] Comment out an unused parameter in URLImpl::set_params [trafficserver]

maskit opened a new pull request, #11578: URL: https://github.com/apache/trafficserver/pull/11578 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[PR] Set `TS_HAVE_TLS_EARLY_DATA` correctly [trafficserver]

JosiahWI opened a new pull request, #11577: URL: https://github.com/apache/trafficserver/pull/11577 I chose a conditional over a generator expression because the community is likely more familiar with the conditional, and the generator expressions can look kind of messy. Fixes #11575

Re: [PR] Deprecate the support for URL param segment [trafficserver]

maskit merged PR #11519: URL: https://github.com/apache/trafficserver/pull/11519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@traf

Re: [PR] Deprecate the support for URL param segment [trafficserver]

maskit commented on PR #11519: URL: https://github.com/apache/trafficserver/pull/11519#issuecomment-2237494835 We'll land this as the first step, and like announced on the dev list, remove the APIs for 10.0. -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] Reduce the number of checks for BoringSSL [trafficserver]

ywkaras commented on code in PR #11564: URL: https://github.com/apache/trafficserver/pull/11564#discussion_r1683425025 ## CMakeLists.txt: ## @@ -485,6 +489,8 @@ endif() unset(CMAKE_REQUIRED_FLAGS) +set(TS_USE_HELLO_CB ${HAVE_SSL_CTX_SET_CLIENT_HELLO_CB} | ${HAVE_SSL_CTX_SE

[PR] Added Jasmin and remove Josiah from the collaborators list [trafficserver]

bryancall opened a new pull request, #11576: URL: https://github.com/apache/trafficserver/pull/11576 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] Reduce the number of checks for BoringSSL [trafficserver]

ywkaras commented on code in PR #11564: URL: https://github.com/apache/trafficserver/pull/11564#discussion_r1683418119 ## CMakeLists.txt: ## @@ -485,6 +489,8 @@ endif() unset(CMAKE_REQUIRED_FLAGS) +set(TS_USE_HELLO_CB ${HAVE_SSL_CTX_SET_CLIENT_HELLO_CB} | ${HAVE_SSL_CTX_SE

[PR] Log the URL when getting a cache OpenReadHead warning [trafficserver]

bryancall opened a new pull request, #11573: URL: https://github.com/apache/trafficserver/pull/11573 Log the URL when getting a cache OpenReadHead warning when the content length header doesn't match the document/object length in cache -- This is an automated message from the Ap

Re: [PR] Reduce the number of checks for BoringSSL [trafficserver]

JosiahWI commented on code in PR #11564: URL: https://github.com/apache/trafficserver/pull/11564#discussion_r1683312903 ## include/tscore/ink_config.h.cmake.in: ## @@ -165,7 +165,12 @@ const int DEFAULT_STACKSIZE = @DEFAULT_STACK_SIZE@; // TODO(cmcfarlen): Verify use of below i

[PR] stale_response: remove matrix parameters [trafficserver]

bneradt opened a new pull request, #11572: URL: https://github.com/apache/trafficserver/pull/11572 This patch removes the use of matrix parameters from the stale_response plugin. This change prepares for the core's removal of the TSUrlHttpParamsGet/TSUrlHttpParamsSet API since the matrix pa

Re: [PR] Reduce the number of checks for BoringSSL [trafficserver]

maskit commented on code in PR #11564: URL: https://github.com/apache/trafficserver/pull/11564#discussion_r1683272641 ## CMakeLists.txt: ## @@ -485,6 +489,8 @@ endif() unset(CMAKE_REQUIRED_FLAGS) +set(TS_USE_HELLO_CB ${HAVE_SSL_CTX_SET_CLIENT_HELLO_CB} | ${HAVE_SSL_CTX_SET

Re: [PR] Reduce the number of checks for BoringSSL [trafficserver]

maskit commented on code in PR #11564: URL: https://github.com/apache/trafficserver/pull/11564#discussion_r1683266813 ## include/tscore/ink_config.h.cmake.in: ## @@ -165,7 +165,12 @@ const int DEFAULT_STACKSIZE = @DEFAULT_STACK_SIZE@; // TODO(cmcfarlen): Verify use of below in

Re: [PR] Reduce the number of checks for BoringSSL [trafficserver]

maskit commented on code in PR #11564: URL: https://github.com/apache/trafficserver/pull/11564#discussion_r1683259540 ## src/iocore/net/SSLUtils.cc: ## @@ -1117,14 +1119,14 @@ void SSLMultiCertConfigLoader::_set_handshake_callbacks(SSL_CTX *ctx) { // Make sure the callbacks

Re: [PR] Reduce the number of checks for BoringSSL [trafficserver]

ywkaras commented on code in PR #11564: URL: https://github.com/apache/trafficserver/pull/11564#discussion_r1683246339 ## src/iocore/net/SSLUtils.cc: ## @@ -300,6 +300,7 @@ ssl_verify_client_callback(int preverify_ok, X509_STORE_CTX *ctx) } #if TS_USE_HELLO_CB Review Comme

Re: [PR] Fix server names for post-early-return [trafficserver]

bneradt merged PR #11563: URL: https://github.com/apache/trafficserver/pull/11563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@tra

Re: [PR] Reduce the number of checks for BoringSSL [trafficserver]

ywkaras commented on code in PR #11564: URL: https://github.com/apache/trafficserver/pull/11564#discussion_r1683240712 ## src/iocore/net/SSLUtils.cc: ## @@ -371,6 +372,7 @@ ssl_client_hello_callback(const SSL_CLIENT_HELLO *client_hello) return ssl_select_cert_success; } #e

Re: [PR] Reduce the number of checks for BoringSSL [trafficserver]

ywkaras commented on code in PR #11564: URL: https://github.com/apache/trafficserver/pull/11564#discussion_r1683240712 ## src/iocore/net/SSLUtils.cc: ## @@ -371,6 +372,7 @@ ssl_client_hello_callback(const SSL_CLIENT_HELLO *client_hello) return ssl_select_cert_success; } #e

Re: [PR] Reduce the number of checks for BoringSSL [trafficserver]

ywkaras commented on code in PR #11564: URL: https://github.com/apache/trafficserver/pull/11564#discussion_r1683233931 ## CMakeLists.txt: ## @@ -485,6 +489,8 @@ endif() unset(CMAKE_REQUIRED_FLAGS) +set(TS_USE_HELLO_CB ${HAVE_SSL_CTX_SET_CLIENT_HELLO_CB} | ${HAVE_SSL_CTX_SE

Re: [PR] add_allow and add_deny ACL filter actions [trafficserver]

bneradt commented on PR #11555: URL: https://github.com/apache/trafficserver/pull/11555#issuecomment-2237108134 The addition of `add_allow` and `add_deny` actions are handled as a separate PR here: https://github.com/apache/trafficserver/pull/11568 That seems non-controversial. Onc

[PR] Removes matrix parameters from regex_remap plugin [trafficserver]

zwoop opened a new pull request, #11571: URL: https://github.com/apache/trafficserver/pull/11571 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[PR] Removes matrix parameters from HRW [trafficserver]

zwoop opened a new pull request, #11570: URL: https://github.com/apache/trafficserver/pull/11570 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[PR] Removes the Matrix parameters from Cripts [trafficserver]

zwoop opened a new pull request, #11569: URL: https://github.com/apache/trafficserver/pull/11569 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[PR] add_allow and add_deny ACL filter actions [trafficserver]

bneradt opened a new pull request, #11568: URL: https://github.com/apache/trafficserver/pull/11568 This adds the add_allow and add_deny filter actions. These actions behave just like the allow and deny actions from pre-10 ACL filters, but makes the difference of their behavior from ip_allow

[PR] Make the error handle deal with remap redirects [trafficserver]

zwoop opened a new pull request, #11567: URL: https://github.com/apache/trafficserver/pull/11567 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] Reduce the number of checks for BoringSSL [trafficserver]

JosiahWI commented on code in PR #11564: URL: https://github.com/apache/trafficserver/pull/11564#discussion_r1683154861 ## CMakeLists.txt: ## @@ -485,6 +489,8 @@ endif() unset(CMAKE_REQUIRED_FLAGS) +set(TS_USE_HELLO_CB ${HAVE_SSL_CTX_SET_CLIENT_HELLO_CB} | ${HAVE_SSL_CTX_S

Re: [PR] Reduce the number of checks for BoringSSL [trafficserver]

JosiahWI commented on code in PR #11564: URL: https://github.com/apache/trafficserver/pull/11564#discussion_r1683110978 ## CMakeLists.txt: ## @@ -485,6 +489,8 @@ endif() unset(CMAKE_REQUIRED_FLAGS) +set(TS_USE_HELLO_CB ${HAVE_SSL_CTX_SET_CLIENT_HELLO_CB} | ${HAVE_SSL_CTX_S

Re: [PR] Reduce the number of checks for BoringSSL [trafficserver]

ywkaras commented on code in PR #11564: URL: https://github.com/apache/trafficserver/pull/11564#discussion_r1683097816 ## CMakeLists.txt: ## @@ -485,6 +489,8 @@ endif() unset(CMAKE_REQUIRED_FLAGS) +set(TS_USE_HELLO_CB ${HAVE_SSL_CTX_SET_CLIENT_HELLO_CB} | ${HAVE_SSL_CTX_SE

Re: [PR] Reduce the number of checks for BoringSSL [trafficserver]

JosiahWI commented on code in PR #11564: URL: https://github.com/apache/trafficserver/pull/11564#discussion_r1683084210 ## include/tscore/ink_config.h.cmake.in: ## @@ -165,7 +165,12 @@ const int DEFAULT_STACKSIZE = @DEFAULT_STACK_SIZE@; // TODO(cmcfarlen): Verify use of below i

[PR] Extract Stripe superclass from StripeSM [trafficserver]

JosiahWI opened a new pull request, #11565: URL: https://github.com/apache/trafficserver/pull/11565 The `StripeSM` class retains all the evacuation data and the mutex. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] Fix server names for post-early-return [trafficserver]

JosiahWI commented on PR #11563: URL: https://github.com/apache/trafficserver/pull/11563#issuecomment-2236440737 [approve ci autest] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Fix server names for post-early-return [trafficserver]

JosiahWI commented on PR #11563: URL: https://github.com/apache/trafficserver/pull/11563#issuecomment-2236440578 The AuTest chunked_encoding_disabled failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] records.yaml: Improve the output a little bit to make it clear what's the outcome in some error scenarios. [trafficserver]

shinrich commented on code in PR #11560: URL: https://github.com/apache/trafficserver/pull/11560#discussion_r1682779412 ## src/records/RecCore.cc: ## @@ -244,7 +244,7 @@ RecCoreInit(Diags *_diags) RecLog(DL_Note, "records parsing completed."); if (!err.empty()) {

Re: [PR] Rename `Stripe` to `StripeSM` [trafficserver]

JosiahWI merged PR #11562: URL: https://github.com/apache/trafficserver/pull/11562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@tr