Re: [PR] Extend timeout from 5 to 10 in tunnel_transform test [trafficserver]

2025-03-03 Thread via GitHub
masaori335 merged PR #12068: URL: https://github.com/apache/trafficserver/pull/12068 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] [compress] Add range request control option [trafficserver]

2025-03-03 Thread via GitHub
masaori335 merged PR #11975: URL: https://github.com/apache/trafficserver/pull/11975 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] Deprecate name_get() and value_get() function returns const char * (#10153) [trafficserver]

2025-03-03 Thread via GitHub
masaori335 merged PR #12027: URL: https://github.com/apache/trafficserver/pull/12027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] Link iocore/net/test_net correctly on OSes other than macOS with old CMake (<3.24) [trafficserver]

2025-03-03 Thread via GitHub
cmcfarlen merged PR #12038: URL: https://github.com/apache/trafficserver/pull/12038 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@t

Re: [PR] Extend timeout from 5 to 10 in tunnel_transform test [trafficserver]

2025-03-03 Thread via GitHub
bryancall commented on PR #12068: URL: https://github.com/apache/trafficserver/pull/12068#issuecomment-2695768752 [approve ci autest 1] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Eliminate deprecated lib records apis generic [trafficserver]

2025-03-03 Thread via GitHub
bryancall commented on PR #12060: URL: https://github.com/apache/trafficserver/pull/12060#issuecomment-2695786760 Do we want to return value instead of passing in a pointer and return a std::string_view instead of a char*? -- This is an automated message from the Apache Git Service. To re

Re: [PR] Eliminate deprecated lib records apis generic [trafficserver]

2025-03-03 Thread via GitHub
bryancall commented on PR #12060: URL: https://github.com/apache/trafficserver/pull/12060#issuecomment-2695779440 [approve ci autest 2] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Clarifies that parent.config is to be replaced with strategies [trafficserver]

2025-03-03 Thread via GitHub
bryancall merged PR #12063: URL: https://github.com/apache/trafficserver/pull/12063 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@t

Re: [PR] Fix memory leak in ink_event_system_init [trafficserver]

2025-03-03 Thread via GitHub
bryancall merged PR #12065: URL: https://github.com/apache/trafficserver/pull/12065 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@t

Re: [PR] cppcheck - records. Fix few warnings, nothing major. [trafficserver]

2025-03-03 Thread via GitHub
bryancall commented on PR #12066: URL: https://github.com/apache/trafficserver/pull/12066#issuecomment-2695772732 [approve ci autest 1] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] cppcheck - records. Fix few warnings, nothing major. [trafficserver]

2025-03-03 Thread via GitHub
brbzull0 commented on PR #12066: URL: https://github.com/apache/trafficserver/pull/12066#issuecomment-2695077088 [approve ci autest 0] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] cppcheck - records. Fix few warnings, nothing major. [trafficserver]

2025-03-03 Thread via GitHub
brbzull0 commented on PR #12066: URL: https://github.com/apache/trafficserver/pull/12066#issuecomment-2695063136 [approve ci autest 1] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Create directory before chown on install (#10954) [trafficserver]

2025-03-03 Thread via GitHub
cmcfarlen commented on PR #12036: URL: https://github.com/apache/trafficserver/pull/12036#issuecomment-2694872875 I think your fix is masking the real issue here. We have `cmake/layout.cmake` that sets up up the directory layout, including the logdir directory. That uses the CMAKE_INSTALL

[PR] Extend timeout from 5 to 10 in tunnel_transform test [trafficserver]

2025-03-03 Thread via GitHub
hnakamur opened a new pull request, #12068: URL: https://github.com/apache/trafficserver/pull/12068 Without this adjustment, the tunnel_transform test fails with timeout like below in my test environment: ``` Run: Run dumb proxy and send tunnel request.: Failed Setting up :

[PR] Use ip command as a fallback in redirect_actions test [trafficserver]

2025-03-03 Thread via GitHub
hnakamur opened a new pull request, #12067: URL: https://github.com/apache/trafficserver/pull/12067 Without this workaround, if the hostname is set to a loopback address redirect_actions test fails like below: ``` file /home/jenkins/autest_work/sandbox/redirect_actions/_out

[PR] cppcheck - records. Fix few warnings, nothing major. [trafficserver]

2025-03-03 Thread via GitHub
brbzull0 opened a new pull request, #12066: URL: https://github.com/apache/trafficserver/pull/12066 - No logic change, re-arrange some function signature and code location. - Make some functions signatures more meanful, removing `const` from a function that is supposed to modify the objec

Re: [PR] Coverity: Avoid order initalization issue - part 2. [trafficserver]

2025-03-03 Thread via GitHub
brbzull0 commented on PR #12037: URL: https://github.com/apache/trafficserver/pull/12037#issuecomment-2693647300 > It looks like these accesses of Get_Prop's static could be in hot-spots. This change might impact performance because the static access has to go through a guard to check if it

Re: [PR] Coverity: Avoid order initalization issue - part 2. [trafficserver]

2025-03-03 Thread via GitHub
brbzull0 merged PR #12037: URL: https://github.com/apache/trafficserver/pull/12037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@tr

Re: [PR] Fix `tools/benchmark` code/build. [trafficserver]

2025-03-03 Thread via GitHub
brbzull0 merged PR #12062: URL: https://github.com/apache/trafficserver/pull/12062 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@tr