hnakamur commented on PR #12060: URL: https://github.com/apache/trafficserver/pull/12060#issuecomment-2763533666
If we can change the default value of [`proxy.config.diags.action.tags`](https://github.com/apache/trafficserver/blob/e4fab322b45c0250e0a019b41cb590ef5ee521df/src/records/RecordsConfig.cc#L205) from `nullptr` to an empty string `""`, I think we want more simpler APIs like: ``` std::optional<RecInt> RecGetRecordInt(const char *name, bool lock = true); std::optional<RecFloat> RecGetRecordFloat(const char *name, bool lock = true); RecErrT RecGetRecordString(const char *name, char *buf, int buf_len, bool lock = true); std::optional<std::string> RecGetRecordStringAlloc(const char *name, bool lock = true); std::optional<RecCounter> RecGetRecordCounter(const char *name, bool lock = true); ``` `std::optional::has_value()` for the result returns true if the value is found or false otherwise. This version is at https://github.com/hnakamur/trafficserver/compare/94a72272fcfe291ad5710b44b1c3069c94c27581...eliminate_deprecated_lib_records_apis_std_optional_string_without_error I found that I forgot to modify unit tests. I'll fix those tommorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
