Re: [PR] Revert "HttpSM::tunnel_handler: Handle WRITE events (#11242)" [trafficserver]

2025-04-02 Thread via GitHub
masaori335 commented on PR #12158: URL: https://github.com/apache/trafficserver/pull/12158#issuecomment-2774511907 [approve ci autest] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Revert "HttpSM::tunnel_handler: Handle WRITE events (#11242)" [trafficserver]

2025-04-02 Thread via GitHub
masaori335 commented on PR #12158: URL: https://github.com/apache/trafficserver/pull/12158#issuecomment-2774459099 [approve ci autest 1of4] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Revert "HttpSM::tunnel_handler: Handle WRITE events (#11242)" [trafficserver]

2025-04-02 Thread via GitHub
masaori335 commented on PR #12158: URL: https://github.com/apache/trafficserver/pull/12158#issuecomment-2774458686 [approve ci autest 2of4] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] AuTest for Cripts [trafficserver]

2025-04-02 Thread via GitHub
cmcfarlen commented on PR #12057: URL: https://github.com/apache/trafficserver/pull/12057#issuecomment-2773974139 Cherry-picked to 10.1.x branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Revert "HttpSM::tunnel_handler: Handle WRITE events (#11242)" [trafficserver]

2025-04-02 Thread via GitHub
masaori335 commented on PR #12158: URL: https://github.com/apache/trafficserver/pull/12158#issuecomment-2774226080 [approve ci autest 2of4] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Revert "HttpSM::tunnel_handler: Handle WRITE events (#11242)" [trafficserver]

2025-04-02 Thread via GitHub
masaori335 commented on PR #12158: URL: https://github.com/apache/trafficserver/pull/12158#issuecomment-2774219314 [approve ci autest 2of4] [approve ci autest 3of4] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] Revert "HttpSM::tunnel_handler: Handle WRITE events (#11242)" [trafficserver]

2025-04-02 Thread via GitHub
masaori335 commented on PR #12158: URL: https://github.com/apache/trafficserver/pull/12158#issuecomment-2774217959 [approve ci autest 0 2 3] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Revert "HttpSM::tunnel_handler: Handle WRITE events (#11242)" [trafficserver]

2025-04-02 Thread via GitHub
masaori335 commented on PR #12158: URL: https://github.com/apache/trafficserver/pull/12158#issuecomment-2774218611 [approve ci autest 0of4] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[PR] Revert "HttpSM::tunnel_handler: Handle WRITE events (#11242)" [trafficserver]

2025-04-02 Thread via GitHub
masaori335 opened a new pull request, #12158: URL: https://github.com/apache/trafficserver/pull/12158 This reverts commit ed29bf7bed9e62f75bdc088a58a845a5b9689a2b. To check which AuTest made the crash. -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] Adds convenience APIs / definitions to Cripts [trafficserver]

2025-04-02 Thread via GitHub
zwoop commented on PR #12155: URL: https://github.com/apache/trafficserver/pull/12155#issuecomment-2774128077 [approve ci autest 2] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Cleanup rc/trafficserver to use layout [trafficserver]

2025-04-02 Thread via GitHub
cmcfarlen commented on PR #12118: URL: https://github.com/apache/trafficserver/pull/12118#issuecomment-2773934340 Cherry-picked to 10.1.x branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Adds convenience APIs / definitions to Cripts [trafficserver]

2025-04-02 Thread via GitHub
zwoop commented on code in PR #12155: URL: https://github.com/apache/trafficserver/pull/12155#discussion_r2025851777 ## include/cripts/Headers.hpp: ## @@ -345,18 +345,20 @@ class Header _hdr_loc = nullptr; _bufp= nullptr; } -_state = nullptr; +_ini

Re: [PR] Adds convenience APIs / definitions to Cripts [trafficserver]

2025-04-02 Thread via GitHub
zwoop commented on PR #12155: URL: https://github.com/apache/trafficserver/pull/12155#issuecomment-2774092926 [approve ci autest 2] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Prefetch plugin support UDS path [trafficserver]

2025-04-02 Thread via GitHub
serrislew commented on PR #12156: URL: https://github.com/apache/trafficserver/pull/12156#issuecomment-2773964043 [approve ci autest] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Add some debug logs to proxy protoocl parser [trafficserver]

2025-04-02 Thread via GitHub
cmcfarlen commented on PR #12139: URL: https://github.com/apache/trafficserver/pull/12139#issuecomment-2773948620 Cherry-picked to 10.1.x branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Require the use of CRLF in chunked message body [trafficserver]

2025-04-02 Thread via GitHub
cmcfarlen commented on PR #12148: URL: https://github.com/apache/trafficserver/pull/12148#issuecomment-2773946646 Cherry-picked to 10.1.x branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Stabilize autest tls_sni_with_port [trafficserver]

2025-04-02 Thread via GitHub
cmcfarlen commented on PR #12138: URL: https://github.com/apache/trafficserver/pull/12138#issuecomment-2773942003 Cherry-picked to 10.1.x branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] esi autest: add --private-response test [trafficserver]

2025-04-02 Thread via GitHub
cmcfarlen commented on PR #12135: URL: https://github.com/apache/trafficserver/pull/12135#issuecomment-2773940644 Cherry-picked to 10.1.x branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Fix check for tcp_info struct [trafficserver]

2025-04-02 Thread via GitHub
cmcfarlen commented on PR #12128: URL: https://github.com/apache/trafficserver/pull/12128#issuecomment-2773939327 Cherry-picked to 10.1.x branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Fix header_rewrite loading remap mmdb files [trafficserver]

2025-04-02 Thread via GitHub
cmcfarlen commented on PR #12126: URL: https://github.com/apache/trafficserver/pull/12126#issuecomment-2773937573 Cherry-picked to 10.1.x branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Fix a memory leak in the main function in traffic_server.cc [trafficserver]

2025-04-02 Thread via GitHub
cmcfarlen commented on PR #12099: URL: https://github.com/apache/trafficserver/pull/12099#issuecomment-2773933480 Cherry-picked to 10.1.x branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[PR] Prefetch plugin support UDS path [trafficserver]

2025-04-02 Thread via GitHub
serrislew opened a new pull request, #12156: URL: https://github.com/apache/trafficserver/pull/12156 Support UDS path as client "ip" in prefetch plugin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[PR] Adds convenience APIs / definitions to Cripts [trafficserver]

2025-04-02 Thread via GitHub
zwoop opened a new pull request, #12155: URL: https://github.com/apache/trafficserver/pull/12155 This does a few things: 1. It adds a few top level symbols, polluting the name space with client, server and urls. 2. Adds a few convenience macros, again populated in the top level nam

Re: [PR] Cleanup - Use C++ style cast instead of the C style. Part 1. [trafficserver]

2025-04-02 Thread via GitHub
JosiahWI commented on PR #12153: URL: https://github.com/apache/trafficserver/pull/12153#issuecomment-2773359546 [approve ci autest 1] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Cleanup - Use C++ style cast instead of the C style. Part 1. [trafficserver]

2025-04-02 Thread via GitHub
JosiahWI commented on PR #12153: URL: https://github.com/apache/trafficserver/pull/12153#issuecomment-2773359394 The last test run of the remap_acl test failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Cleanup - Use C++ style cast instead of the C style. Part 1. [trafficserver]

2025-04-02 Thread via GitHub
JosiahWI commented on PR #12153: URL: https://github.com/apache/trafficserver/pull/12153#issuecomment-2773357252 [ci approve autest 1] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Cleanup - Use C++ style cast instead of the C style. Part 1. [trafficserver]

2025-04-02 Thread via GitHub
brbzull0 opened a new pull request, #12153: URL: https://github.com/apache/trafficserver/pull/12153 Got some help from clang-tidy. I have a few more, but to make small PRs let's go with this one first. -- This is an automated message from the Apache Git Service. To respond to the messag