ywkaras commented on PR #10585:
URL: https://github.com/apache/trafficserver/pull/10585#issuecomment-1759561172
I think, for this to work, we would also have to turn tsapicore into a
dynamically linked lib.
--
This is an automated message from the Apache Git Service.
To respond to the mes
cmcfarlen opened a new pull request, #10588:
URL: https://github.com/apache/trafficserver/pull/10588
This change will build `tscore` as a shared library if `BUILD_SHARED_LIBS`
is set to `ON`. By default this will be built statically. We can add more
libraries to honor this settings, but l
bneradt merged PR #10586:
URL: https://github.com/apache/trafficserver/pull/10586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@tra
duke8253 commented on PR #10561:
URL: https://github.com/apache/trafficserver/pull/10561#issuecomment-1759796083
> I see. `chmod` on all of `/opt` can be problematic.
>
> I think it will be more reliable to change the default of `${BASE}` to be
something like `/opt/ats_h3_tools`. Then
JosiahWI commented on PR #10587:
URL: https://github.com/apache/trafficserver/pull/10587#issuecomment-1759811619
There's no AuTest verifying that the reconfiguration takes place, and I
don't see a way to verify it. So unless someone can propose a good way to test,
I'm going to leave it unte
cmcfarlen commented on code in PR #10587:
URL: https://github.com/apache/trafficserver/pull/10587#discussion_r1357019229
##
proxy/http/PreWarmManager.h:
##
@@ -312,6 +216,16 @@ class PreWarmQueue : public Continuation
class PreWarmManager
{
public:
+ PreWarmManager()
+ {
+
maskit commented on PR #10589:
URL: https://github.com/apache/trafficserver/pull/10589#issuecomment-1759892985
Looks like `LogAccess::strlen` doesn't simply count the length. It adds 1
byte for null termination and also consider about alignment. Is it actually
unnecessary?
--
This is an
dragon512 commented on PR #10577:
URL: https://github.com/apache/trafficserver/pull/10577#issuecomment-1759975607
I am fine with having two .so to link with for plugins.. I sort of expected
this would be needed. This will make life a lot easier in the end.
--
This is an automated message
bneradt commented on code in PR #10561:
URL: https://github.com/apache/trafficserver/pull/10561#discussion_r1357119845
##
tools/build_h3_tools.sh:
##
@@ -136,6 +136,7 @@ cmake \
cmake --build build -j ${num_threads}
sudo cmake --install build
sudo chmod -R a+rX ${BASE}
+cd ..
cmcfarlen commented on PR #10585:
URL: https://github.com/apache/trafficserver/pull/10585#issuecomment-1760008020
> I think, for this to work, we would also have to turn tsapicore into a
dynamically linked lib.
I tried this but there is a dependency cycle, so we will have to move some
sharkleash opened a new pull request, #10590:
URL: https://github.com/apache/trafficserver/pull/10590
The changes here are the exact same as those in the previously merged
additional accepts PR: https://github.com/apache/trafficserver/pull/10098
--
This is an automated message fro
ywkaras closed pull request #10577: Move DbgCtl.cc to libtsapi so plugins can
link against it.
URL: https://github.com/apache/trafficserver/pull/10577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
maskit opened a new pull request, #10591:
URL: https://github.com/apache/trafficserver/pull/10591
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
ywkaras commented on PR #10577:
URL: https://github.com/apache/trafficserver/pull/10577#issuecomment-1760155973
> I am fine with having two .so to link with for plugins.. I sort of
expected this would be needed. This will make life a lot easier in the end.
How about the option of just
zwoop opened a new pull request, #10592:
URL: https://github.com/apache/trafficserver/pull/10592
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
duke8253 commented on PR #10589:
URL: https://github.com/apache/trafficserver/pull/10589#issuecomment-1760252565
> Looks like `LogAccess::strlen` doesn't simply count the length. It adds 1
byte for null termination and also consider about alignment. Is it actually
unnecessary?
Good p
maskit merged PR #10591:
URL: https://github.com/apache/trafficserver/pull/10591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@traf
zwoop merged PR #10592:
URL: https://github.com/apache/trafficserver/pull/10592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@traff
JosiahWI opened a new pull request, #10594:
URL: https://github.com/apache/trafficserver/pull/10594
While examining the dependency structure I came across this. Those includes
have been there for a very long time and are no longer needed.
--
This is an automated message from the Apache Gi
cmcfarlen opened a new pull request, #10595:
URL: https://github.com/apache/trafficserver/pull/10595
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
maskit opened a new pull request, #10596:
URL: https://github.com/apache/trafficserver/pull/10596
Trying to catch the trend. This removes `#include `
from `proxy/`, and use more abstract `QUICSupport.h` instead.
--
This is an automated message from the Apache Git Service.
To respond to th
JosiahWI opened a new pull request, #10597:
URL: https://github.com/apache/trafficserver/pull/10597
This removes unused inkcache includes from the inkdns and inkhostdb
components, breaking the dependency on inkcache for both.
--
This is an automated message from the Apache Git Service.
To
cmcfarlen opened a new pull request, #10598:
URL: https://github.com/apache/trafficserver/pull/10598
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
bneradt merged PR #10594:
URL: https://github.com/apache/trafficserver/pull/10594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@tra
duke8253 commented on PR #10589:
URL: https://github.com/apache/trafficserver/pull/10589#issuecomment-1760396043
Closing this for now incase it gets merged by accident.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
duke8253 closed pull request #10589: Use returned length instead of calculating
again with strlen
URL: https://github.com/apache/trafficserver/pull/10589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
cmcfarlen merged PR #10588:
URL: https://github.com/apache/trafficserver/pull/10588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@t
JosiahWI commented on code in PR #10598:
URL: https://github.com/apache/trafficserver/pull/10598#discussion_r1357454658
##
cmake/FindLuaJIT.cmake:
##
@@ -44,5 +44,6 @@ endif()
if(LuaJIT_FOUND AND NOT TARGET LuaJIT::LuaJIT)
add_library(LuaJIT::LuaJIT INTERFACE IMPORTED)
JosiahWI commented on code in PR #10598:
URL: https://github.com/apache/trafficserver/pull/10598#discussion_r1357454658
##
cmake/FindLuaJIT.cmake:
##
@@ -44,5 +44,6 @@ endif()
if(LuaJIT_FOUND AND NOT TARGET LuaJIT::LuaJIT)
add_library(LuaJIT::LuaJIT INTERFACE IMPORTED)
cmcfarlen commented on PR #10595:
URL: https://github.com/apache/trafficserver/pull/10595#issuecomment-1760447867
[approve ci cmake]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
cmcfarlen commented on code in PR #10597:
URL: https://github.com/apache/trafficserver/pull/10597#discussion_r1357500383
##
proxy/http/HttpTransactCache.cc:
##
@@ -29,6 +29,10 @@
#include
#include "HTTP.h"
#include "HttpCompat.h"
+
+// inkcache
+#include "P_Cache.h"
Review
JosiahWI commented on code in PR #10597:
URL: https://github.com/apache/trafficserver/pull/10597#discussion_r1357502559
##
proxy/http/HttpTransactCache.cc:
##
@@ -29,6 +29,10 @@
#include
#include "HTTP.h"
#include "HttpCompat.h"
+
+// inkcache
+#include "P_Cache.h"
Review C
JosiahWI commented on code in PR #10597:
URL: https://github.com/apache/trafficserver/pull/10597#discussion_r1357503167
##
proxy/http/HttpTransactCache.cc:
##
@@ -29,6 +29,10 @@
#include
#include "HTTP.h"
#include "HttpCompat.h"
+
+// inkcache
+#include "P_Cache.h"
Review C
JosiahWI opened a new pull request, #10599:
URL: https://github.com/apache/trafficserver/pull/10599
This is a low-priority cleanup, but it should be easy to review because I
only moved code between files and didn't make any source changes, besides
taking the time to carefully list out all t
JosiahWI commented on code in PR #10597:
URL: https://github.com/apache/trafficserver/pull/10597#discussion_r1357507644
##
proxy/http/HttpTransactCache.cc:
##
@@ -29,6 +29,10 @@
#include
#include "HTTP.h"
#include "HttpCompat.h"
+
+// inkcache
+#include "P_Cache.h"
Review C
cmcfarlen commented on code in PR #10597:
URL: https://github.com/apache/trafficserver/pull/10597#discussion_r1357519085
##
proxy/http/HttpTransactCache.cc:
##
@@ -29,6 +29,10 @@
#include
#include "HTTP.h"
#include "HttpCompat.h"
+
+// inkcache
+#include "P_Cache.h"
Review
cmcfarlen commented on code in PR #10598:
URL: https://github.com/apache/trafficserver/pull/10598#discussion_r1357523134
##
cmake/FindLuaJIT.cmake:
##
@@ -44,5 +44,6 @@ endif()
if(LuaJIT_FOUND AND NOT TARGET LuaJIT::LuaJIT)
add_library(LuaJIT::LuaJIT INTERFACE IMPORTED)
cmcfarlen commented on code in PR #10598:
URL: https://github.com/apache/trafficserver/pull/10598#discussion_r1357524896
##
cmake/FindLuaJIT.cmake:
##
@@ -44,5 +44,6 @@ endif()
if(LuaJIT_FOUND AND NOT TARGET LuaJIT::LuaJIT)
add_library(LuaJIT::LuaJIT INTERFACE IMPORTED)
masaori335 commented on code in PR #10587:
URL: https://github.com/apache/trafficserver/pull/10587#discussion_r1357587885
##
iocore/net/PreWarm.h:
##
@@ -0,0 +1,132 @@
+/** @file
+
+ Pre-Warming NetVConnection
+
+ @section license License
+
+ Licensed to the Apache Software F
JosiahWI commented on code in PR #10587:
URL: https://github.com/apache/trafficserver/pull/10587#discussion_r1357588472
##
iocore/net/PreWarm.h:
##
@@ -0,0 +1,132 @@
+/** @file
+
+ Pre-Warming NetVConnection
+
+ @section license License
+
+ Licensed to the Apache Software Fou
masaori335 commented on code in PR #10587:
URL: https://github.com/apache/trafficserver/pull/10587#discussion_r1357588602
##
proxy/http/PreWarmManager.h:
##
@@ -312,6 +216,16 @@ class PreWarmQueue : public Continuation
class PreWarmManager
{
public:
+ PreWarmManager()
+ {
+
masaori335 commented on PR #10599:
URL: https://github.com/apache/trafficserver/pull/10599#issuecomment-1760592237
We can move these later, but please note that some CacheVC function
implementations are still in the CacheRead.cc and CacheWrite.cc.
https://github.com/apache/trafficser
JosiahWI commented on PR #10599:
URL: https://github.com/apache/trafficserver/pull/10599#issuecomment-1760596219
Good catch. I'll add that to my TODO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
masaori335 commented on PR #10599:
URL: https://github.com/apache/trafficserver/pull/10599#issuecomment-1760598760
Also in the CacheVol.cc. Thanks for taking care those.
https://github.com/apache/trafficserver/blob/2eb6377e8e59ae862c4e0f29aabc139b6f8b1acc/iocore/cache/CacheVol.cc#L62
--
JosiahWI commented on code in PR #10598:
URL: https://github.com/apache/trafficserver/pull/10598#discussion_r1357611944
##
cmake/FindLuaJIT.cmake:
##
@@ -44,5 +44,6 @@ endif()
if(LuaJIT_FOUND AND NOT TARGET LuaJIT::LuaJIT)
add_library(LuaJIT::LuaJIT INTERFACE IMPORTED)
bneradt merged PR #10599:
URL: https://github.com/apache/trafficserver/pull/10599
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@tra
46 matches
Mail list logo
