Re: [PR] HttpSM - make sure we have a valid buffer to write on. [trafficserver]

2026-03-31 Thread via GitHub
cmcfarlen commented on PR #13040: URL: https://github.com/apache/trafficserver/pull/13040#issuecomment-4163010985 Cherry-picked to 10.2.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] hrw: Refix loading geodb files [trafficserver]

2026-03-31 Thread via GitHub
cmcfarlen commented on PR #13025: URL: https://github.com/apache/trafficserver/pull/13025#issuecomment-4163017258 Cherry-picked to 10.2.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] tools: Add traffic_grapher for real-time ATS metrics visualization [trafficserver]

2026-03-31 Thread via GitHub
cmcfarlen commented on PR #12848: URL: https://github.com/apache/trafficserver/pull/12848#issuecomment-4163145454 Cherry-picked to 10.2.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[PR] Backport #12998 - Parallel SSL cert load [trafficserver]

2026-03-31 Thread via GitHub
ezelkow1 opened a new pull request, #13043: URL: https://github.com/apache/trafficserver/pull/13043 Backport of #12998 Parallel ssl cert loading -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Backport #12998 - Parallel SSL cert load [trafficserver]

2026-03-31 Thread via GitHub
ezelkow1 commented on PR #13043: URL: https://github.com/apache/trafficserver/pull/13043#issuecomment-4163536751 [approve ci] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Backport #12998 - Parallel SSL cert load [trafficserver]

2026-03-31 Thread via GitHub
ezelkow1 commented on PR #13043: URL: https://github.com/apache/trafficserver/pull/13043#issuecomment-4163580679 [approve ci] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Backport #12998 - Parallel SSL cert load [trafficserver]

2026-03-31 Thread via GitHub
ezelkow1 commented on PR #13043: URL: https://github.com/apache/trafficserver/pull/13043#issuecomment-4163605989 [approve ci] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Add log field header fallbacks [trafficserver]

2026-03-31 Thread via GitHub
serrislew commented on code in PR #13018: URL: https://github.com/apache/trafficserver/pull/13018#discussion_r3016769351 ## doc/admin-guide/logging/formatting.en.rst: ## @@ -314,8 +314,27 @@ prior to the log field's name, as so:: Format = '%<{User-agent}cqh>' The above w

Re: [PR] Add sni.yaml session ticket overrides [trafficserver]

2026-03-31 Thread via GitHub
bneradt commented on PR #13006: URL: https://github.com/apache/trafficserver/pull/13006#issuecomment-4163847446 10.2.x backport: https://github.com/apache/trafficserver/pull/13044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[PR] Add sni.yaml session ticket overrides (#13006) [trafficserver]

2026-03-31 Thread via GitHub
bneradt opened a new pull request, #13044: URL: https://github.com/apache/trafficserver/pull/13044 Add ssl_ticket_enabled and ssl_ticket_number as sni.yaml overrides, apply them during SNI handling so they affect TLS 1.2 resumption and TLS 1.3 ticket issuance, and add unit and AuTest covera

Re: [PR] Allow set-body to replace origin server response bodies [trafficserver]

2026-03-31 Thread via GitHub
bryancall commented on PR #12879: URL: https://github.com/apache/trafficserver/pull/12879#issuecomment-4163968145 @copilot review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[PR] Add shutdown hook function for lua plugin [trafficserver]

2026-03-31 Thread via GitHub
shukitchan opened a new pull request, #13045: URL: https://github.com/apache/trafficserver/pull/13045 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] Add shutdown hook function for lua plugin [trafficserver]

2026-03-31 Thread via GitHub
Copilot commented on code in PR #13045: URL: https://github.com/apache/trafficserver/pull/13045#discussion_r3017257365 ## plugins/lua/ts_lua_common.h: ## @@ -62,6 +62,9 @@ extern "C" { // TLS hooks can only be global #define TS_LUA_FUNCTION_G_VCONN_START "do_global_vconn_start

[PR] Try to change uid/gid on plugin runtime dir before dropping privs, if POSIX not available [trafficserver]

2026-03-31 Thread via GitHub
ezelkow1 opened a new pull request, #13046: URL: https://github.com/apache/trafficserver/pull/13046 This is a workaround for systems that don't provide the same POSIX style permissions dropping, i.e. BSD. This recursively changes the permissions on the runtime (usually var) and loggi

Re: [PR] Fix link_libraries for cripts unit tests [trafficserver]

2026-03-31 Thread via GitHub
cmcfarlen merged PR #13047: URL: https://github.com/apache/trafficserver/pull/13047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@t

Re: [PR] [usdt] http_attach_client_session: add args [trafficserver]

2026-03-31 Thread via GitHub
moonchen merged PR #13041: URL: https://github.com/apache/trafficserver/pull/13041 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@tr

Re: [PR] Support per-remap geo DB handles in header_rewrite [trafficserver]

2026-03-31 Thread via GitHub
bneradt commented on PR #13042: URL: https://github.com/apache/trafficserver/pull/13042#issuecomment-4165064429 [approve ci autest 0] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Try to change uid/gid on plugin runtime dir before dropping privs, if POSIX not available [trafficserver]

2026-03-31 Thread via GitHub
Copilot commented on code in PR #13046: URL: https://github.com/apache/trafficserver/pull/13046#discussion_r3017551639 ## src/traffic_server/traffic_server.cc: ## @@ -1757,6 +1758,70 @@ change_uid_gid(const char *user) #endif } +#if !TS_USE_POSIX_CAP +/** + * Recursively cho

Re: [PR] Try to change uid/gid on plugin runtime dir before dropping privs, if POSIX not available [trafficserver]

2026-03-31 Thread via GitHub
ezelkow1 commented on code in PR #13046: URL: https://github.com/apache/trafficserver/pull/13046#discussion_r3017856190 ## src/traffic_server/traffic_server.cc: ## @@ -1757,6 +1758,83 @@ change_uid_gid(const char *user) #endif } +#if !TS_USE_POSIX_CAP +/** + * Recursively ch

Re: [PR] Allow set-body to replace origin server response bodies [trafficserver]

2026-03-31 Thread via GitHub
Copilot commented on code in PR #12879: URL: https://github.com/apache/trafficserver/pull/12879#discussion_r3018163551 ## src/proxy/http/HttpSM.cc: ## @@ -1685,9 +1685,20 @@ HttpSM::handle_api_return() switch (t_state.next_action) { case HttpTransact::StateMachineAction_

Re: [PR] Add sni.yaml session ticket overrides (#13006) [trafficserver]

2026-03-31 Thread via GitHub
bneradt commented on PR #13044: URL: https://github.com/apache/trafficserver/pull/13044#issuecomment-4165046346 [approve ci autest 1] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Fix link_libraries for cripts unit tests [trafficserver]

2026-03-31 Thread via GitHub
cmcfarlen opened a new pull request, #13047: URL: https://github.com/apache/trafficserver/pull/13047 This fixes build issues when openssl libs aren't in the default location. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Add sni.yaml session ticket overrides (#13006) [trafficserver]

2026-03-31 Thread via GitHub
cmcfarlen commented on code in PR #13044: URL: https://github.com/apache/trafficserver/pull/13044#discussion_r3018515025 ## src/iocore/net/SSLUtils.cc: ## @@ -401,13 +407,9 @@ ssl_cert_callback(SSL *ssl, [[maybe_unused]] void *arg) setClientCertCACerts(ssl, sslnetvc->get_

Re: [PR] Try to change uid/gid on plugin runtime dir before dropping privs, if POSIX not available [trafficserver]

2026-03-31 Thread via GitHub
bneradt commented on code in PR #13046: URL: https://github.com/apache/trafficserver/pull/13046#discussion_r3017799235 ## src/traffic_server/traffic_server.cc: ## @@ -1757,6 +1758,83 @@ change_uid_gid(const char *user) #endif } +#if !TS_USE_POSIX_CAP +/** + * Recursively cho

Re: [PR] Fix link_libraries for cripts unit tests [trafficserver]

2026-03-31 Thread via GitHub
cmcfarlen commented on PR #13047: URL: https://github.com/apache/trafficserver/pull/13047#issuecomment-4165792316 Cherry-picked to 10.2.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Allow set-body to replace origin server response bodies [trafficserver]

2026-03-31 Thread via GitHub
bryancall commented on code in PR #12879: URL: https://github.com/apache/trafficserver/pull/12879#discussion_r3018609247 ## src/proxy/http/HttpSM.cc: ## @@ -1685,9 +1685,20 @@ HttpSM::handle_api_return() switch (t_state.next_action) { case HttpTransact::StateMachineActio

Re: [PR] Add shutdown hook function for lua plugin [trafficserver]

2026-03-31 Thread via GitHub
Copilot commented on code in PR #13045: URL: https://github.com/apache/trafficserver/pull/13045#discussion_r3018612755 ## plugins/lua/ts_lua.cc: ## @@ -827,6 +827,34 @@ globalHookHandler(TSCont contp, TSEvent event ATS_UNUSED, void *edata) return 0; } +static int +shutdow

Re: [PR] Add sni.yaml session ticket overrides (#13006) [trafficserver]

2026-03-31 Thread via GitHub
bneradt commented on code in PR #13044: URL: https://github.com/apache/trafficserver/pull/13044#discussion_r3018661442 ## src/iocore/net/SSLUtils.cc: ## @@ -401,13 +407,9 @@ ssl_cert_callback(SSL *ssl, [[maybe_unused]] void *arg) setClientCertCACerts(ssl, sslnetvc->get_ca

Re: [PR] Add sni.yaml session ticket overrides (#13006) [trafficserver]

2026-03-31 Thread via GitHub
bneradt commented on code in PR #13044: URL: https://github.com/apache/trafficserver/pull/13044#discussion_r3018661442 ## src/iocore/net/SSLUtils.cc: ## @@ -401,13 +407,9 @@ ssl_cert_callback(SSL *ssl, [[maybe_unused]] void *arg) setClientCertCACerts(ssl, sslnetvc->get_ca

Re: [PR] Backport #12998 - Parallel SSL cert load [trafficserver]

2026-03-31 Thread via GitHub
cmcfarlen merged PR #13043: URL: https://github.com/apache/trafficserver/pull/13043 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@t

Re: [PR] Parallell ssl cert load [trafficserver]

2026-03-31 Thread via GitHub
cmcfarlen commented on PR #12998: URL: https://github.com/apache/trafficserver/pull/12998#issuecomment-4165906175 Added to 10.2.x via #13043 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Add sni.yaml session ticket overrides (#13006) [trafficserver]

2026-03-31 Thread via GitHub
bneradt commented on code in PR #13044: URL: https://github.com/apache/trafficserver/pull/13044#discussion_r3018766475 ## src/iocore/net/SSLUtils.cc: ## @@ -401,13 +407,9 @@ ssl_cert_callback(SSL *ssl, [[maybe_unused]] void *arg) setClientCertCACerts(ssl, sslnetvc->get_ca

Re: [PR] Add sni.yaml session ticket overrides (#13006) [trafficserver]

2026-03-31 Thread via GitHub
cmcfarlen commented on code in PR #13044: URL: https://github.com/apache/trafficserver/pull/13044#discussion_r3018786935 ## src/iocore/net/SSLUtils.cc: ## @@ -401,13 +407,9 @@ ssl_cert_callback(SSL *ssl, [[maybe_unused]] void *arg) setClientCertCACerts(ssl, sslnetvc->get_

Re: [PR] Add sni.yaml session ticket overrides (#13006) [trafficserver]

2026-03-31 Thread via GitHub
cmcfarlen merged PR #13044: URL: https://github.com/apache/trafficserver/pull/13044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@t

Re: [PR] Add sni.yaml session ticket overrides [trafficserver]

2026-03-31 Thread via GitHub
cmcfarlen commented on PR #13006: URL: https://github.com/apache/trafficserver/pull/13006#issuecomment-4166039618 Added to milestone 10.2.0 via #13044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Add log field header fallbacks [trafficserver]

2026-03-31 Thread via GitHub
bneradt commented on code in PR #13018: URL: https://github.com/apache/trafficserver/pull/13018#discussion_r3018903295 ## doc/admin-guide/logging/formatting.en.rst: ## @@ -314,8 +314,27 @@ prior to the log field's name, as so:: Format = '%<{User-agent}cqh>' The above wou

Re: [PR] Try to change uid/gid on plugin runtime dir before dropping privs, if POSIX not available [trafficserver]

2026-03-31 Thread via GitHub
ezelkow1 merged PR #13046: URL: https://github.com/apache/trafficserver/pull/13046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@tr

Re: [PR] Add boringssl support to the ja4_fingerprint plugin [trafficserver]

2026-03-31 Thread via GitHub
maskit commented on PR #12790: URL: https://github.com/apache/trafficserver/pull/12790#issuecomment-4166350079 The change on this PR was merged as part of https://github.com/apache/trafficserver/pull/12914. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] Add boringssl support to the ja4_fingerprint plugin [trafficserver]

2026-03-31 Thread via GitHub
maskit closed pull request #12790: Add boringssl support to the ja4_fingerprint plugin URL: https://github.com/apache/trafficserver/pull/12790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Add shutdown hook function for lua plugin [trafficserver]

2026-03-31 Thread via GitHub
Copilot commented on code in PR #13045: URL: https://github.com/apache/trafficserver/pull/13045#discussion_r3018997968 ## plugins/lua/ts_lua.cc: ## @@ -827,6 +827,46 @@ globalHookHandler(TSCont contp, TSEvent event ATS_UNUSED, void *edata) return 0; } +static int +shutdow

Re: [PR] Replace storage.config and volume.config with storage.yaml [trafficserver]

2026-03-31 Thread via GitHub
masaori335 merged PR #13031: URL: https://github.com/apache/trafficserver/pull/13031 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@