Re: [PR] Use large IOBufferBlock only on sending DATA frame [trafficserver]

2024-05-01 Thread via GitHub
masaori335 commented on PR #11229: URL: https://github.com/apache/trafficserver/pull/11229#issuecomment-2089520415 Rebased on the latest master. Please take another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] compress autest: verify compressed bodies [trafficserver]

2024-05-01 Thread via GitHub
bneradt opened a new pull request, #11309: URL: https://github.com/apache/trafficserver/pull/11309 Add body compression verification to the compress.test.py autest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] Fix case where 206 could be returned for range revalidates [trafficserver]

2024-05-01 Thread via GitHub
cmcfarlen opened a new pull request, #11308: URL: https://github.com/apache/trafficserver/pull/11308 If a client asks for a range request for a cached object that when re-validated the server returns an error, then ATS would return a 206. -- This is an automated message from the

[PR] Remove obsolete debug output calls in 18 source files. [trafficserver]

2024-05-01 Thread via GitHub
ywkaras opened a new pull request, #11307: URL: https://github.com/apache/trafficserver/pull/11307 In the src/proxy tree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Use large IOBufferBlock only on sending DATA frame [trafficserver]

2024-05-01 Thread via GitHub
duke8253 commented on PR #11229: URL: https://github.com/apache/trafficserver/pull/11229#issuecomment-2088995047 [approve ci autest] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] fedora:40: build quiche with both openssl and boringssl [trafficserver-ci]

2024-05-01 Thread via GitHub
bneradt merged PR #342: URL: https://github.com/apache/trafficserver-ci/pull/342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] fedora:40: build quiche with both openssl and boringssl [trafficserver-ci]

2024-05-01 Thread via GitHub
bneradt opened a new pull request, #342: URL: https://github.com/apache/trafficserver-ci/pull/342 Pull in the updated tools/build_h3_tools.sh work from ATS. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] tools: Dual build for openssl and boringssl H3 tools. [trafficserver]

2024-05-01 Thread via GitHub
cmcfarlen commented on PR #11270: URL: https://github.com/apache/trafficserver/pull/11270#issuecomment-2088879840 Cherry-picked to v10.0.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Build an extra static boringssl for NuRaft [trafficserver]

2024-05-01 Thread via GitHub
cmcfarlen commented on PR #11185: URL: https://github.com/apache/trafficserver/pull/11185#issuecomment-2088879444 Cherry-picked to v10.0.x This was needed to cleanly pick #11270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] H3 build tools. Fix missing include detected on Fedora 40. [trafficserver]

2024-05-01 Thread via GitHub
brbzull0 merged PR #11306: URL: https://github.com/apache/trafficserver/pull/11306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] H3 build tools. Fix missing include detected on Fedora 40. [trafficserver]

2024-05-01 Thread via GitHub
bneradt commented on PR #11306: URL: https://github.com/apache/trafficserver/pull/11306#issuecomment-2088591492 [approve ci autest] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] H3 build tools. Fix missing include detected on Fedora 40. [trafficserver]

2024-05-01 Thread via GitHub
bneradt commented on PR #11306: URL: https://github.com/apache/trafficserver/pull/11306#issuecomment-2088588922 I have verified locally that this works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] -fno-strict-aliasing [trafficserver]

2024-05-01 Thread via GitHub
cmcfarlen commented on PR #11303: URL: https://github.com/apache/trafficserver/pull/11303#issuecomment-2088583837 Cherry-picked to v10.0.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Fixes clang-format v18.1.2 on linux AARCH64 [trafficserver]

2024-05-01 Thread via GitHub
cmcfarlen commented on PR #11304: URL: https://github.com/apache/trafficserver/pull/11304#issuecomment-2088584762 Cherry-picked to v10.0.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] ci-fedora-cxx20 preset: build cripts [trafficserver]

2024-05-01 Thread via GitHub
cmcfarlen commented on PR #11300: URL: https://github.com/apache/trafficserver/pull/11300#issuecomment-2088583190 Cherry-picked to v10.0.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Update XPACK.cc to fix use-of-uninitialized-pointer-field case [trafficserver]

2024-05-01 Thread via GitHub
cmcfarlen commented on PR #11287: URL: https://github.com/apache/trafficserver/pull/11287#issuecomment-2088582564 Cherry-picked to v10.0.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Restore derived metrics using new metrics [trafficserver]

2024-05-01 Thread via GitHub
cmcfarlen commented on PR #11297: URL: https://github.com/apache/trafficserver/pull/11297#issuecomment-2088581632 Cherry-picked to v10.0.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Add Au testing for statichit.so plugin. [trafficserver]

2024-05-01 Thread via GitHub
cmcfarlen commented on PR #11293: URL: https://github.com/apache/trafficserver/pull/11293#issuecomment-2088580372 Cherry-picked to v10.0.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] clang-format v18 + modified configs [trafficserver]

2024-05-01 Thread via GitHub
cmcfarlen commented on PR #11285: URL: https://github.com/apache/trafficserver/pull/11285#issuecomment-2088546868 This was added to 10.0.x via the PR https://github.com/apache/trafficserver/pull/11299 so I removed the 10.0.x project from this PR. -- This is an automated message from the

Re: [PR] H3 build tools. Fix missing include detected on Fedora 40. [trafficserver]

2024-05-01 Thread via GitHub
bneradt commented on PR #11306: URL: https://github.com/apache/trafficserver/pull/11306#issuecomment-2088541081 [approve ci autest] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] -fno-strict-aliasing [trafficserver]

2024-05-01 Thread via GitHub
bneradt merged PR #11303: URL: https://github.com/apache/trafficserver/pull/11303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Check the appropriate functions and set variables correctly [trafficserver]

2024-05-01 Thread via GitHub
cmcfarlen commented on PR #11215: URL: https://github.com/apache/trafficserver/pull/11215#issuecomment-2088531101 This was added to 10.0.x via the PR #11299 so I removed the 10.0.x project from this PR. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] H3 build tools. Fix missing include detected on Fedora 40. [trafficserver]

2024-05-01 Thread via GitHub
brbzull0 commented on PR #11306: URL: https://github.com/apache/trafficserver/pull/11306#issuecomment-2088483968 [approve ci autest] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] H3 build tools. Fix missing include detected on Fedora 40. [trafficserver]

2024-05-01 Thread via GitHub
brbzull0 opened a new pull request, #11306: URL: https://github.com/apache/trafficserver/pull/11306 We found out that on Fedora40 the build script was failing building one of the tools(nghttp2) because of a missing include. This adds the missing include line. -- This is an automated