codebrainz commented on this pull request.
> @@ -52,6 +52,16 @@ typedef struct
PluginDocDataProxy;
+/** Returns the runtime API version Geany was compiled with.
+ *
+ * @return Geany's API version
You could also take the docs from [my original
PR](https://github.com/kugel-/geany/pull/3)
@b4n, I thought you were saying this change invalidated the ABI.
In terms of its use-case, isn't the whole point of the GIR stuff @kugel- is
doing to allow dynamic binding from languages like Python or Js without the
compiled hand carved bindings? So that dynamically bound code needs to be
b4n approved this pull request.
Otherwise LGTM
> @@ -52,6 +52,16 @@ typedef struct
PluginDocDataProxy;
+/** Returns the runtime API version Geany was compiled with.
+ *
+ * @return Geany's API version
Maybe add more detailed docs, like "this can be used to [blah blah what is it
useful
@elextr I don't get what point you're tying to make? Mine was that Geany's C
API is basically only made of compile-time things (functions, structure fields,
etc.), so there's no point in checking those at runtime: either it built and
linked in which case you're all set, or it didn't and this
I've added a fix for https://github.com/geany/geany-plugins/issues/532.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/531#issuecomment-282009984
@techee pushed 1 commit.
7beb433 git-changebar: correctly display diff when first line removed
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@b4n, surely adding to API and incrementing the number is the intended method?
Don't the plugins test against >= API number and exactly == ABI number?
Any plugin that uses this function will need to ask for API >= the number where
this was introduced.
--
You are receiving this because you
> If/when we merge #1236 I'd still like peasy to load on 1.30, that's my main
> motivation.
Fair enough. Though this technically breaks API as mentioned there, so we
could argue on bumping ABI (as it's the closets thing we have to "broken
backward compat")
--
You are receiving this because
@kugel- Not now, but I wish. Actually I'm not working on much Geany/GP stuff
these days :(
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/164#issuecomment-281993503
If/when we merge #1236 I'd still like peasy to load on 1.30, that's my main
motivation.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1406#issuecomment-281989216
kugel- commented on this pull request.
> @@ -52,6 +52,15 @@ typedef struct
PluginDocDataProxy;
+/** Returns the runtime API version Geany was compiled with.
+ *
+ * @return Geany's API version
+ */
+gint geany_api_version(void)
Indeed, sorry.
--
You are receiving this because you are
There are some aspects of document editing that can be distinctly
unsatisfactory in tools like RStudio (say, search and replace). I often find
myself juggling between the two, and making modifications with Geany when
RStudio falls short, or when interaction isn't necessary.
The integration
As I understand it languages like R (what I call analyst languages) are mostly
used interactively, so I wonder what it is that Geany (a tool targeted at a
distinctly non-interactive workflow) adds that would make it worth considering
over interactive specialists like Atom or Juypter?
--
You
This is on the back of making Geany behave [more like
RStudio](http://wiki.geany.org/howtos/using_geany_with_r?s[]=rstudio) for
interactive use with things like R or Python.
While now it is easy to “Send selection to terminal” (by setting
`send_selection_unsafe=true` in `geany.conf` and
I wanted to get some feedback on the updated patches in
https://github.com/geany/geany/pull/1400 before merging this. But hopefully the
patch isn't too problematic and if something pops up in Geany, I can provide a
patch for geany-plugins.
--
You are receiving this because you are subscribed
Sorry @techee I misread :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1224#issuecomment-281952301
@elextr As I said, for 1.31, not 1.30.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1224#issuecomment-281950577
@techee it would be nice to get it done, but since its now only just over a
week to release IMHO no more changes other than bugfixes should be included.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Would be nice to stop incrementing the target release get this finally merged
in 1.31. I believe the only thing that @b4n requested was updating the API in
the docstring which should now be 1.31. @codebrainz could you make this change?
--
You are receiving this because you are subscribed to
19 matches
Mail list logo