[Github-comments] [geany/geany] Update HACKING (#1479)

2017-04-25 Thread Vasiliy Faronov
You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/1479 -- Commit Summary -- * Update obsolete references to GLib 2.27/28 in HACKING * Replace obsolete gcc -W option with -Wextra in HACKING -- File Changes -- M HACKING (6) -- Patch L

Re: [Github-comments] [geany/geany] Update HACKING (#1479)

2017-04-25 Thread elextr
Merged #1479. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1479#event-1056173385

Re: [Github-comments] [geany/geany] Conflicting GLib requirements in HACKING (#1476)

2017-04-25 Thread elextr
Closed #1476 via dbcf456031127ce7e371606dcc75507024eb95df. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1476#event-1056173672

Re: [Github-comments] [geany/geany] Update HACKING (#1479)

2017-04-25 Thread elextr
Looks good to me, thanks for that. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1479#issuecomment-296953823

[Github-comments] [geany/geany] Track changes to navqueue positions as a document is edited (#1480)

2017-04-25 Thread Vasiliy Faronov
(moved out of #1136) 1. Open a C source file with the following text: ``` void foo(void) { printf("Hello world!\n"); } void main() { foo(); } ``` 2. On line 8, Ctrl+click on `foo`. Geany navigates to line 1, the definition of `foo`. 3. Insert the follo

Re: [Github-comments] [geany/geany] Track changes to navqueue positions as a document is edited (#1480)

2017-04-25 Thread elextr
This is going to be somewhat tricky in some cases like replace all where changes are made to multiple places at once. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1480#issuecomment-29

Re: [Github-comments] [geany/geany] Handle continuous G_IO_IN-s without any data (#1461)

2017-04-25 Thread zhekov
Please don't merge ATM. It occurred to me that the timeout reads currently read only once per call = DEFAULT_IO_LENGTH each 50ms = 80KB/sec max, which is pretty low. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://g

[Github-comments] [geany/geany] Track changes to line numbers for messages and compiler errors (#1481)

2017-04-25 Thread Vasiliy Faronov
This is my naive attempt at solving #1136. It works for me (not heavily tested yet), but I’m not sure if it’s a good idea. I would appreciate any feedback. Geany’s message window is sort of detached from the editor. In general, it’s just lines of text that are not parsed or associated with the f

Re: [Github-comments] [geany/geany] Better snippets (#1470)

2017-04-25 Thread Vasiliy Faronov
Before this PR, when I insert a snippet that doesn’t have any `%cursor%` positions, the cursor goes to the end of the inserted text. This is convenient for inserting short static strings. For example, I have incantations for invoking a debugger at a given point in the code. This PR breaks this

Re: [Github-comments] [geany/geany] Better snippets (#1470)

2017-04-25 Thread Frank Lanitz
IMHO when inserting something without explicit cursor, it should jump to the end — but to be honest didn't had a look at the PR at all by now ;) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany

[Github-comments] [geany/geany-osx] Change filetype defs seem to don't have any effect (#7)

2017-04-25 Thread Frank Lanitz
I've updated the filetype-defintions for python via the Tools->Configuration Files->Filetype Configuration->Scripting Languages->fileytypes.python and added > [indentation] > width=4 > type=0 which should be also the default. But even after restarting Geany when opening a Python-file default i

Re: [Github-comments] [geany/geany] Track changes to line numbers for messages and compiler errors (#1481)

2017-04-25 Thread Vasiliy Faronov
@vfaronov pushed 1 commit. ef3702c Forget line shifts in message window on document (re)load -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/pull/1481/files/dfb12b9dfa33b18bf19cc98f7310c0f1a123a9b0..ef3702cde4cc2b7c3c8f74ab

Re: [Github-comments] [geany/geany-osx] Change filetype defs seem to don't have any effect (#7)

2017-04-25 Thread elextr
Is it being overridden by a project? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-osx/issues/7#issuecomment-297043801

Re: [Github-comments] [geany/geany-osx] Change filetype defs seem to don't have any effect (#7)

2017-04-25 Thread Frank Lanitz
No, it isn't -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-osx/issues/7#issuecomment-297052889

Re: [Github-comments] [geany/geany-osx] Change filetype defs seem to don't have any effect (#7)

2017-04-25 Thread Frank Lanitz
At least there is no open project according to the project menu. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-osx/issues/7#issuecomment-297052985

Re: [Github-comments] [geany/geany] Track changes to navqueue positions as a document is edited (#1480)

2017-04-25 Thread Vasiliy Faronov
@elextr I’m [trying out](https://github.com/vfaronov/geany/commit/ff1f28d8295e785abea27033d48c1e40d064373f) an approach based on Scintilla indicators. Instead of storing the actual position in the navqueue, I store a unique ID, and then fill that position with a special, hidden indicator with [

Re: [Github-comments] [geany/geany] Fuzzy typeahead search in sidebar (#1466)

2017-04-25 Thread Vasiliy Faronov
@elextr > But neither is very useful when looking for a symbol or file that exists many > times, such as a member like "length()" that exists on many classes or a file > that exists in several directories. And those cases are the times I am more > likely to actually want to search in the sideb

[Github-comments] [geany/geany] Create correct path for filetype config files (#1482)

2017-04-25 Thread Jiří Techet
Since filedef config files are now stored under the "filedef" subdirectory of app->datadir, we need to add the subdirectory name when creating path from the corresponding app->configdir otherwise the file isn't found. You can view, comment on, or merge this pull request online at: https://github

Re: [Github-comments] [geany/geany-osx] Change filetype defs seem to don't have any effect (#7)

2017-04-25 Thread Jiří Techet
@frlan I just tried and it works for me on Mac too. Are you sure you closed the file before retrying? (Otherwise the indentation type is stored into the session file.). Also don't you use indentation autodetection which could override it? I don't think spaces are default for Python - the defaul

Re: [Github-comments] [geany/geany] Fuzzy typeahead search in sidebar (#1466)

2017-04-25 Thread elextr
> A possible UI is to split the search key on the current filetype’s scope > separator (like . for Python, :: for C++), then match the last part against > tmtag->name and the preceding parts against tmtag->scope. So it would be neccessary to type `Classname::length` to find it? Thats possibl

Re: [Github-comments] [geany/geany] Create correct path for filetype config files (#1482)

2017-04-25 Thread elextr
Hmmm, on consideration, the whole idea of copying the global config is a bad idea, the user configs should only contain the fields they want to change, not hide the whole system config. But of course just dropping the user in an empty config file is unhelpful too. Maybe after creating the new

Re: [Github-comments] [geany/geany-osx] Change filetype defs seem to don't have any effect (#7)

2017-04-25 Thread elextr
Seems to work for me, but then I usually use spaces for everything so all my settings are `spaces` and maybe its one I forgot to change back to tabs that is making it work. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: ht

Re: [Github-comments] [geany/geany] Create correct path for filetype config files (#1482)

2017-04-25 Thread Matthew Brush
This PR just fixes the paths. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1482#issuecomment-297207707

Re: [Github-comments] [geany/geany] Create correct path for filetype config files (#1482)

2017-04-25 Thread elextr
Without the fix Geany does not copy the filetype files (albeit accidentally), so the user config doesn't hide the system config, so currently Geany does the right, but user unfriendly, thing. "Fixing" the paths will make Geany do the wrong thing again so it shouldn't happen alone. -- You ar

Re: [Github-comments] [geany/geany] Create correct path for filetype config files (#1482)

2017-04-25 Thread Matthew Brush
I just mean this PR is to fix simple bug in the code that caused a regression from previous versions. If you want to change the behaviour overall, you should make a new PR that properly removes/changes the affected code, leaving a bug in the source code is not really a good idea, IMO. -- You a