b4n approved this pull request.
Should be squashed, but LGTM
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1780#pullrequestreview-99132939
b4n requested changes on this pull request.
I fail to see what value these changes give, given that the "old" API is fully
functional (we spent some effort to make sure it'd still work flawlessly), and
the new one, while nicer, doesn't provide any actual new feature this plugin
would need.
@elextr pushed 1 commit.
cabb606 Improve explanation
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany/pull/1780/files/14f0f87d3643d20baa0f763e32cdee062b3dc4b5..cabb606087967e7d54b5d6de2e4a8bedcc9e6f07
b4n commented on this pull request.
> @@ -787,6 +787,9 @@ Building Plugins
The geany-plugins autotools script automatically detects the
installed system Geany and builds the plugins against that.
+Plugins will build with the version of GTK2/3 that the detected
+Geany was built with.
Can you re-rerun Geany passing `--g-fatal-warnings` argument and post this
backtrace?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/309#issuecomment-368277173
@Top-Dog did you actually mean version 1.23 ?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/309#issuecomment-368277116
Hop this helps. I'm running geany via Bash on Win10 using Xming Server, so I
could only attach to the running process. Might need to rebuild geany with -g
flag?
> (gdb) continue
> Continuing.
>
> Program received signal SIGSEGV, Segmentation fault.
> __strchr_sse2 () at
Would be useful if someone could [provide a
backtrace](https://www.geany.org/Support/Bugs) since it will show where the
crash happens.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Closed #706.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/706#event-1490587264
@elextr: no, the changes are only regarding GTK3 and VTE compatibility.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/697#issuecomment-368261597
@elextr
Big thanks :) I knew, I knew that I missed something, something trivial! :))
[Here](https://github.com/geany/geany-plugins/blob/master/geanylua/glspi_sci.h#L93)
uses ```SLT_INT``` type and I was wrong with marker number.
I have fixed it, replaced ```1``` on ```0x2```
```lua
local n =
@Skif-off To be even more explicit, geany will still support gtk2, its just the
changes in this PR make this plugin gtk3 only. Which is why I keep repeating
myself that it should be a separate plugin so it leaves the GTK2 version
available for those lucky people where it does not hang Geany.
Unfortunately iconv has no way of finding out what encodings are supported, so
Geany has a hard coded list of fairly common ones that its hoped all iconvs
support.
Geany can also open files with encodings that are not in its list but
detectable by iconv.
Somebody might look at allowing
marker next and previous take a mask not a marker number
[see](http://www.scintilla.org/ScintillaDoc.html#SCI_MARKERNEXT)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
I did try that with several different plugins.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1781#issuecomment-368242966
Cannot re-produce it myself now. I am now on GTK2. Will try some time later
again with GTK3.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1781#issuecomment-368242807
Did you try enabling/disabling a plugin fast? (On-Off-On-Off-On-Off-On-Help ==>
crash)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1781#issuecomment-368242218
I cannot reproduce here. Could [post a
backtrace](https://www.geany.org/Support/Bugs) to see where it's crashing?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Nothing more to say.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/708
-- Commit Summary --
* geanyctags: use new plugin API
-- File Changes --
M geanyctags/src/geanyctags.c (56)
-- Patch Links --
Nothing more to say.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/707
-- Commit Summary --
* devhelp: use new plugin API
-- File Changes --
M devhelp/src/dhp-plugin.c (98)
M devhelp/src/dhp-plugin.h (15)
-- Patch
Nothing more to say.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/705
-- Commit Summary --
* defineformat: use new plugin API
-- File Changes --
M defineformat/src/defineformat.c (47)
-- Patch Links --
Nothing more to say.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/704
-- Commit Summary --
* debugger: use new plugin API
-- File Changes --
M debugger/src/plugin.c (57)
-- Patch Links --
@LarsGit223
Thanks, I was confused by the
[GP_CHECK_PLUGIN_GTK**3_ONLY**](https://github.com/geany/geany-plugins/pull/697/files#diff-c6ec9ad09f6351d19420270032720e7eR4).
P.S. I use Xubuntu 17.10, but I compile on my own (I use [PR
1752](https://github.com/geany/geany/pull/1752)) and [I don't
Nothing more to say.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/703
-- Commit Summary --
* commander: use new plugin API.
-- File Changes --
M commander/src/commander-plugin.c (60)
-- Patch Links --
I would like to add CP949 in encoding format support.
Geany can not read Hangul CP949, which is higher than the EUC-KR we are
currently supporting.
I'm looking forward to it.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
To be explicit: Geany will still support GTK2. It will not be dropped.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/697#issuecomment-368228470
If I click on the help button in the Plugin Manager then it shows me the help
for that plugin. This usually works fine.
But if I enable and disable a plugin a few times and click on help after that,
then geany will crash quite likely. This happens no matter if the plugin is
using the old or
@Skif-off:
No. By default geany compiles/is built for GTK2. If you specify the option
```--enable-gtk3``` on build then it will be build for GTK3. Then only plugins
would work with that version of geany which support GTK3.
Which OS/distro do you use? Many linux distros support both GTK
Nothing more to say.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/702
-- Commit Summary --
* codenav: use new plugin API.
-- File Changes --
M codenav/src/codenavigation.c (58)
-- Patch Links --
@LarsGit223
Sorry, I didn't understand :) Is Geany drop to support GTK2?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/697#issuecomment-368226268
Nothing more to say.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/701
-- Commit Summary --
* automark: use new plugin API
-- File Changes --
M automark/src/automark.c (52)
-- Patch Links --
@Skif-off: no. As the PR is right now, it would only support GTK3.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/697#issuecomment-368225208
@LarsGit223
Why ```GP_CHECK_PLUGIN_GTK3_ONLY```? Is plugin don't support build with GTK2
now?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/697#issuecomment-368225063
Nothing more to say.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/700
-- Commit Summary --
* autoclose: use new plugin API
-- File Changes --
M autoclose/src/autoclose.c (55)
-- Patch Links --
Switched to new plugin API:
- moved all plugin API code to the end of file
- therefore also some function declarations became needless and could be removed
- added help function
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/699
--
35 matches
Mail list logo
