Still hijacking this PR for the moment:
Oops. Normally all we'd have to do is properly fill
`extensionFields.scopeIndex`, like that:
```
diff --git a/ctags/parsers/rest.c b/ctags/parsers/rest.c
index 1a9dd2e22..a192babf3 100644
--- a/ctags/parsers/rest.c
+++ b/ctags/parsers/rest.c
@@ -34,11 +34,
There is currently no settings for keybinding mark all (which is what the
addons double click mark all actiavtes) and its fixed to match case only.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/gea
It says on [documentation ](https://plugins.geany.org/addons.html)
> When double-clicking a word, all occurrences of this word are searched and
> then highlighted (similar to Geany's 'Mark All' Find option).
However, `Geany's 'Mark All'` highlight same word in different cases. Ex.
`Request`,
@techee since master is also broken please make your patch a separate PR on
master so it can be fixed.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2018#issuecomment-448055915
elextr commented on this pull request.
> @@ -78,7 +78,7 @@ static void makeAsciidocTag (const vString* const name,
> const int kind)
{
tagEntryInfo e;
- initTagEntry (&e, vStringValue (name), &(AsciidocKinds [kind]));
+ initTagEntry (&e, vSt
> Would tests have picked up extension stuff?
Yep, this would appear in the tags file. I'll grab some tests from uctags (and
maybe check if we have at least 1 test for every file type) so problems like
that don't appear in the future - especially important now that we make many
changes in our c
techee commented on this pull request.
> @@ -78,7 +78,7 @@ static void makeAsciidocTag (const vString* const name,
> const int kind)
{
tagEntryInfo e;
- initTagEntry (&e, vStringValue (name), &(AsciidocKinds [kind]));
+ initTagEntry (&e, vSt
@techee overlapping comments :)
Would tests have picked up extension stuff?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2018#issuecomment-448051549
elextr commented on this pull request.
> @@ -78,7 +78,7 @@ static void makeAsciidocTag (const vString* const name,
> const int kind)
{
tagEntryInfo e;
- initTagEntry (&e, vStringValue (name), &(AsciidocKinds [kind]));
+ initTagEntry (&e, vSt
@elextr Thanks for noticing - apparently scope info is missing, this also
affects current master. It seems we don't have asciidoc and rest unit tests :(.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/gea
Asciidoc parser is broken, it no longer shows the document outline, instead the
headings are grouped by section levels. Same with ReST.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/201
Had to create the new pull request quickly - not having a huge ctags-related
pull request in Geany brings bad luck!
This pull request brings the changes from upstream ctags made in the last 2
years so that parsers are compatible with uctags parsers. This isn't a complete
sync to avoid too big p
So… more than 2 years after, this is merged! Thanks, and we're ready for more
:)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1263#issuecomment-448001272
> Doesn't the regex syntax differ between them?
Hum, good point, it might. Although, it probably is "mostly" the same if using
the same extension mode. IIRC GRegex is using gnu regex, but maybe modified.
> The diff against ctags looked really scary but maybe if I just took the
> uctags versio
Merged #1263 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1263#event-2031376543
> Hum… on one hand it's kind of sad not to allow regex parsers because some
> u-ctags parser use it (12 built-in ones apparently), and it makes creating a
> basic parser easier; on the other I already said that I'd rather not have an
> additional copy of the GNU regex lib and I understand that h
b4n approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1263#pullrequestreview-185783734
> I guess it's kind of safe to assume now that there won't be too many changes
> in this pull request, right?
yeah, should be pretty close to merge.
> Question: there seem to be quite massive changes in the lregex.c/h upstream
> and this one isn't so trivial to merge because we use GRegex and c
techee commented on this pull request.
>
if (vStringLength (name) > 0)
{
+ tagEntryInfo *parent = getEntryOfNestingLevel (nl);
Done.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://
techee commented on this pull request.
>
if (vStringLength (name) > 0)
{
+ tagEntryInfo *parent = getEntryOfNestingLevel (nl);
Ah, OK, I misunderstood (and sadly didn't read the code enough and fell to the
trap). I'll fix that and re-push this patch.
--
You ar
b4n commented on this pull request.
>
if (vStringLength (name) > 0)
{
+ tagEntryInfo *parent = getEntryOfNestingLevel (nl);
It's incorrect, because I stated in my commend above, we still have to call
`getNestingLevel()` because it's that function that calls `nes
Closed #796.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/796#event-2030647143
@eht16 OK. Reopen PR once done.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/796#issuecomment-447895859
BTW: We should consider using git-subtree for future updates. This allows us to
track an upstream git repository while having local changes. Then updating
becomes a simple merge.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitH
Just for info, I've synced ctags to the state where the majority of parsers can
just be copied from upstream ctags without any modification. The code is here
https://github.com/techee/geany/commits/ctags_sync3
and I'll convert it to a proper pull request once this pull request is merged.
As par
Merged #9 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/pull/9#event-2029883059
26 matches
Mail list logo
