Re: [Github-comments] [geany/geany] Adding native support for the Gibiane language (http://www-cast3m.cea.fr) (#2246)

2019-08-06 Thread elextr
I have a question, what do you think you will gain by having this in the Geany core, given that (AFAIK) none of the normal contributors normally have access to the toolset for the language, so we will not be able to support it much. So you will be maintaining it yourself anyway. And given

Re: [Github-comments] [geany/geany] Replace search dialog with search bar (#2220)

2019-08-06 Thread Matthew Brush
> Discussion on it looks like a never-ending story. Yeah, ideally it happens before the pull request on the developers mailing list. > Of course, it's the question who and how to ask. I guess the user's mailing list is the best/only place, at least if anyone is strongly for or against it they

Re: [Github-comments] [geany/geany] Replace search dialog with search bar (#2220)

2019-08-06 Thread js361014
>The thing is, a lot of users probably won't prefer the new search bar The thing is, we don't really know what most users would prefer. Discussion on it looks like a never-ending story. I suggest to make this change be as good as possible and then ask users what they prefer. Of course, it's

Re: [Github-comments] [geany/geany] Replace search dialog with search bar (#2220)

2019-08-06 Thread Matthew Brush
> It's strange that we add something, make it default, and then we hide from in > existing installations. The thing is, a lot of users probably won't like the new search bar, so it doesn't seem very polite to thrust it on them. This is another reason it would make more sense as a plugin. --

Re: [Github-comments] [geany/geany] Replace search dialog with search bar (#2220)

2019-08-06 Thread Matthew Brush
> Combining the dialogs (and consequently the bars) is a different topic then. Why? Just because the original code wasn't factored properly and contained a bunch of redundancy doesn't mean new code should too. The two dialogs contain almost entirely the same UI and code, and really the Find

Re: [Github-comments] [geany/geany] Show the GTK/GLib versions in about dialog (#2163)

2019-08-06 Thread Thomas Martitz
kugel- approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2163#pullrequestreview-271380329

Re: [Github-comments] [geany/geany] Show the GTK/GLib versions in about dialog (#2163)

2019-08-06 Thread Thomas Martitz
Tested and works fine. One could argue that this information could be expected directly under the Geany version but gets the job done just as well. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] Replace search dialog with search bar (#2220)

2019-08-06 Thread Thomas Martitz
> Search and replace dialog and search dialog are now different dialogs. I > guess search bar and replace bar and search bar could be separated as well > (obviously, they can use some same functions). Err, yes, you are right. I didn't have enough coffee it seems. So the bars should be separate

Re: [Github-comments] [geany/geany] Plugin-API: extended project API (#2234)

2019-08-06 Thread LarsGit223
Done. I changed the function names to codebrainz suggestion and added his function documentation. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2234#issuecomment-518609389

Re: [Github-comments] [geany/geany] Easier project creation (#2245)

2019-08-06 Thread elextr
@kugel- > I think projects in Geany need a complete rethinking and rework ... Agreed. I don't think Geany does projects, and the feature it has thats called "projects" is misnamed. That causes people to expect something like all the other IDEs "projects" features. The current really

Re: [Github-comments] [geany/geany] Replace search dialog with search bar (#2220)

2019-08-06 Thread js361014
It's strange that we add something, make it default, and then we hide from in existing installations. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2220#issuecomment-518561922

Re: [Github-comments] [geany/geany] Replace search dialog with search bar (#2220)

2019-08-06 Thread elextr
> Do we really need to do this? Yes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2220#issuecomment-518559979

[Github-comments] [geany/geany] Adding native support for the Gibiane language (http://www-cast3m.cea.fr) (#2246)

2019-08-06 Thread ThibLind
Hello, This is the pull request for the Gibiane language support in Geany. Sincerely, Thibault LINDECKER, The Cast3M support. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/2246 -- Commit Summary -- * Adding native support for the

Re: [Github-comments] [geany/geany] Replace search dialog with search bar (#2220)

2019-08-06 Thread js361014
>Not really. It can be separate commits here but the change should be done >wholesale. Search and replace dialog and search dialog are now different dialogs. I guess search bar and replace bar and search bar could be separated as well (obviously, they can use some same functions). If it were

Re: [Github-comments] [geany/geany] Easier project creation (#2245)

2019-08-06 Thread LarsGit223
> Projects are currently rather poor. Annoying to set up and they don't offer > truly useful features that justify setting them up. This is why so many > project plugins exist, but they rather add more features to the project > instead of making the setup easier. But those plugins cross the

Re: [Github-comments] [geany/geany] Easier project creation (#2245)

2019-08-06 Thread Thomas Martitz
TL;DR: I think projects in Geany need a complete rethinking and rework I agree with the principle here. Geany wants to be fast and small but with powerful features. So I agree that we should ship a bare minimum feature-set to turn a "drive-by git clone" into a (temporary) project, with some

Re: [Github-comments] [geany/geany-plugins] JSON autoformater plugin (#891)

2019-08-06 Thread elextr
Set custom command `python3 -m json.tool`. For more details see [here](https://docs.python.org/3/library/json.html#json-commandline) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] Replace search dialog with search bar (#2220)

2019-08-06 Thread Thomas Martitz
I'm running Arch Linux, Geany on GTK+3 3.24.10, glib 2.60.6 > I suggested in #2220 (comment) to provide it in another PR. Is it OK to you? Not really. It can be separate commits here but the change should be done wholesale. > Since it's a new UI for existing functionality there shouldn't be

[Github-comments] [geany/geany-plugins] JSON autoformater plugin (#891)

2019-08-06 Thread Frank Lanitz
It would be awesome to have a plugin similar to XML Pretty printer to format JSON nicely -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/891

Re: [Github-comments] [geany/geany] Replace search dialog with search bar (#2220)

2019-08-06 Thread js361014
@kugel- > Maybe I missed something but on my system it doesn't seem to work. Hitting > ctrl+f does nothing, wit h either top or bottom options. What's your system? > I would accept this only if it can replace the search dialog entirely, > including replace functionality. I suggested in